Browse Source

Unit test + fix.

pull/400/head
Greg Holmes 9 years ago
parent
commit
b0cd1fc8c7

+ 1
- 1
jpq/src/com/dmdirc/addons/jpq/JPQManager.java View File

@@ -105,7 +105,7 @@ public class JPQManager {
105 105
     @VisibleForTesting
106 106
     @Handler
107 107
     void handleGroupChatRemoved(final ChannelSelfPartEvent event) {
108
-        addGroupChatHandler(event.getChannel());
108
+        removeGroupChatHandler(event.getChannel());
109 109
     }
110 110
 
111 111
     @VisibleForTesting

+ 21
- 0
jpq/test/com/dmdirc/addons/jpq/JPQManagerTest.java View File

@@ -4,6 +4,8 @@ import com.dmdirc.DMDircMBassador;
4 4
 import com.dmdirc.config.prefs.PreferencesCategory;
5 5
 import com.dmdirc.config.prefs.PreferencesSetting;
6 6
 import com.dmdirc.config.prefs.PreferencesType;
7
+import com.dmdirc.events.ChannelSelfJoinEvent;
8
+import com.dmdirc.events.ChannelSelfPartEvent;
7 9
 import com.dmdirc.events.GroupChatPrefsRequestedEvent;
8 10
 import com.dmdirc.events.ServerConnectedEvent;
9 11
 import com.dmdirc.events.ServerDisconnectedEvent;
@@ -37,6 +39,8 @@ public class JPQManagerTest {
37 39
     @Mock private ServerConnectedEvent serverConnectedEvent;
38 40
     @Mock private ServerDisconnectedEvent serverDisconnectedEvent;
39 41
     @Mock private GroupChatPrefsRequestedEvent groupChatPrefsRequestedEvent;
42
+    @Mock private ChannelSelfJoinEvent channelSelfJoinEvent;
43
+    @Mock private ChannelSelfPartEvent channelSelfPartEvent;
40 44
     @Mock private PreferencesCategory prefsCategory;
41 45
     @Mock private AggregateConfigProvider configProvider;
42 46
     @Captor private ArgumentCaptor<PreferencesSetting> preferencesSetting;
@@ -72,6 +76,8 @@ public class JPQManagerTest {
72 76
                 .thenReturn(Lists.newArrayList(connection1, connection2));
73 77
         when(groupChatPrefsRequestedEvent.getCategory()).thenReturn(prefsCategory);
74 78
         when(groupChatPrefsRequestedEvent.getConfig()).thenReturn(configProvider);
79
+        when(channelSelfJoinEvent.getChannel()).thenReturn(groupChat3);
80
+        when(channelSelfPartEvent.getChannel()).thenReturn(groupChat3);
75 81
         when(configProvider.getOption(anyString(), anyString())).thenReturn("true");
76 82
         instance = new JPQManager("domain", connectionManager, groupChatHandlerFactory, eventBus);
77 83
     }
@@ -119,4 +125,19 @@ public class JPQManagerTest {
119 125
         verify(groupChatHandler1).unload();
120 126
         verify(groupChatHandler2).unload();
121 127
     }
128
+
129
+    @Test
130
+    public void testGroupChatAdded() throws Exception {
131
+        instance.handleConnectionAdded(serverConnectedEvent);
132
+        instance.handleGroupChatAdded(channelSelfJoinEvent);
133
+        verify(groupChatHandlerFactory).get(groupChat3);
134
+    }
135
+
136
+    @Test
137
+    public void testGroupChatRemoved() throws Exception {
138
+        instance.handleGroupChatAdded(channelSelfJoinEvent);
139
+        verify(groupChatHandlerFactory).get(groupChat3);
140
+        instance.handleGroupChatRemoved(channelSelfPartEvent);
141
+        verify(groupChatHandler3).unload();
142
+    }
122 143
 }

Loading…
Cancel
Save