Fix some crazy concurrency in ErrorTableModel

Fixes CLIENT-4

Change-Id: If182e71e72acc048d0474fa6f48d3c0a8ba0f57a
Reviewed-on: http://gerrit.dmdirc.com/1590
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

src/com/dmdirc/addons/ui_swing/dialogs/error/ErrorTableModel.java

@@ -73,8 +73,10 @@ public final class ErrorTableModel extends AbstractTableModel implements
      * @param errors List of errors
      */
     public void setErrors(final List<ProgramError> errors) {
-        this.errors.clear();
-        this.errors.addAll(errors);
+        synchronized (errors) {
+            this.errors.clear();
+            this.errors.addAll(errors);
+        }
 
         fireTableDataChanged();
     }
@@ -82,9 +84,7 @@ public final class ErrorTableModel extends AbstractTableModel implements
     /** {@inheritDoc} */
     @Override
     public int getRowCount() {
-        synchronized (errors) {
-            return errors.size();
-        }
+        return errors.size();
     }
 
     /** {@inheritDoc} */
@@ -255,9 +255,7 @@ public final class ErrorTableModel extends AbstractTableModel implements
             /** {@inheritDoc} */
             @Override
             public void run() {
-                synchronized (ErrorTableModel.this) {
-                    addRow(error);
-                }
+                addRow(error);
             }
         });
     }
@@ -270,9 +268,7 @@ public final class ErrorTableModel extends AbstractTableModel implements
             /** {@inheritDoc} */
             @Override
             public void run() {
-                synchronized (ErrorTableModel.this) {
-                    removeRow(error);
-                }
+                removeRow(error);
             }
         });
     }
@@ -285,7 +281,7 @@ public final class ErrorTableModel extends AbstractTableModel implements
             /** {@inheritDoc} */
             @Override
             public void run() {
-                synchronized (ErrorTableModel.this) {
+                synchronized (errors) {
                     final int errorRow = indexOf(error);
                     if (errorRow != -1 && errorRow < getRowCount()) {
                         fireTableRowsUpdated(errorRow, errorRow);