display blocking is broken, handle properly.

StadardQuestion dialog only tells you about one result.

Fixes issue 3964

Change-Id: I247c3bc8ffc5a2050eec6ba797e3ea1cf606eca7
Reviewed-on: http://gerrit.dmdirc.com/1382
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

src/com/dmdirc/addons/ui_swing/components/SwingSearchBar.java

@@ -271,25 +271,30 @@ public final class SwingSearchBar extends JPanel implements ActionListener,
                  /**{@inheritDoc} */
                  @Override
                  public boolean save() {
+                     textPane.setScrollBarPosition(result.getEndLine());
+                     textPane.setSelectedTexT(result);
+                     validator.setValidates(true);
+                     searchBox.checkError();
                      return true;
                  }
 
+                 /**{@inheritDoc} */
                  @Override
                  public void cancelled() {
-                     //Continue
+                     validator.setValidates(true);
+                     searchBox.checkError();
                  }
             };
-            dialog.displayBlocking();
-            foundText = dialog.getResult();
+            dialog.display();
+            return;
         } else {
             //found, select and return found
             textPane.setScrollBarPosition(result.getEndLine());
             textPane.setSelectedTexT(result);
             foundText = true;
+            validator.setValidates(foundText);
+            searchBox.checkError();
         }
-
-        validator.setValidates(foundText);
-        searchBox.checkError();
     }
 
     /**

src/com/dmdirc/addons/ui_swing/dialogs/StandardQuestionDialog.java

@@ -125,7 +125,9 @@ public abstract class StandardQuestionDialog extends StandardDialog {
             /** {@inheritDoc} */
             @Override
             public void windowClosed(WindowEvent e) {
-                cancelled();
+                if (!result) {
+                    cancelled();
+                }
             }
         });
     }