Support for new action versioning

Issue 3943

Change-Id: I9f769f243178022528da65fe4c15abbd62d9e49c
Depends-On: I1419fa74d8da7f3f5d96a00dea559329db008b0e
Reviewed-on: http://gerrit.dmdirc.com/1046
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Automatic-Compile: Shane Mc Cormack <shane@dmdirc.com>

src/com/dmdirc/addons/ui_swing/dialogs/actionsmanager/ActionGroupInformationPanel.java

@@ -112,12 +112,12 @@ public final class ActionGroupInformationPanel extends JPanel {
         if (shouldDisplay()) {
             infoLabel.setText(group.getDescription());
             author.setText(group.getAuthor());
-            version.setText(Integer.toString(group.getVersion()));
+            version.setText(group.getVersion() == null ? "" : group.getVersion().toString());
 
             author.setVisible(group.getAuthor() != null);
-            version.setVisible(group.getVersion() != -1);
+            version.setVisible(group.getVersion() != null);
             authorLabel.setVisible(group.getAuthor() != null);
-            versionLabel.setVisible(group.getVersion() != -1);
+            versionLabel.setVisible(group.getVersion() != null);
         } else {
             infoLabel.setText("");
             author.setText("");

test/com/dmdirc/addons/ui_swing/dialogs/actionsmanager/ActionGroupInformationPanelTest.java

@@ -23,6 +23,7 @@
 package com.dmdirc.addons.ui_swing.dialogs.actionsmanager;
 
 import com.dmdirc.actions.ActionGroup;
+import com.dmdirc.updater.Version;
 import org.junit.Test;
 import org.uispec4j.Panel;
 import org.uispec4j.UISpecTestCase;
@@ -53,7 +54,7 @@ public class ActionGroupInformationPanelTest extends UISpecTestCase {
     public void testAllLabels() {
         final ActionGroup group = mock(ActionGroup.class);
         when(group.getDescription()).thenReturn("description");
-        when(group.getVersion()).thenReturn(17);
+        when(group.getVersion()).thenReturn(new Version(17));
         when(group.getAuthor()).thenReturn("foo <bar@baz>");
         
         final Panel panel = new Panel(new ActionGroupInformationPanel(group));
@@ -71,7 +72,7 @@ public class ActionGroupInformationPanelTest extends UISpecTestCase {
     public void testNoAuthor() {
         final ActionGroup group = mock(ActionGroup.class);
         when(group.getDescription()).thenReturn("description");
-        when(group.getVersion()).thenReturn(17);
+        when(group.getVersion()).thenReturn(new Version(17));
 
         final Panel panel = new Panel(new ActionGroupInformationPanel(group));
 
@@ -86,7 +87,7 @@ public class ActionGroupInformationPanelTest extends UISpecTestCase {
     public void testNoVersion() {
         final ActionGroup group = mock(ActionGroup.class);
         when(group.getDescription()).thenReturn("description");
-        when(group.getVersion()).thenReturn(-1);
+        when(group.getVersion()).thenReturn(null);
         when(group.getAuthor()).thenReturn("foo <bar@baz>");
 
         final Panel panel = new Panel(new ActionGroupInformationPanel(group));