瀏覽代碼

Tidy up some windowClosed/windowClosing methods.

Change-Id: I9b8dc2b1f7f42e8a2394dcb914bdb17064ae6150
Reviewed-on: http://gerrit.dmdirc.com/3010
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
tags/0.8
Chris Smith 10 年之前
父節點
當前提交
5c216d55c2

+ 0
- 6
src/com/dmdirc/addons/dcc/DCCFrameContainer.java 查看文件

102
         // 5: Inform any parents that the window is closing
102
         // 5: Inform any parents that the window is closing
103
     }
103
     }
104
 
104
 
105
-    /** {@inheritDoc} */
106
-    @Override
107
-    public void windowClosed() {
108
-        // 7: Remove any references to the window and parents
109
-    }
110
-
111
 }
105
 }

+ 0
- 6
src/com/dmdirc/addons/dcc/PlaceholderContainer.java 查看文件

116
         plugin.removeContainer();
116
         plugin.removeContainer();
117
     }
117
     }
118
 
118
 
119
-    /** {@inheritDoc} */
120
-    @Override
121
-    public void windowClosed() {
122
-        // 7: Remove any references to the window and parents
123
-    }
124
-
125
     /** {@inheritDoc} */
119
     /** {@inheritDoc} */
126
     @Override
120
     @Override
127
     public void removeChild(final FrameContainer child) {
121
     public void removeChild(final FrameContainer child) {

+ 0
- 6
src/com/dmdirc/addons/dcc/TransferContainer.java 查看文件

364
         // 5: Inform any parents that the window is closing
364
         // 5: Inform any parents that the window is closing
365
     }
365
     }
366
 
366
 
367
-    /** {@inheritDoc} */
368
-    @Override
369
-    public void windowClosed() {
370
-        // 7: Remove any references to the window and parents
371
-    }
372
-
373
     public void addSocketCloseCallback(final SocketCloseListener listener) {
367
     public void addSocketCloseCallback(final SocketCloseListener listener) {
374
         if (connection != null && connection.getParser() != null) {
368
         if (connection != null && connection.getParser() != null) {
375
             connection.getParser().getCallbackManager()
369
             connection.getParser().getCallbackManager()

+ 0
- 15
src/com/dmdirc/addons/logging/HistoryWindow.java 查看文件

52
         addLine(reader.getLinesAsString(Math.min(frameBufferSize, numLines)), false);
52
         addLine(reader.getLinesAsString(Math.min(frameBufferSize, numLines)), false);
53
     }
53
     }
54
 
54
 
55
-    /** {@inheritDoc} */
56
-    @Override
57
-    public void windowClosing() {
58
-        // 2: Remove any callbacks or listeners
59
-        // 3: Trigger any actions neccessary
60
-        // 4: Trigger action for the window closing
61
-        // 5: Inform any parents that the window is closing
62
-    }
63
-
64
-    /** {@inheritDoc} */
65
-    @Override
66
-    public void windowClosed() {
67
-        // 7: Remove any references to the window and parents
68
-    }
69
-
70
     /** {@inheritDoc} */
55
     /** {@inheritDoc} */
71
     @Override
56
     @Override
72
     public Connection getConnection() {
57
     public Connection getConnection() {

+ 3
- 12
src/com/dmdirc/addons/parserdebug/DebugWindow.java 查看文件

37
 public class DebugWindow extends FrameContainer {
37
 public class DebugWindow extends FrameContainer {
38
 
38
 
39
     /** The plugin that owns this window */
39
     /** The plugin that owns this window */
40
-    protected DebugPlugin plugin;
40
+    protected final DebugPlugin plugin;
41
     /** The parser this window is debugging */
41
     /** The parser this window is debugging */
42
     protected Parser parser;
42
     protected Parser parser;
43
     /** The connection we're operating on */
43
     /** The connection we're operating on */
44
-    protected Connection connection;
44
+    protected final Connection connection;
45
 
45
 
46
     /**
46
     /**
47
      * Creates a new instance of DebugWindow.
47
      * Creates a new instance of DebugWindow.
79
         parser = null;
79
         parser = null;
80
     }
80
     }
81
 
81
 
82
-
83
     /**
82
     /**
84
-     * Closes this container (and it's associated frame).
83
+     * Closes this container (and its associated frame).
85
      */
84
      */
86
     @Override
85
     @Override
87
     public void windowClosing() {
86
     public void windowClosing() {
95
         // 5: Inform any parents that the window is closing
94
         // 5: Inform any parents that the window is closing
96
     }
95
     }
97
 
96
 
98
-    /** {@inheritDoc} */
99
-    @Override
100
-    public void windowClosed() {
101
-        // 7: Remove any references to the window and parents
102
-        this.parser = null;
103
-        this.connection = null;
104
-        this.plugin = null;
105
-    }
106
 }
97
 }

+ 0
- 11
src/com/dmdirc/addons/redirect/FakeWriteableFrameContainer.java 查看文件

116
         return target.getConnection();
116
         return target.getConnection();
117
     }
117
     }
118
 
118
 
119
-    /** {@inheritDoc} */
120
-    @Override
121
-    public void windowClosing() {
122
-        // Do nothing
123
-    }
124
-
125
-    /** {@inheritDoc} */
126
-    @Override
127
-    public void windowClosed() {
128
-        // Do nothing
129
-    }
130
 }
119
 }

+ 0
- 6
src/com/dmdirc/addons/swingdebug/SystemStreamContainer.java 查看文件

77
         // 5: Inform any parents that the window is closing
77
         // 5: Inform any parents that the window is closing
78
     }
78
     }
79
 
79
 
80
-    /** {@inheritDoc} */
81
-    @Override
82
-    public void windowClosed() {
83
-        // 7: Remove any references to the window and parents
84
-    }
85
-
86
 }
80
 }

Loading…
取消
儲存