Pārlūkot izejas kodu

Merge pull request #456 from csmith/master

Remove FrameContainer parent/child fields.
pull/457/head
Greg Holmes 8 gadus atpakaļ
vecāks
revīzija
57586c0b8c

+ 1
- 2
dcc/src/com/dmdirc/addons/dcc/ChatContainer.java Parādīt failu

68
      * @param eventBus            The bus to dispatch events on.
68
      * @param eventBus            The bus to dispatch events on.
69
      */
69
      */
70
     public ChatContainer(
70
     public ChatContainer(
71
-            @Nullable final WindowModel parent,
72
             final DCCChat dcc,
71
             final DCCChat dcc,
73
             final AggregateConfigProvider configManager,
72
             final AggregateConfigProvider configManager,
74
             final BackBufferFactory backBufferFactory,
73
             final BackBufferFactory backBufferFactory,
78
             final String targetNick,
77
             final String targetNick,
79
             final TabCompleterFactory tabCompleterFactory,
78
             final TabCompleterFactory tabCompleterFactory,
80
             final DMDircMBassador eventBus) {
79
             final DMDircMBassador eventBus) {
81
-        super(parent, title, "dcc-chat-inactive", configManager, backBufferFactory,
80
+        super(title, "dcc-chat-inactive", configManager, backBufferFactory,
82
                 new DCCCommandParser(configManager, commandController, eventBus),
81
                 new DCCCommandParser(configManager, commandController, eventBus),
83
                 tabCompleterFactory,
82
                 tabCompleterFactory,
84
                 eventBus,
83
                 eventBus,

+ 0
- 1
dcc/src/com/dmdirc/addons/dcc/DCCCommand.java Parādīt failu

157
         final DCCChat chat = new DCCChat();
157
         final DCCChat chat = new DCCChat();
158
         if (myPlugin.listen(chat)) {
158
         if (myPlugin.listen(chat)) {
159
             final ChatContainer window = new ChatContainer(
159
             final ChatContainer window = new ChatContainer(
160
-                    myPlugin.getContainer(),
161
                     chat,
160
                     chat,
162
                     origin.getConfigManager(),
161
                     origin.getConfigManager(),
163
                     backBufferFactory,
162
                     backBufferFactory,

+ 1
- 6
dcc/src/com/dmdirc/addons/dcc/DCCFrameContainer.java Parādīt failu

26
 import com.dmdirc.FrameContainer;
26
 import com.dmdirc.FrameContainer;
27
 import com.dmdirc.commandparser.parsers.CommandParser;
27
 import com.dmdirc.commandparser.parsers.CommandParser;
28
 import com.dmdirc.interfaces.Connection;
28
 import com.dmdirc.interfaces.Connection;
29
-import com.dmdirc.interfaces.WindowModel;
30
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
29
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
31
 import com.dmdirc.ui.input.TabCompleterFactory;
30
 import com.dmdirc.ui.input.TabCompleterFactory;
32
 import com.dmdirc.ui.messages.BackBufferFactory;
31
 import com.dmdirc.ui.messages.BackBufferFactory;
34
 import java.util.Collection;
33
 import java.util.Collection;
35
 import java.util.Optional;
34
 import java.util.Optional;
36
 
35
 
37
-import javax.annotation.Nullable;
38
-
39
 /**
36
 /**
40
  * This class links DCC objects to a window.
37
  * This class links DCC objects to a window.
41
  */
38
  */
47
     /**
44
     /**
48
      * Creates a new instance of DCCFrame.
45
      * Creates a new instance of DCCFrame.
49
      *
46
      *
50
-     * @param parent              The parent of this frame container, if any.
51
      * @param title               The title of this window
47
      * @param title               The title of this window
52
      * @param icon                The icon to use
48
      * @param icon                The icon to use
53
      * @param configManager       Config manager
49
      * @param configManager       Config manager
57
      * @param components          The UI components that this frame requires
53
      * @param components          The UI components that this frame requires
58
      */
54
      */
59
     public DCCFrameContainer(
55
     public DCCFrameContainer(
60
-            @Nullable final WindowModel parent,
61
             final String title,
56
             final String title,
62
             final String icon,
57
             final String icon,
63
             final AggregateConfigProvider configManager,
58
             final AggregateConfigProvider configManager,
66
             final TabCompleterFactory tabCompleterFactory,
61
             final TabCompleterFactory tabCompleterFactory,
67
             final DMDircMBassador eventBus,
62
             final DMDircMBassador eventBus,
68
             final Collection<String> components) {
63
             final Collection<String> components) {
69
-        super(parent, icon, title, title, configManager, backBufferFactory,
64
+        super(icon, title, title, configManager, backBufferFactory,
70
                 tabCompleterFactory.getTabCompleter(configManager),
65
                 tabCompleterFactory.getTabCompleter(configManager),
71
                 eventBus,
66
                 eventBus,
72
                 components);
67
                 components);

+ 0
- 1
dcc/src/com/dmdirc/addons/dcc/DCCManager.java Parādīt failu

463
         chat.setAddress(ipAddress, port);
463
         chat.setAddress(ipAddress, port);
464
         final String myNickname = parser.getLocalClient().getNickname();
464
         final String myNickname = parser.getLocalClient().getNickname();
465
         final DCCFrameContainer container = new ChatContainer(
465
         final DCCFrameContainer container = new ChatContainer(
466
-                getContainer(),
467
                 chat,
466
                 chat,
468
                 config,
467
                 config,
469
                 backBufferFactory,
468
                 backBufferFactory,

+ 1
- 10
dcc/src/com/dmdirc/addons/dcc/PlaceholderContainer.java Parādīt failu

62
             final Window parentWindow,
62
             final Window parentWindow,
63
             final WindowManager windowManager,
63
             final WindowManager windowManager,
64
             final DMDircMBassador eventBus) {
64
             final DMDircMBassador eventBus) {
65
-        super(null, "dcc", "DCCs", "DCCs", config, backBufferFactory, eventBus,
65
+        super("dcc", "DCCs", "DCCs", config, backBufferFactory, eventBus,
66
                 Collections.singletonList("com.dmdirc.addons.dcc.ui.PlaceholderPanel"));
66
                 Collections.singletonList("com.dmdirc.addons.dcc.ui.PlaceholderPanel"));
67
         this.plugin = plugin;
67
         this.plugin = plugin;
68
         this.parentWindow = parentWindow;
68
         this.parentWindow = parentWindow;
99
         return Optional.empty();
99
         return Optional.empty();
100
     }
100
     }
101
 
101
 
102
-    @Override
103
-    public void removeChild(final WindowModel child) {
104
-        super.removeChild(child);
105
-
106
-        if (windowManager.getChildren(this).isEmpty()) {
107
-            close();
108
-        }
109
-    }
110
-
111
 }
102
 }

+ 1
- 1
dcc/src/com/dmdirc/addons/dcc/TransferContainer.java Parādīt failu

88
             final BackBufferFactory backBufferFactory, final String title,
88
             final BackBufferFactory backBufferFactory, final String title,
89
             final String targetNick, @Nullable final Connection connection,
89
             final String targetNick, @Nullable final Connection connection,
90
             final DMDircMBassador eventBus) {
90
             final DMDircMBassador eventBus) {
91
-        super(plugin.getContainer(), dcc.getType() == DCCTransfer.TransferType.SEND
91
+        super(dcc.getType() == DCCTransfer.TransferType.SEND
92
                 ? "dcc-send-inactive" : "dcc-receive-inactive",
92
                 ? "dcc-send-inactive" : "dcc-receive-inactive",
93
                 title, title, config, backBufferFactory, eventBus,
93
                 title, title, config, backBufferFactory, eventBus,
94
                 Arrays.asList("com.dmdirc.addons.dcc.ui.TransferPanel"));
94
                 Arrays.asList("com.dmdirc.addons.dcc.ui.TransferPanel"));

+ 1
- 1
debug/src/com/dmdirc/addons/debug/RawWindow.java Parādīt failu

49
             final Connection connection,
49
             final Connection connection,
50
             final TabCompleterFactory tabCompleterFactory,
50
             final TabCompleterFactory tabCompleterFactory,
51
             final BackBufferFactory backBufferFactory) {
51
             final BackBufferFactory backBufferFactory) {
52
-        super(connection.getWindowModel(), "raw", "Raw", "(Raw log)",
52
+        super("raw", "Raw", "(Raw log)",
53
                 connection.getWindowModel().getConfigManager(),
53
                 connection.getWindowModel().getConfigManager(),
54
                 backBufferFactory,
54
                 backBufferFactory,
55
                 tabCompleterFactory.getTabCompleter(connection.getWindowModel().getTabCompleter(),
55
                 tabCompleterFactory.getTabCompleter(connection.getWindowModel().getTabCompleter(),

+ 1
- 1
logging/src/com/dmdirc/addons/logging/HistoryWindow.java Parādīt failu

63
             final DMDircMBassador eventBus,
63
             final DMDircMBassador eventBus,
64
             final BackBufferFactory backBufferFactory,
64
             final BackBufferFactory backBufferFactory,
65
             final int numLines) {
65
             final int numLines) {
66
-        super(parent, "raw", title, title, parent.getConfigManager(), backBufferFactory,
66
+        super("raw", title, title, parent.getConfigManager(), backBufferFactory,
67
                 eventBus, Collections.singletonList(WindowComponent.TEXTAREA.getIdentifier()));
67
                 eventBus, Collections.singletonList(WindowComponent.TEXTAREA.getIdentifier()));
68
         this.logFile = logFile;
68
         this.logFile = logFile;
69
         this.numLines = numLines;
69
         this.numLines = numLines;

+ 1
- 1
parserdebug/src/com/dmdirc/addons/parserdebug/DebugWindow.java Parādīt failu

56
             final Connection connection,
56
             final Connection connection,
57
             final DMDircMBassador eventBus,
57
             final DMDircMBassador eventBus,
58
             final BackBufferFactory backBufferFactory) {
58
             final BackBufferFactory backBufferFactory) {
59
-        super(connection.getWindowModel(), "raw", "Parser Debug", title,
59
+        super("raw", "Parser Debug", title,
60
                 connection.getWindowModel().getConfigManager(), backBufferFactory,
60
                 connection.getWindowModel().getConfigManager(), backBufferFactory,
61
                 eventBus, Arrays.asList(WindowComponent.TEXTAREA.getIdentifier()));
61
                 eventBus, Arrays.asList(WindowComponent.TEXTAREA.getIdentifier()));
62
         this.listener = listener;
62
         this.listener = listener;

+ 1
- 1
redirect/src/com/dmdirc/addons/redirect/FakeWriteableFrameContainer.java Parādīt failu

46
             final WindowModel target,
46
             final WindowModel target,
47
             final DMDircMBassador eventBus,
47
             final DMDircMBassador eventBus,
48
             final BackBufferFactory backBufferFactory) {
48
             final BackBufferFactory backBufferFactory) {
49
-        super(target, target.getIcon(), target.getName(), target.getTitle(),
49
+        super(target.getIcon(), target.getName(), target.getTitle(),
50
                 target.getConfigManager(), backBufferFactory,
50
                 target.getConfigManager(), backBufferFactory,
51
                 target.getTabCompleter(), eventBus, Collections.<String>emptyList());
51
                 target.getTabCompleter(), eventBus, Collections.<String>emptyList());
52
         this.target = target;
52
         this.target = target;

Notiek ielāde…
Atcelt
Saglabāt