Move MainFrame initialisation out of constructor.

Change-Id: If84baaa21a34335cd41e9b06bf4c693889cdfd76
Reviewed-on: http://gerrit.dmdirc.com/3320
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

src/com/dmdirc/addons/ui_swing/MainFrame.java

@@ -120,7 +120,9 @@ public class MainFrame extends JFrame implements WindowListener,
     /** Main split pane. */
     private SplitPane mainSplitPane;
     /** Are we quitting or closing? */
-    private boolean quitting = false;
+    private boolean quitting;
+    /** Have we initialised our settings and listeners? */
+    private boolean initDone;
 
     /**
      * Creates new form MainFrame.
@@ -152,38 +154,45 @@ public class MainFrame extends JFrame implements WindowListener,
         this.iconManager = iconManager;
         this.frameManagerProvider = frameManagerProvider;
         this.eventBus = eventBus;
-
+        version = globalConfig.getOption("version", "version");
         focusOrder = new QueuedLinkedHashSet<>();
-        imageIcon = new ImageIcon(iconManager.getImage("icon"));
-        setIconImage(imageIcon.getImage());
+    }
 
-        CoreUIUtils.centreWindow(this);
+    @Override
+    public void setVisible(final boolean visible) {
+        if (!initDone) {
+            imageIcon = new ImageIcon(iconManager.getImage("icon"));
+            setIconImage(imageIcon.getImage());
 
-        addWindowListener(this);
+            CoreUIUtils.centreWindow(this);
 
-        showVersion = globalConfig.getOptionBool("ui", "showversion");
-        version = globalConfig.getOption("version", "version");
-        globalConfig.addChangeListener("ui", "showversion", this);
-        globalConfig.addChangeListener("ui", "framemanager", this);
-        globalConfig.addChangeListener("ui", "framemanagerPosition", this);
-        globalConfig.addChangeListener("icon", "icon", this);
+            addWindowListener(this);
 
-        addWindowFocusListener(new WindowFocusListener() {
+            showVersion = globalConfig.getOptionBool("ui", "showversion");
+            globalConfig.addChangeListener("ui", "showversion", this);
+            globalConfig.addChangeListener("ui", "framemanager", this);
+            globalConfig.addChangeListener("ui", "framemanagerPosition", this);
+            globalConfig.addChangeListener("icon", "icon", this);
 
-            @Override
-            public void windowGainedFocus(final WindowEvent e) {
-                eventBus.post(new ClientFocusGainedEvent());
-            }
+            addWindowFocusListener(new WindowFocusListener() {
 
-            @Override
-            public void windowLostFocus(final WindowEvent e) {
-                eventBus.post(new ClientFocusLostEvent());
-            }
-        });
+                @Override
+                public void windowGainedFocus(final WindowEvent e) {
+                    eventBus.post(new ClientFocusGainedEvent());
+                }
 
-        windowFactory.addWindowListener(this);
+                @Override
+                public void windowLostFocus(final WindowEvent e) {
+                    eventBus.post(new ClientFocusLostEvent());
+                }
+            });
 
-        setTitle(getTitlePrefix());
+            windowFactory.addWindowListener(this);
+
+            setTitle(getTitlePrefix());
+            initDone = true;
+        }
+        super.setVisible(visible);
     }
 
     public SwingStatusBar getStatusBar() {