Fixes issue 1361: GTK Issues on OpenSolaris

Change-Id: I74b21fade055a95afd2b4c6457fcebe825ad5318
Reviewed-on: http://gerrit.dmdirc.com/498
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Automatic-Compile: Shane Mc Cormack <shane@dmdirc.com>

src/com/dmdirc/addons/ui_swing/components/PackingTable.java

@@ -148,7 +148,7 @@ public class PackingTable extends JTable {
 
         final TableColumnModel myColumnModel = getTableHeader().getColumnModel();
         final int numCols = myColumnModel.getColumnCount();
-        final int totalSize = scrollPane.getViewportBorderBounds().width;
+        final int totalSize = (int) (scrollPane.getViewportBorderBounds().width * 0.99);
         final int[] widths = new int[numCols];
         int widthsTotal = 0;
 

src/com/dmdirc/addons/ui_swing/components/TreeScroller.java

@@ -57,8 +57,7 @@ public class TreeScroller implements MouseWheelListener {
         this.selectionModel = tree.getSelectionModel();
 
         rootVisible = tree.isRootVisible();
-        rootNode =
-                (DefaultMutableTreeNode) tree.getModel().getRoot();
+        rootNode = (DefaultMutableTreeNode) tree.getModel().getRoot();
 
         tree.addMouseWheelListener(this);
     }

src/com/dmdirc/addons/ui_swing/components/URLProtocolPanel.java

@@ -101,6 +101,7 @@ public class URLProtocolPanel extends JPanel implements ActionListener,
 
     /** Initialises the components. */
     private void initComponents() {
+        setOpaque(false);
         showFileChooser = new JButton("Browse");
         commandPath = new JTextField();
         optionType = new ButtonGroup();

src/com/dmdirc/addons/ui_swing/components/colours/ColourChooser.java

@@ -22,7 +22,6 @@
 
 package com.dmdirc.addons.ui_swing.components.colours;
 
-import com.dmdirc.addons.ui_swing.components.*;
 import com.dmdirc.ui.messages.ColourManager;
 import com.dmdirc.addons.ui_swing.UIUtilities;
 
@@ -36,6 +35,7 @@ import java.awt.event.ActionListener;
 import javax.swing.BorderFactory;
 import javax.swing.JButton;
 import javax.swing.JPanel;
+import javax.swing.UIManager;
 import javax.swing.event.EventListenerList;
 
 import net.miginfocom.swing.MigLayout;
@@ -64,7 +64,7 @@ public final class ColourChooser extends JPanel implements ActionListener {
     /** The value of this component. */
     private String value;
     /** Event listeners. */
-    private EventListenerList listeners;
+    private final EventListenerList listeners;
     /** Action command. */
     private String command;
     /** Parent window. */
@@ -131,6 +131,7 @@ public final class ColourChooser extends JPanel implements ActionListener {
         previewPanel = new JPanel();
         previewPanel.setPreferredSize(new Dimension(40, 10));
         previewPanel.setBorder(BorderFactory.createLineBorder(Color.DARK_GRAY));
+        setOpaque(false);
 
         setLayout(new MigLayout("ins 0, fill"));
 

src/com/dmdirc/addons/ui_swing/components/colours/OptionalColourChooser.java

@@ -22,7 +22,6 @@
 
 package com.dmdirc.addons.ui_swing.components.colours;
 
-import com.dmdirc.addons.ui_swing.components.colours.ColourPickerDialog;
 import com.dmdirc.ui.messages.ColourManager;
 import com.dmdirc.util.ListenerList;
 import com.dmdirc.addons.ui_swing.UIUtilities;
@@ -38,6 +37,7 @@ import javax.swing.BorderFactory;
 import javax.swing.JButton;
 import javax.swing.JCheckBox;
 import javax.swing.JPanel;
+import javax.swing.UIManager;
 
 import net.miginfocom.swing.MigLayout;
 
@@ -141,6 +141,8 @@ public final class OptionalColourChooser extends JPanel implements ActionListene
         enabled.setPreferredSize(new Dimension(40, 40));
         enabled.setSelected(initialState);
         enabled.addActionListener(this);
+        enabled.setOpaque(false);
+        setOpaque(false);
 
         setLayout(new MigLayout("fill, ins 0"));
 

src/com/dmdirc/addons/ui_swing/dialogs/actioneditor/ActionTriggersListPanel.java

@@ -51,7 +51,7 @@ public class ActionTriggersListPanel extends JPanel {
      */
     private static final long serialVersionUID = 1;
     /** Trigger list. */
-    private List<ActionType> triggers;
+    private final List<ActionType> triggers;
     /** Listeners. */
     private final ListenerList listeners = new ListenerList();
 
@@ -77,6 +77,7 @@ public class ActionTriggersListPanel extends JPanel {
 
     /** Initialises the components. */
     private void initComponents() {
+        setOpaque(false);
         setLayout(new MigLayout("fillx, wrap 2"));
     }
 

src/com/dmdirc/addons/ui_swing/dialogs/channelsetting/ChannelModesPane.java

@@ -25,17 +25,17 @@ package com.dmdirc.addons.ui_swing.dialogs.channelsetting;
 import com.dmdirc.Channel;
 import com.dmdirc.addons.ui_swing.components.ParamModePanel;
 import com.dmdirc.addons.ui_swing.UIUtilities;
-
 import com.dmdirc.parser.interfaces.Parser;
+
 import java.awt.Insets;
 import java.util.Hashtable;
 import java.util.Map;
-import javax.swing.BorderFactory;
 
+import javax.swing.BorderFactory;
 import javax.swing.JCheckBox;
 import javax.swing.JPanel;
-
 import javax.swing.UIManager;
+
 import net.miginfocom.swing.MigLayout;
 
 /** Non list mode panel. */
@@ -103,8 +103,6 @@ public final class ChannelModesPane extends JPanel {
             String text;
             String tooltip;
 
-            final boolean opaque = UIUtilities.getTabbedPaneOpaque();
-
             if (channel.getConfigManager().hasOptionString("server",
                     "mode" + mode)) {
                 text = channel.getConfigManager().
@@ -126,7 +124,7 @@ public final class ChannelModesPane extends JPanel {
             final JCheckBox checkBox = new JCheckBox(text, state);
             checkBox.setMargin(new Insets(0, 0, 0, 0));
             checkBox.setToolTipText(tooltip);
-            checkBox.setOpaque(opaque);
+            checkBox.setOpaque(false);
 
             modeCheckBoxes.put(mode, checkBox);
             if (!channel.getConfigManager().hasOptionString("server",

src/com/dmdirc/addons/ui_swing/dialogs/serversetting/UserModesPane.java

@@ -24,8 +24,8 @@ package com.dmdirc.addons.ui_swing.dialogs.serversetting;
 
 import com.dmdirc.Server;
 import com.dmdirc.addons.ui_swing.UIUtilities;
-
 import com.dmdirc.parser.interfaces.Parser;
+
 import java.awt.Insets;
 import java.util.Hashtable;
 import java.util.Map;
@@ -33,8 +33,8 @@ import java.util.Map;
 import javax.swing.BorderFactory;
 import javax.swing.JCheckBox;
 import javax.swing.JPanel;
-
 import javax.swing.UIManager;
+
 import net.miginfocom.swing.MigLayout;
 
 /** User mode panel. */
@@ -86,8 +86,6 @@ public final class UserModesPane extends JPanel {
         modeCheckBoxes =
                 new Hashtable<String, JCheckBox>();
 
-        final boolean opaque = UIUtilities.getTabbedPaneOpaque();
-
         // Lay out all the boolean mode checkboxes
         for (int i = 0; i < userModes.length();
                 i++) {
@@ -116,7 +114,7 @@ public final class UserModesPane extends JPanel {
             final JCheckBox checkBox = new JCheckBox(text, state);
             checkBox.setMargin(new Insets(0, 0, 0, 0));
             checkBox.setToolTipText(tooltip);
-            checkBox.setOpaque(opaque);
+            checkBox.setOpaque(false);
 
             modeCheckBoxes.put(mode, checkBox);
         }