Start making the NotificationManager more sane.

Add an interface for handlers, rework the manager to always use
the interface instead of doing dodgy exported stuff.

notifications/src/com/dmdirc/addons/notifications/LegacyNotificationHandler.java

@@ -0,0 +1,47 @@
+/*
+ * Copyright (c) 2006-2015 DMDirc Developers
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package com.dmdirc.addons.notifications;
+
+import com.dmdirc.plugins.ExportedService;
+import com.dmdirc.plugins.PluginInfo;
+
+/**
+ * A notification handler that works using exported services.
+ */
+public class LegacyNotificationHandler implements NotificationHandler {
+
+    private final PluginInfo pluginInfo;
+
+    public LegacyNotificationHandler(final PluginInfo pluginInfo) {
+        this.pluginInfo = pluginInfo;
+    }
+
+    @Override
+    public void showNotification(final String title, final String message) {
+        final ExportedService source = pluginInfo.getExportedService("showNotification");
+        if (source != null) {
+            source.execute(title, message);
+        }
+    }
+
+}

notifications/src/com/dmdirc/addons/notifications/NotificationCommand.java

@@ -30,12 +30,9 @@ import com.dmdirc.commandparser.commands.Command;
 import com.dmdirc.commandparser.commands.IntelligentCommand;
 import com.dmdirc.commandparser.commands.context.CommandContext;
 import com.dmdirc.interfaces.CommandController;
-import com.dmdirc.plugins.ExportedService;
-import com.dmdirc.plugins.PluginInfo;
 import com.dmdirc.ui.input.AdditionalTabTargets;
 
-import java.util.List;
-import java.util.stream.Collectors;
+import java.util.Collection;
 
 import javax.annotation.Nonnull;
 
@@ -78,22 +75,20 @@ public class NotificationCommand extends Command implements
                 "--method".equalsIgnoreCase(args.getArguments()[0])) {
             if (args.getArguments().length > 1) {
                 final String sourceName = args.getArguments()[1];
-                final ExportedService source = manager.getMethod(sourceName)
-                        .getExportedService("showNotification");
+                final NotificationHandler handler = manager.getHandler(sourceName);
 
-                if (source == null) {
+                if (handler == null) {
                     sendLine(origin, args.isSilent(), FORMAT_ERROR,
                             "Method not found.");
                 } else {
-                    source.execute("DMDirc", args.getArgumentsAsString(2));
+                    handler.showNotification("DMDirc", args.getArgumentsAsString(2));
                 }
             } else {
                 sendLine(origin, args.isSilent(), FORMAT_ERROR,
                         "You must specify a method when using --method.");
             }
-        } else if (manager.hasActiveMethod()) {
-            manager.getPreferredMethod().getExportedService("showNotification")
-                    .execute("DMDirc", args.getArgumentsAsString(0));
+        } else if (manager.hasActiveHandler()) {
+            manager.getPreferredHandler().showNotification("DMDirc", args.getArgumentsAsString(0));
         } else {
             sendLine(origin, args.isSilent(), FORMAT_ERROR,
                     "No active notification methods available.");
@@ -108,17 +103,17 @@ public class NotificationCommand extends Command implements
      */
     private void doMethodList(final FrameContainer origin,
             final boolean isSilent) {
-        final List<PluginInfo> methods = manager.getMethods();
+        final Collection<String> handlers = manager.getHandlerNames();
 
-        if (methods.isEmpty()) {
+        if (handlers.isEmpty()) {
             sendLine(origin, isSilent, FORMAT_ERROR, "No notification "
                     + "methods available.");
         } else {
             final String[] headers = {"Method"};
-            final String[][] data = new String[methods.size()][1];
+            final String[][] data = new String[handlers.size()][1];
             int i = 0;
-            for (PluginInfo method : methods) {
-                data[i][0] = method.getMetaData().getName();
+            for (String handler : handlers) {
+                data[i][0] = handler;
                 i++;
             }
 
@@ -136,9 +131,7 @@ public class NotificationCommand extends Command implements
             res.add("--method");
             return res;
         } else if (arg == 1 && "--method".equalsIgnoreCase(context.getPreviousArgs().get(0))) {
-            res.addAll(manager.getMethods().stream()
-                    .map(source -> source.getMetaData().getName())
-                    .collect(Collectors.toList()));
+            res.addAll(manager.getHandlerNames());
             return res;
         }
         return res;

notifications/src/com/dmdirc/addons/notifications/NotificationHandler.java

@@ -0,0 +1,38 @@
+/*
+ * Copyright (c) 2006-2015 DMDirc Developers
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package com.dmdirc.addons.notifications;
+
+/**
+ * Handler of notifications.
+ */
+public interface NotificationHandler {
+
+    /**
+     * Displays a notification to the user.
+     *
+     * @param title The title of the notification.
+     * @param message The notification content.
+     */
+    void showNotification(String title, String message);
+
+}

notifications/src/com/dmdirc/addons/notifications/NotificationsManager.java

@@ -38,7 +38,9 @@ import com.dmdirc.plugins.PluginManager;
 
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
 import javax.inject.Inject;
 
@@ -46,8 +48,8 @@ import net.engio.mbassy.listener.Handler;
 
 public class NotificationsManager {
 
-    /** The notification methods that we know of. */
-    private final Collection<String> methods = new ArrayList<>();
+    /** The notification handlers that we know of. */
+    private final Map<String, NotificationHandler> handlers = new HashMap<>();
     /** The user's preferred order for method usage. */
     private List<String> order;
     /** This plugin's settings domain. */
@@ -73,7 +75,7 @@ public class NotificationsManager {
     }
 
     public void onLoad() {
-        methods.clear();
+        handlers.clear();
         loadSettings();
         eventBus.subscribe(this);
         pluginManager.getPluginInfos().stream()
@@ -82,7 +84,7 @@ public class NotificationsManager {
     }
 
     public void onUnload() {
-        methods.clear();
+        handlers.clear();
         eventBus.unsubscribe(this);
     }
 
@@ -113,8 +115,8 @@ public class NotificationsManager {
      */
     private void addPlugin(final PluginInfo target) {
         if (target.hasExportedService("showNotification")) {
-            methods.add(target.getMetaData().getName());
-            addMethodToOrder(target);
+            handlers.put(target.getMetaData().getName(), new LegacyNotificationHandler(pluginInfo));
+            addHandlerToOrder(target);
         }
     }
 
@@ -124,7 +126,7 @@ public class NotificationsManager {
      *
      * @param source The notification method to be tested
      */
-    private void addMethodToOrder(final PluginInfo source) {
+    private void addHandlerToOrder(final PluginInfo source) {
         if (!order.contains(source.getMetaData().getName())) {
             order.add(source.getMetaData().getName());
         }
@@ -137,54 +139,50 @@ public class NotificationsManager {
      * @param target The plugin to be tested
      */
     private void removePlugin(final PluginInfo target) {
-        methods.remove(target.getMetaData().getName());
+        handlers.remove(target.getMetaData().getName());
     }
 
     /**
-     * Retrieves a method based on its name.
+     * Retrieves a handler based on its name.
      *
      * @param name The name to search for
      *
-     * @return The method with the specified name or null if none were found.
+     * @return The handler with the specified name or null if none were found.
      */
-    public PluginInfo getMethod(final String name) {
-        return pluginManager.getPluginInfoByName(name);
+    public NotificationHandler getHandler(final String name) {
+        return handlers.get(name);
     }
 
     /**
-     * Retrieves all the methods registered with this plugin.
+     * Retrieves the names of all the handlers registered with this plugin.
      *
-     * @return All known notification sources
+     * @return All known notification handler names
      */
-    public List<PluginInfo> getMethods() {
-        final List<PluginInfo> plugins = new ArrayList<>();
-        for (String method : methods) {
-            plugins.add(pluginManager.getPluginInfoByName(method));
-        }
-        return plugins;
+    public Collection<String> getHandlerNames() {
+        return handlers.keySet();
     }
 
     /**
-     * Does this plugin have any active notification methods?
+     * Does this plugin have any active notification handler?
      *
-     * @return true iif active notification methods are registered
+     * @return true iif active notification handlers are registered
      */
-    public boolean hasActiveMethod() {
-        return !methods.isEmpty();
+    public boolean hasActiveHandler() {
+        return !handlers.isEmpty();
     }
 
     /**
-     * Returns the user's preferred method if loaded, or null if none loaded.
+     * Returns the user's preferred handler if loaded, or null if none loaded.
      *
-     * @return Preferred notification method
+     * @return Preferred notification handler
      */
-    public PluginInfo getPreferredMethod() {
-        if (methods.isEmpty()) {
+    public NotificationHandler getPreferredHandler() {
+        if (handlers.isEmpty()) {
             return null;
         }
         for (String method : order) {
-            if (methods.contains(method)) {
-                return pluginManager.getPluginInfoByName(method);
+            if (handlers.containsKey(method)) {
+                return handlers.get(method);
             }
         }
         return null;