Browse Source

Remove UrlBuilder.buildUrl calls.

Change-Id: Ifac49c2ee45e8b518c33eb4491a80513fdd3e76f
Reviewed-on: http://gerrit.dmdirc.com/2836
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
tags/0.8
Chris Smith 10 years ago
parent
commit
37d3c18858

+ 4
- 0
src/com/dmdirc/addons/ui_swing/SwingController.java View File

@@ -190,6 +190,9 @@ public class SwingController extends BaseCommandPlugin implements UIController {
190 190
     /** The colour manager to use to parse colours. */
191 191
     @Getter
192 192
     private final ColourManager colourManager;
193
+    /** The URL builder to use. */
194
+    @Getter
195
+    private final URLBuilder urlBuilder;
193 196
 
194 197
     /**
195 198
      * Instantiates a new SwingController.
@@ -243,6 +246,7 @@ public class SwingController extends BaseCommandPlugin implements UIController {
243 246
         this.themeManager = themeManager;
244 247
         this.windowManager = windowManager;
245 248
         this.colourManager = colourManager;
249
+        this.urlBuilder = urlBuilder;
246 250
 
247 251
         globalConfig = identityManager.getGlobalConfiguration();
248 252
         globalIdentity = identityManager.getUserSettings();

+ 7
- 3
src/com/dmdirc/addons/ui_swing/components/addonbrowser/AddonInfo.java View File

@@ -93,9 +93,13 @@ public class AddonInfo {
93 93
     /**
94 94
      * Creates a new addon info class with the specified entries.
95 95
      *
96
+     * @param configManager The config provider to use to find settings.
97
+     * @param urlBuilder The URL builder to use to retrieve image URLs.
96 98
      * @param entry List of entries
97 99
      */
98
-    public AddonInfo(final AggregateConfigProvider configManager,
100
+    public AddonInfo(
101
+            final AggregateConfigProvider configManager,
102
+            final URLBuilder urlBuilder,
99 103
             final Map<String, String> entry) {
100 104
         id = Integer.parseInt(entry.get("id"));
101 105
         title = entry.get("title");
@@ -113,12 +117,12 @@ public class AddonInfo {
113 117
         verified = entry.get("verified").equals("yes");
114 118
         date = Integer.parseInt(entry.get("date"));
115 119
         if (entry.get("screenshot").equals("yes")) {
116
-            screenshot = new ImageIcon(URLBuilder.buildURL(
120
+            screenshot = new ImageIcon(urlBuilder.getUrl(
117 121
                     "http://addons.dmdirc.com/addonimg/" + id));
118 122
             screenshot.setImage(screenshot.getImage().
119 123
                     getScaledInstance(150, 150, Image.SCALE_SMOOTH));
120 124
         } else {
121
-            screenshot = new ImageIcon(URLBuilder.buildURL(
125
+            screenshot = new ImageIcon(urlBuilder.getUrl(
122 126
                     "dmdirc://com/dmdirc/res/logo.png"));
123 127
         }
124 128
         try {

+ 3
- 5
src/com/dmdirc/addons/ui_swing/components/addonbrowser/DataLoaderWorker.java View File

@@ -122,15 +122,13 @@ public class DataLoaderWorker
122 122
                 + File.separator + "addons.feed");
123 123
         try {
124 124
             data.read();
125
-        } catch (final IOException ex) {
126
-            return Collections.<AddonInfo>emptyList();
127
-        } catch (final InvalidConfigFileException ex) {
125
+        } catch (final IOException | InvalidConfigFileException ex) {
128 126
             return Collections.<AddonInfo>emptyList();
129 127
         }
130 128
 
131
-        final List<AddonInfo> list = new ArrayList<AddonInfo>();
129
+        final List<AddonInfo> list = new ArrayList<>();
132 130
         for (final Map<String, String> entry : data.getKeyDomains().values()) {
133
-            list.add(new AddonInfo(controller.getGlobalConfig(), entry));
131
+            list.add(new AddonInfo(controller.getGlobalConfig(), controller.getUrlBuilder(), entry));
134 132
         }
135 133
         return list;
136 134
     }

+ 12
- 1
src/com/dmdirc/addons/ui_swing/components/text/DMDircHTMLEditorKit.java View File

@@ -22,6 +22,8 @@
22 22
 
23 23
 package com.dmdirc.addons.ui_swing.components.text;
24 24
 
25
+import com.dmdirc.util.URLBuilder;
26
+
25 27
 import javax.swing.text.ViewFactory;
26 28
 import javax.swing.text.html.HTMLEditorKit;
27 29
 
@@ -31,7 +33,16 @@ import javax.swing.text.html.HTMLEditorKit;
31 33
 public class DMDircHTMLEditorKit extends HTMLEditorKit {
32 34
 
33 35
     private static final long serialVersionUID = 1;
34
-    private final ViewFactory defaultFactory = new DMDircHTMLFactory();
36
+    private final ViewFactory defaultFactory;
37
+
38
+    /**
39
+     * Creates a new instance of {@link DMDircHTMLEditorKit}.
40
+     *
41
+     * @param urlBuilder The URL builder to use to construct image URLs.
42
+     */
43
+    public DMDircHTMLEditorKit(final URLBuilder urlBuilder) {
44
+        defaultFactory = new DMDircHTMLFactory(urlBuilder);
45
+    }
35 46
 
36 47
     /** {@inheritDoc} */
37 48
     @Override

+ 9
- 1
src/com/dmdirc/addons/ui_swing/components/text/DMDircHTMLFactory.java View File

@@ -22,22 +22,30 @@
22 22
 
23 23
 package com.dmdirc.addons.ui_swing.components.text;
24 24
 
25
+import com.dmdirc.util.URLBuilder;
26
+
25 27
 import javax.swing.text.Element;
26 28
 import javax.swing.text.View;
27 29
 import javax.swing.text.html.HTMLEditorKit.HTMLFactory;
28 30
 import javax.swing.text.html.ImageView;
29 31
 
32
+import lombok.RequiredArgsConstructor;
33
+
30 34
 /**
31 35
  * DMDircHTML factory extends HTMLFactory to use DMDircImageView.
32 36
  */
37
+@RequiredArgsConstructor
33 38
 public class DMDircHTMLFactory extends HTMLFactory {
34 39
 
40
+    /** The URL builder to use to construct image URLs. */
41
+    private final URLBuilder urlBuilder;
42
+
35 43
     /** {@inheritDoc} */
36 44
     @Override
37 45
     public View create(final Element elem) {
38 46
         final View view = super.create(elem);
39 47
         if (view instanceof ImageView) {
40
-            return new DMDircImageView(elem);
48
+            return new DMDircImageView(urlBuilder, elem);
41 49
         }
42 50
         return view;
43 51
     }

+ 8
- 2
src/com/dmdirc/addons/ui_swing/components/text/DMDircImageView.java View File

@@ -35,13 +35,19 @@ import javax.swing.text.html.ImageView;
35 35
  */
36 36
 public class DMDircImageView extends ImageView {
37 37
 
38
+    /** The URL builder to use to construct image URLs. */
39
+    private final URLBuilder urlBuilder;
40
+
38 41
     /**
39 42
      * Creates a new DMDirc image view.
40 43
      *
41 44
      * @param elem element to view
45
+     * @param urlBuilder The URL builder to use to construct image URLs.
42 46
      */
43
-    public DMDircImageView(final Element elem) {
47
+    public DMDircImageView(final URLBuilder urlBuilder, final Element elem) {
44 48
         super(elem);
49
+
50
+        this.urlBuilder = urlBuilder;
45 51
     }
46 52
 
47 53
     /**
@@ -54,6 +60,6 @@ public class DMDircImageView extends ImageView {
54 60
         final String src = (String) getElement().getAttributes().
55 61
                 getAttribute(HTML.Attribute.SRC);
56 62
 
57
-        return src == null ? null : URLBuilder.buildURL(src);
63
+        return src == null ? null : urlBuilder.getUrl(src);
58 64
     }
59 65
 }

+ 3
- 1
src/com/dmdirc/addons/ui_swing/components/text/TextLabel.java View File

@@ -22,6 +22,8 @@
22 22
 
23 23
 package com.dmdirc.addons.ui_swing.components.text;
24 24
 
25
+import com.dmdirc.util.URLBuilder;
26
+
25 27
 import java.awt.Color;
26 28
 import java.awt.Font;
27 29
 import java.awt.Insets;
@@ -83,7 +85,7 @@ public class TextLabel extends JTextPane {
83 85
      */
84 86
     public TextLabel(final String text, final boolean justified) {
85 87
         super(new DefaultStyledDocument());
86
-        setEditorKit(new DMDircHTMLEditorKit());
88
+        setEditorKit(new DMDircHTMLEditorKit(URLBuilder.getInstance()));
87 89
         setUI(new BasicTextPaneUI());
88 90
 
89 91
         final StyleSheet styleSheet = ((HTMLDocument) getDocument()).

+ 8
- 2
src/com/dmdirc/addons/ui_swing/textpane/BackgroundPainter.java View File

@@ -76,6 +76,9 @@ public class BackgroundPainter extends LayerUI<JComponent> {
76 76
     @Getter(value = AccessLevel.PROTECTED)
77 77
     private final String optionKey;
78 78
 
79
+    /** The URL builder to use to find icons. */
80
+    private final URLBuilder urlBuilder;
81
+
79 82
     /**
80 83
      * Config manager to bind to and retrieve settings from.
81 84
      */
@@ -99,10 +102,13 @@ public class BackgroundPainter extends LayerUI<JComponent> {
99 102
      * @param imageKey Key for background image
100 103
      * @param optionKey Key for background type
101 104
      */
102
-    public BackgroundPainter(final AggregateConfigProvider configManager,
105
+    public BackgroundPainter(
106
+            final AggregateConfigProvider configManager,
107
+            final URLBuilder urlBuilder,
103 108
             final String domain, final String imageKey,
104 109
             final String optionKey) {
105 110
         this.configManager = configManager;
111
+        this.urlBuilder = urlBuilder;
106 112
         this.domain = domain;
107 113
         this.imageKey = imageKey;
108 114
         this.optionKey = optionKey;
@@ -119,7 +125,7 @@ public class BackgroundPainter extends LayerUI<JComponent> {
119 125
         if (value == null || value.isEmpty()) {
120 126
             backgroundImage = null;
121 127
         } else {
122
-            new ImageLoader(URLBuilder.buildURL(value)).executeInExecutor();
128
+            new ImageLoader(urlBuilder.getUrl(value)).executeInExecutor();
123 129
         }
124 130
     }
125 131
 

+ 2
- 2
src/com/dmdirc/addons/ui_swing/textpane/TextPane.java View File

@@ -102,8 +102,8 @@ public final class TextPane extends JComponent implements MouseWheelListener,
102 102
         newLineIndicator.setVisible(false);
103 103
 
104 104
         setLayout(new MigLayout("fill, hidemode 3"));
105
-        backgroundPainter = new BackgroundPainter(frame.getContainer()
106
-                .getConfigManager(), "plugin-ui_swing", "textpanebackground",
105
+        backgroundPainter = new BackgroundPainter(frame.getContainer().getConfigManager(),
106
+                controller.getUrlBuilder(), "plugin-ui_swing", "textpanebackground",
107 107
                 "textpanebackgroundoption");
108 108
         canvas = new TextPaneCanvas(this, document);
109 109
         final JXLayer<JComponent> layer = new JXLayer<JComponent>(canvas);

Loading…
Cancel
Save