Change non-regex uses of replaceAll to replace

Change-Id: I59d14c6df67668f0389c51b7ae475ce6cc9103f6
Reviewed-on: http://gerrit.dmdirc.com/705
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: Gregory Holmes <greg@dmdirc.com>

src/com/dmdirc/addons/freedesktop_notifications/FreeDesktopNotificationsPlugin.java

@@ -129,9 +129,9 @@ public final class FreeDesktopNotificationsPlugin extends Plugin implements
 	    if (strictescape) {
                 output = StringEscapeUtils.escapeHtml(output);
             } else {
-                output = output.replaceAll("&", "&");
-                output = output.replaceAll("<", "&lt;");
-                output = output.replaceAll(">", "&gt;");
+                output = output.replace("&", "&amp;");
+                output = output.replace("<", "&lt;");
+                output = output.replace(">", "&gt;");
             }
         }
         

src/com/dmdirc/addons/identd/IdentClient.java

@@ -186,7 +186,7 @@ public final class IdentClient implements Runnable {
      * @return Escaped string.
      */
     public static String escapeString(final String str) {
-        return str.replaceAll("\\\\", "\\\\\\\\").replaceAll(":", "\\\\:").replaceAll(",", "\\\\,").replaceAll(" ", "\\\\ ");
+        return str.replace("\\", "\\\\").replace(":", "\\:").replace(",", "\\,").replace(" ", "\\ ");
     }
 
     /**
@@ -196,7 +196,7 @@ public final class IdentClient implements Runnable {
      * @return Escaped string.
      */
     public static String unescapeString(final String str) {
-        return str.replaceAll("\\\\:", ":").replaceAll("\\\\ ", " ").replaceAll("\\\\,", ",").replaceAll("\\\\\\\\", "\\\\");
+        return str.replace("\\:", ":").replace("\\ ", " ").replace("\\,", ",").replace("\\\\", "\\");
     }
 
     /**

src/com/dmdirc/addons/nowplaying/NowPlayingPlugin.java

@@ -254,30 +254,29 @@ public class NowPlayingPlugin extends Plugin implements ActionListener  {
         final String time = source.getTime();
         final String state = source.getState().getNiceName();
         
-        return format.replaceAll("\\$artist", sanitise(artist))
-                     .replaceAll("\\$title", sanitise(title))
-                     .replaceAll("\\$album", sanitise(album))
-                     .replaceAll("\\$app", sanitise(app))
-                     .replaceAll("\\$bitrate", sanitise(bitrate))
-                     .replaceAll("\\$format", sanitise(filetype))
-                     .replaceAll("\\$length", sanitise(length))
-                     .replaceAll("\\$state", sanitise(state))
-                     .replaceAll("\\$time", sanitise(time));
+        return format.replace("$artist", sanitise(artist))
+                     .replace("$title", sanitise(title))
+                     .replace("$album", sanitise(album))
+                     .replace("$app", sanitise(app))
+                     .replace("$bitrate", sanitise(bitrate))
+                     .replace("$format", sanitise(filetype))
+                     .replace("$length", sanitise(length))
+                     .replace("$state", sanitise(state))
+                     .replace("$time", sanitise(time));
     }
 
     /**
      * Sanitises the specified String so that it may be used as the replacement
      * in a call to String.replaceAll. Namely, at present, this method returns
      * an empty String if it is passed a null value; otherwise the input is
-     * quoted for use as a replacement in the
-     * {@link String#replaceAll(java.lang.String, java.lang.String)} method.
+     * returned as-is.
      *
      * @param input The string to be sanitised
      * @return A sanitised version of the String
      * @since 0.6.3
      */
     protected static String sanitise(final String input) {
-        return input == null ? "" : Matcher.quoteReplacement(input);
+        return input == null ? "" : input;
     }
     
     /**

src/com/dmdirc/addons/ui_swing/components/NewlinesDocumentFilter.java

@@ -60,7 +60,7 @@ public class NewlinesDocumentFilter extends DocumentFilter {
      */
     private String sanitise(final String text) {
         if (text.contains("\n")) {
-            return text.replaceAll("\\n", "");
+            return text.replace("\n", "");
         }
         return text;
     }

src/com/dmdirc/addons/ui_swing/dialogs/about/LicenceLoader.java

@@ -85,7 +85,7 @@ public class LicenceLoader extends LoggingSwingWorker<Void, Void> {
                     final Licence licence = new Licence(licenceStringParts[1],
                             licenceStringParts[0], "<html><h1>" +
                             licenceStringParts[1] + "</h1><p>" + readInputStream(
-                            entry.getValue()).replaceAll("\n", "<br>") +
+                            entry.getValue()).replace("\n", "<br>") +
                             "</p></html>");
                     model.add(licence);
                 }

src/com/dmdirc/addons/ui_swing/dialogs/actioneditor/ActionConditionDisplayPanel.java

@@ -233,7 +233,7 @@ public class ActionConditionDisplayPanel extends JPanel implements ActionListene
             }
             sb.append(" '");
             if (condition.getTarget() != null) {
-                sb.append(condition.getTarget().replaceAll("<", "&lt;"));
+                sb.append(condition.getTarget().replace("<", "&lt;"));
             } else {
                 sb.append(" ...");
                 return sb.toString();

src/com/dmdirc/addons/ui_swing/dialogs/actioneditor/ActionResponsePanel.java

@@ -109,7 +109,7 @@ public class ActionResponsePanel extends JPanel {
     public void setResponse(final String[] response) {
         final StringBuilder sb = new StringBuilder();
         for (String responseLine : response) {
-            responseLine = responseLine.replaceAll("\n", "\\\\n");
+            responseLine = responseLine.replace("\n", "\\n");
             sb.append(responseLine).append('\n');
         }
 
@@ -143,7 +143,7 @@ public class ActionResponsePanel extends JPanel {
     public String[] getResponse() {
         final String[] text = response.getText().split("\n");
         for (int i = 0; i < text.length; i++) {
-            text[i] = text[i].replaceAll("\\\\n", "\n");
+            text[i] = text[i].replace("\\n", "\n");
         }
         return text;
     }