Fix prefs category loading.

When loading a category, don't also create UI for the subcategories.
This is weird and doesn't make sense, and is also the reason we
needed the hacky NoRemovePanel.

Previously, we added a category, then created a new panel for
each of its subcategories. When you clicked on the subcat
we made it again with a new panel, and the component ended
up on both (because it couldn't be removed from the old one).

ui_swing/src/com/dmdirc/addons/ui_swing/dialogs/prefs/NoRemovePanel.java

@@ -1,52 +0,0 @@
-/*
- * Copyright (c) 2006-2015 DMDirc Developers
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- */
-
-package com.dmdirc.addons.ui_swing.dialogs.prefs;
-
-import java.awt.Component;
-import java.awt.LayoutManager;
-
-import javax.swing.JPanel;
-
-/**
- * Creates a new JPanel that prevents components from being removed.
- */
-public class NoRemovePanel extends JPanel {
-
-    /** A version number for this class. */
-    private static final long serialVersionUID = 1;
-
-    /**
-     * Creates a new JPanel that prevents components being removed.
-     *
-     * @param layout Layout manager
-     */
-    public NoRemovePanel(final LayoutManager layout) {
-        super(layout);
-    }
-
-    @Override
-    public void remove(final Component comp) {
-        //Ignore
-    }
-
-}

ui_swing/src/com/dmdirc/addons/ui_swing/dialogs/prefs/PrefsCategoryLoader.java

@@ -141,8 +141,6 @@ public class PrefsCategoryLoader extends LoggingSwingWorker<JPanel, Object> {
         for (PreferencesCategory child : category.getSubcats()) {
             if (child.isInline() && category.isInlineBefore()) {
                 addInlineCategory(child, panel);
-            } else if (!child.isInline()) {
-                addCategory(child);
             }
         }
 
@@ -234,7 +232,7 @@ public class PrefsCategoryLoader extends LoggingSwingWorker<JPanel, Object> {
     private void addInlineCategory(final PreferencesCategory category,
             final JPanel parent) {
         final JPanel panel = UIUtilities.invokeAndWait(() -> {
-            final JPanel panel1 = new NoRemovePanel(new MigLayout(
+            final JPanel panel1 = new JPanel(new MigLayout(
                             "fillx, gap unrel, wrap 2, "
                             + "hidemode 3, pack, wmax 470-" + leftPadding + '-'
                             + rightPadding + "-2*"
@@ -258,7 +256,7 @@ public class PrefsCategoryLoader extends LoggingSwingWorker<JPanel, Object> {
      */
     private JPanel addCategory(final PreferencesCategory category) {
         final JPanel panel = UIUtilities.invokeAndWait(() -> {
-            final JPanel panel1 = new NoRemovePanel(
+            final JPanel panel1 = new JPanel(
                     new MigLayout("fillx, gap unrel, wrap 2, pack, "
                             + "hidemode 3, wmax 470-"
                             + leftPadding + '-' + rightPadding + "-2*" + padding));