Browse Source

Unit test updates

Fixes issue 3168
Fixes issue 3347

Change-Id: I7722fe396e58f37cc60d10f54bb3a68ab63dbe7b
Reviewed-on: http://gerrit.dmdirc.com/358
Reviewed-by: Gregory Holmes <greboid@dmdirc.com>
Tested-by: Gregory Holmes <greboid@dmdirc.com>
tags/0.6.3
Chris Smith 14 years ago
parent
commit
1b74cec696

BIN
lib/mockito-all-1.6.jar View File


+ 29
- 11
test/com/dmdirc/addons/logging/LoggingPluginTest.java View File

29
 import com.dmdirc.actions.CoreActionType;
29
 import com.dmdirc.actions.CoreActionType;
30
 import com.dmdirc.config.IdentityManager;
30
 import com.dmdirc.config.IdentityManager;
31
 import com.dmdirc.harness.TestLoggingPlugin;
31
 import com.dmdirc.harness.TestLoggingPlugin;
32
-import com.dmdirc.parser.irc.IRCChannelInfo;
33
 import com.dmdirc.addons.ui_dummy.DummyController;
32
 import com.dmdirc.addons.ui_dummy.DummyController;
34
-import com.dmdirc.parser.irc.IRCParser;
33
+import com.dmdirc.parser.interfaces.ChannelInfo;
34
+import com.dmdirc.parser.interfaces.ClientInfo;
35
+import com.dmdirc.parser.interfaces.Parser;
35
 import com.dmdirc.util.ConfigFile;
36
 import com.dmdirc.util.ConfigFile;
36
 
37
 
37
-import java.net.URI;
38
 import java.util.Map;
38
 import java.util.Map;
39
 
39
 
40
+import static org.mockito.Mockito.*;
41
+
40
 import org.junit.BeforeClass;
42
 import org.junit.BeforeClass;
41
 import org.junit.Test;
43
 import org.junit.Test;
42
 import static org.junit.Assert.*;
44
 import static org.junit.Assert.*;
52
     public static void setUp() throws Exception {
54
     public static void setUp() throws Exception {
53
         Main.setUI(new DummyController());
55
         Main.setUI(new DummyController());
54
         IdentityManager.load();
56
         IdentityManager.load();
55
-        server = new Server(new URI("irc-test://255.255.255.255"),
56
-                IdentityManager.getProfiles().get(0));
57
-        server.connect();
57
+
58
+
59
+        ClientInfo clientinfo = mock(ClientInfo.class);
60
+        when(clientinfo.toString()).thenReturn("foo!bar@baz");
61
+        
62
+        Parser parser = mock(Parser.class);
63
+        when(parser.getClient(anyString())).thenReturn(clientinfo);
64
+
65
+        server = mock(Server.class);
66
+        when(server.toString()).thenReturn("server");
67
+        when(server.getParser()).thenReturn(parser);
58
         
68
         
59
-        channel = new Channel(server, new IRCChannelInfo((IRCParser) server.getParser(), "#test"));
60
-        query = new Query(server, "foo!bar@baz");
69
+        ChannelInfo info = mock(ChannelInfo.class);
70
+        when(info.toString()).thenReturn("#test");
71
+
72
+        channel = mock(Channel.class);
73
+        when(channel.getServer()).thenReturn(server);
74
+        when(channel.getChannelInfo()).thenReturn(info);
75
+        query = mock(Query.class);
76
+        when(query.getServer()).thenReturn(server);
77
+        when(query.toString()).thenReturn("query");
78
+        when(query.getHost()).thenReturn("foo!bar@baz");
61
 
79
 
62
-        final ConfigFile file = new ConfigFile(LoggingPlugin.class
63
-                .getResourceAsStream("plugin.config"));
80
+        final ConfigFile file = new ConfigFile(LoggingPlugin
81
+                .class.getResourceAsStream("plugin.config"));
64
         file.read();
82
         file.read();
65
 
83
 
66
         for (Map.Entry<String, String> entry : file.getKeyDomain("defaults").entrySet()) {
84
         for (Map.Entry<String, String> entry : file.getKeyDomain("defaults").entrySet()) {
101
     public void testQueryOpened() {
119
     public void testQueryOpened() {
102
         lp.processEvent(CoreActionType.QUERY_OPENED, new StringBuffer(),
120
         lp.processEvent(CoreActionType.QUERY_OPENED, new StringBuffer(),
103
                 query);
121
                 query);
104
-        
122
+
105
         assertTrue(lp.lines.containsKey("foo!bar@baz"));
123
         assertTrue(lp.lines.containsKey("foo!bar@baz"));
106
         assertEquals(3, lp.lines.get("foo!bar@baz").size());
124
         assertEquals(3, lp.lines.get("foo!bar@baz").size());
107
         assertTrue(lp.lines.get("foo!bar@baz").get(2).isEmpty());
125
         assertTrue(lp.lines.get("foo!bar@baz").get(2).isEmpty());

+ 2
- 7
test/com/dmdirc/addons/ui_swing/MainFrameTest.java View File

25
 import com.dmdirc.Main;
25
 import com.dmdirc.Main;
26
 import com.dmdirc.config.IdentityManager;
26
 import com.dmdirc.config.IdentityManager;
27
 import com.dmdirc.config.InvalidIdentityFileException;
27
 import com.dmdirc.config.InvalidIdentityFileException;
28
-import com.dmdirc.harness.ui.UIClassTestRunner;
29
-import com.dmdirc.harness.ui.UITestIface;
30
-
31
 import com.dmdirc.addons.ui_swing.dialogs.FeedbackDialog;
28
 import com.dmdirc.addons.ui_swing.dialogs.FeedbackDialog;
32
 import com.dmdirc.addons.ui_swing.dialogs.NewServerDialog;
29
 import com.dmdirc.addons.ui_swing.dialogs.NewServerDialog;
33
 import com.dmdirc.addons.ui_swing.dialogs.about.AboutDialog;
30
 import com.dmdirc.addons.ui_swing.dialogs.about.AboutDialog;
44
 import org.junit.Before;
41
 import org.junit.Before;
45
 import org.junit.BeforeClass;
42
 import org.junit.BeforeClass;
46
 import org.junit.Test;
43
 import org.junit.Test;
47
-import org.junit.runner.RunWith;
48
 
44
 
49
-@RunWith(UIClassTestRunner.class)
50
-public class MainFrameTest implements UITestIface {
45
+public class MainFrameTest {
51
     
46
     
52
     private static FrameFixture window;
47
     private static FrameFixture window;
53
     private DialogFixture newwin;
48
     private DialogFixture newwin;
137
         window.menuItemWithPath("Server", "Server settings").requireDisabled();
132
         window.menuItemWithPath("Server", "Server settings").requireDisabled();
138
     }
133
     }
139
 
134
 
140
-    @Override @After
135
+    @After
141
     public void tearDown() throws InterruptedException, InvocationTargetException {
136
     public void tearDown() throws InterruptedException, InvocationTargetException {
142
         SwingUtilities.invokeAndWait(new Runnable() {
137
         SwingUtilities.invokeAndWait(new Runnable() {
143
             @Override
138
             @Override

+ 2
- 7
test/com/dmdirc/addons/ui_swing/components/frames/InputTextFrameTest.java View File

22
 
22
 
23
 package com.dmdirc.addons.ui_swing.components.frames;
23
 package com.dmdirc.addons.ui_swing.components.frames;
24
 
24
 
25
-import com.dmdirc.addons.ui_swing.components.*;
26
 import com.dmdirc.Main;
25
 import com.dmdirc.Main;
27
 import com.dmdirc.commandparser.parsers.GlobalCommandParser;
26
 import com.dmdirc.commandparser.parsers.GlobalCommandParser;
28
 import com.dmdirc.config.ConfigManager;
27
 import com.dmdirc.config.ConfigManager;
31
 import com.dmdirc.harness.TestConfigManagerMap;
30
 import com.dmdirc.harness.TestConfigManagerMap;
32
 import com.dmdirc.harness.TestWritableFrameContainer;
31
 import com.dmdirc.harness.TestWritableFrameContainer;
33
 import com.dmdirc.harness.ui.ClassFinder;
32
 import com.dmdirc.harness.ui.ClassFinder;
34
-import com.dmdirc.harness.ui.UIClassTestRunner;
35
-import com.dmdirc.harness.ui.UITestIface;
36
 import com.dmdirc.ui.WindowManager;
33
 import com.dmdirc.ui.WindowManager;
37
 import com.dmdirc.addons.ui_swing.SwingController;
34
 import com.dmdirc.addons.ui_swing.SwingController;
38
 import com.dmdirc.addons.ui_swing.UIUtilities;
35
 import com.dmdirc.addons.ui_swing.UIUtilities;
36
+import com.dmdirc.addons.ui_swing.components.TextAreaInputField;
39
 import com.dmdirc.plugins.PluginManager;
37
 import com.dmdirc.plugins.PluginManager;
40
 
38
 
41
 import java.awt.event.KeyEvent;
39
 import java.awt.event.KeyEvent;
52
 import org.junit.BeforeClass;
50
 import org.junit.BeforeClass;
53
 import org.junit.Ignore;
51
 import org.junit.Ignore;
54
 import org.junit.Test;
52
 import org.junit.Test;
55
-import org.junit.runner.RunWith;
56
 
53
 
57
-
58
-@RunWith(UIClassTestRunner.class)
59
-public class InputTextFrameTest implements UITestIface {
54
+public class InputTextFrameTest {
60
 
55
 
61
     static FrameFixture mainframe;
56
     static FrameFixture mainframe;
62
     static JInternalFrameFixture window;
57
     static JInternalFrameFixture window;

+ 3
- 11
test/com/dmdirc/addons/ui_swing/dialogs/actioneditor/ActionEditorDialogTest.java View File

28
 import com.dmdirc.addons.ui_swing.SwingController;
28
 import com.dmdirc.addons.ui_swing.SwingController;
29
 import com.dmdirc.config.IdentityManager;
29
 import com.dmdirc.config.IdentityManager;
30
 import com.dmdirc.config.InvalidIdentityFileException;
30
 import com.dmdirc.config.InvalidIdentityFileException;
31
-import com.dmdirc.harness.ui.UIClassTestRunner;
32
 import com.dmdirc.harness.ui.ClassFinder;
31
 import com.dmdirc.harness.ui.ClassFinder;
33
-import com.dmdirc.harness.ui.UITestIface;
34
 import com.dmdirc.harness.ui.JRadioButtonByTextMatcher;
32
 import com.dmdirc.harness.ui.JRadioButtonByTextMatcher;
35
-
36
 import com.dmdirc.addons.ui_swing.components.ImageButton;
33
 import com.dmdirc.addons.ui_swing.components.ImageButton;
37
 import com.dmdirc.addons.ui_swing.components.text.TextLabel;
34
 import com.dmdirc.addons.ui_swing.components.text.TextLabel;
38
-import com.dmdirc.logger.ErrorLevel;
39
-import com.dmdirc.logger.Logger;
40
-import java.awt.Component;
41
 
35
 
36
+import java.awt.Component;
42
 import java.util.regex.Matcher;
37
 import java.util.regex.Matcher;
43
 import java.util.regex.Pattern;
38
 import java.util.regex.Pattern;
39
+
44
 import javax.swing.JButton;
40
 import javax.swing.JButton;
45
 import javax.swing.JPanel;
41
 import javax.swing.JPanel;
46
 import javax.swing.JTextField;
42
 import javax.swing.JTextField;
56
 import org.junit.Before;
52
 import org.junit.Before;
57
 import org.junit.BeforeClass;
53
 import org.junit.BeforeClass;
58
 import org.junit.Test;
54
 import org.junit.Test;
59
-import org.junit.runner.RunWith;
60
 import static org.junit.Assert.*;
55
 import static org.junit.Assert.*;
61
 
56
 
62
-@RunWith(UIClassTestRunner.class)
63
-public class ActionEditorDialogTest implements UITestIface {
57
+public class ActionEditorDialogTest {
64
 
58
 
65
     private DialogFixture window;
59
     private DialogFixture window;
66
 
60
 
70
     }
64
     }
71
 
65
 
72
     @Before
66
     @Before
73
-    @Override
74
     public void setUp() throws InvalidIdentityFileException {
67
     public void setUp() throws InvalidIdentityFileException {
75
         IdentityManager.load();
68
         IdentityManager.load();
76
         ActionManager.init();
69
         ActionManager.init();
81
     }
74
     }
82
 
75
 
83
     @After
76
     @After
84
-    @Override
85
     public void tearDown() {
77
     public void tearDown() {
86
         if (window != null) {
78
         if (window != null) {
87
             window.cleanUp();
79
             window.cleanUp();

+ 3
- 6
test/com/dmdirc/addons/ui_swing/dialogs/actionsmanager/ActionsManagerDialogTest.java View File

27
 import com.dmdirc.addons.ui_swing.SwingController;
27
 import com.dmdirc.addons.ui_swing.SwingController;
28
 import com.dmdirc.config.IdentityManager;
28
 import com.dmdirc.config.IdentityManager;
29
 import com.dmdirc.config.InvalidIdentityFileException;
29
 import com.dmdirc.config.InvalidIdentityFileException;
30
-import com.dmdirc.harness.ui.UIClassTestRunner;
31
 import com.dmdirc.harness.ui.ClassFinder;
30
 import com.dmdirc.harness.ui.ClassFinder;
32
-import com.dmdirc.harness.ui.UITestIface;
33
-
34
 import com.dmdirc.addons.ui_swing.dialogs.StandardInputDialog;
31
 import com.dmdirc.addons.ui_swing.dialogs.StandardInputDialog;
35
 import com.dmdirc.addons.ui_swing.dialogs.actioneditor.ActionEditorDialog;
32
 import com.dmdirc.addons.ui_swing.dialogs.actioneditor.ActionEditorDialog;
33
+
36
 import java.lang.reflect.InvocationTargetException;
34
 import java.lang.reflect.InvocationTargetException;
35
+
37
 import javax.swing.JPanel;
36
 import javax.swing.JPanel;
38
 import javax.swing.SwingUtilities;
37
 import javax.swing.SwingUtilities;
39
 import javax.swing.text.JTextComponent;
38
 import javax.swing.text.JTextComponent;
48
 import org.junit.Before;
47
 import org.junit.Before;
49
 import org.junit.BeforeClass;
48
 import org.junit.BeforeClass;
50
 import org.junit.Test;
49
 import org.junit.Test;
51
-import org.junit.runner.RunWith;
52
 import static org.junit.Assert.*;
50
 import static org.junit.Assert.*;
53
 
51
 
54
-@RunWith(UIClassTestRunner.class)
55
-public class ActionsManagerDialogTest implements UITestIface {
52
+public class ActionsManagerDialogTest {
56
     
53
     
57
     private DialogFixture window;
54
     private DialogFixture window;
58
 
55
 

+ 1
- 6
test/com/dmdirc/addons/ui_swing/dialogs/profiles/ProfileManagerDialogTest.java View File

29
 import com.dmdirc.config.prefs.validator.FileNameValidator;
29
 import com.dmdirc.config.prefs.validator.FileNameValidator;
30
 import com.dmdirc.config.prefs.validator.IdentValidator;
30
 import com.dmdirc.config.prefs.validator.IdentValidator;
31
 import com.dmdirc.config.prefs.validator.NotEmptyValidator;
31
 import com.dmdirc.config.prefs.validator.NotEmptyValidator;
32
-import com.dmdirc.harness.ui.UIClassTestRunner;
33
-import com.dmdirc.harness.ui.UITestIface;
34
 import com.dmdirc.harness.ui.ClassFinder;
32
 import com.dmdirc.harness.ui.ClassFinder;
35
 import com.dmdirc.harness.ui.ValidatingJTextFieldFinder;
33
 import com.dmdirc.harness.ui.ValidatingJTextFieldFinder;
36
 
34
 
37
 import javax.swing.JList;
35
 import javax.swing.JList;
38
 
36
 
39
-import javax.swing.JPanel;
40
 import org.fest.swing.core.EventMode;
37
 import org.fest.swing.core.EventMode;
41
 import org.fest.swing.fixture.DialogFixture;
38
 import org.fest.swing.fixture.DialogFixture;
42
 
39
 
44
 import org.junit.Before;
41
 import org.junit.Before;
45
 import org.junit.BeforeClass;
42
 import org.junit.BeforeClass;
46
 import org.junit.Test;
43
 import org.junit.Test;
47
-import org.junit.runner.RunWith;
48
 import static org.junit.Assert.*;
44
 import static org.junit.Assert.*;
49
 
45
 
50
-@RunWith(UIClassTestRunner.class)
51
-public class ProfileManagerDialogTest implements UITestIface {
46
+public class ProfileManagerDialogTest {
52
 
47
 
53
     private DialogFixture window;
48
     private DialogFixture window;
54
     private Profile profile;
49
     private Profile profile;

+ 1
- 5
test/com/dmdirc/addons/ui_swing/dialogs/sslcertificate/SSLCertificateDialogTest.java View File

26
 import com.dmdirc.addons.ui_swing.SwingController;
26
 import com.dmdirc.addons.ui_swing.SwingController;
27
 import com.dmdirc.harness.ui.ClassFinder;
27
 import com.dmdirc.harness.ui.ClassFinder;
28
 import com.dmdirc.harness.ui.TestSSLCertificateDialogModel;
28
 import com.dmdirc.harness.ui.TestSSLCertificateDialogModel;
29
-import com.dmdirc.harness.ui.UIClassTestRunner;
30
-import com.dmdirc.harness.ui.UITestIface;
31
 import com.dmdirc.ui.IconManager;
29
 import com.dmdirc.ui.IconManager;
32
 import com.dmdirc.addons.ui_swing.UIUtilities;
30
 import com.dmdirc.addons.ui_swing.UIUtilities;
33
 
31
 
48
 import org.junit.Before;
46
 import org.junit.Before;
49
 import org.junit.BeforeClass;
47
 import org.junit.BeforeClass;
50
 import org.junit.Test;
48
 import org.junit.Test;
51
-import org.junit.runner.RunWith;
52
 import static org.junit.Assert.*;
49
 import static org.junit.Assert.*;
53
 
50
 
54
-@RunWith(UIClassTestRunner.class)
55
-public class SSLCertificateDialogTest implements UITestIface {
51
+public class SSLCertificateDialogTest {
56
 
52
 
57
     private DialogFixture window;
53
     private DialogFixture window;
58
 
54
 

Loading…
Cancel
Save