Browse Source

Tidy up.

pull/102/head
Greg Holmes 9 years ago
parent
commit
17d7743f8d

+ 1
- 1
dcc/src/com/dmdirc/addons/dcc/DCCFrameContainer.java View File

@@ -89,7 +89,7 @@ public abstract class DCCFrameContainer extends FrameContainer {
89 89
     }
90 90
 
91 91
     @Override
92
-    public Optional<Connection> getOptionalConnection() { //NOPMD - server will always be null
92
+    public Optional<Connection> getOptionalConnection() {
93 93
         return Optional.empty();
94 94
     }
95 95
 

+ 2
- 4
logging/src/com/dmdirc/addons/logging/HistoryWindow.java View File

@@ -77,14 +77,12 @@ public class HistoryWindow extends FrameContainer {
77 77
 
78 78
     @Override
79 79
     public Connection getConnection() {
80
-        final Optional<FrameContainer> parent = getParent();
81
-        return parent.isPresent() ? parent.get().getConnection() : null;
80
+        return getParent().map(FrameContainer::getConnection).orElse(null);
82 81
     }
83 82
 
84 83
     @Override
85 84
     public Optional<Connection> getOptionalConnection() {
86
-        final Optional<FrameContainer> parent = getParent();
87
-        return Optional.ofNullable(parent.isPresent() ? parent.get().getConnection() : null);
85
+        return getParent().map(FrameContainer::getConnection);
88 86
     }
89 87
 
90 88
 }

+ 1
- 1
redirect/src/com/dmdirc/addons/redirect/FakeWriteableFrameContainer.java View File

@@ -110,7 +110,7 @@ public class FakeWriteableFrameContainer extends FrameContainer {
110 110
 
111 111
     @Override
112 112
     public Optional<Connection> getOptionalConnection() {
113
-        return Optional.of(target.getConnection());
113
+        return target.getOptionalConnection();
114 114
     }
115 115
 
116 116
 }

Loading…
Cancel
Save