Fix pointless array creation.

Change-Id: I7e4e6e86c02dce066eb4a739259bbeef9df8620e
Reviewed-on: http://gerrit.dmdirc.com/3879
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

nowplaying/src/com/dmdirc/addons/nowplaying/ConfigPanel.java

@@ -145,9 +145,8 @@ public class ConfigPanel extends JPanel implements PreferencesInterface, KeyList
 
         previewPanel = panel;
 
-        add(new NowPlayingSubsitutionPanel(Arrays.asList(new String[]{"app",
-            "title", "artist", "album", "bitrate", "format", "length",
-            "time", "state"})), "growx");
+        add(new NowPlayingSubsitutionPanel(Arrays.asList("app", "title", "artist", "album",
+                "bitrate", "format", "length", "time", "state")), "growx");
         schedulePreviewUpdate();
     }
 

nowplaying/src/com/dmdirc/addons/nowplaying/NowPlayingCommand.java

@@ -175,10 +175,8 @@ public class NowPlayingCommand extends Command implements IntelligentCommand {
     public AdditionalTabTargets getSuggestions(final int arg,
             final IntelligentCommandContext context) {
 
-        final List<String> subsList = Arrays.asList(new String[]{
-            "$artist", "$title", "$album", "$app", "$bitrate", "$format",
-            "$length", "$state", "$time"
-        });
+        final List<String> subsList = Arrays.asList("$artist", "$title", "$album", "$app",
+                "$bitrate", "$format", "$length", "$state", "$time");
 
         if (arg == 0) {
             final AdditionalTabTargets res = TabCompleterUtils.

parser_xmpp/src/com/dmdirc/addons/parser_xmpp/XmppParser.java

@@ -124,7 +124,7 @@ public class XmppParser extends BaseSocketAwareParser {
 
         LOG.debug(
                 "XMPP parser created with query string {}, parsed fake channel = {}, priority = {}",
-                new Object[]{address.getQuery(), useFakeChannel, priority});
+                address.getQuery(), useFakeChannel, priority);
     }
 
     @Override

serverlists/src/com/dmdirc/addons/serverlists/service/ServerListServiceProvider.java

@@ -67,9 +67,7 @@ public class ServerListServiceProvider implements ServiceProvider {
         this.serverList = serverList;
         this.pluginManager = pluginManager;
         this.eventBus = eventBus;
-        this.services = Arrays.asList(new Service[]{
-            pluginManager.getService("parser", "serverlist", true)
-        });
+        this.services = Arrays.asList(pluginManager.getService("parser", "serverlist", true));
     }
 
     /**

ui_swing/src/com/dmdirc/addons/ui_swing/Apple.java

@@ -309,7 +309,7 @@ public class Apple implements InvocationHandler {
                     new Class<?>[]{listenerClass}, this);
 
             final Method method = getApplication().getClass().getMethod(handlerMethod,
-                    new Class<?>[]{listenerClass});
+                    listenerClass);
             method.invoke(getApplication(), listener);
 
             return true;

ui_swing/src/com/dmdirc/addons/ui_swing/components/URLProtocolPanel.java

@@ -129,12 +129,8 @@ public class URLProtocolPanel extends JPanel implements ActionListener,
         optionType.add(mail);
         optionType.add(custom);
 
-        subsPanel = new URLSubstitutionsPanel(Arrays.asList(new String[]{
-            "url",
-            "fragment", "host", "path", "port", "query", "protocol",
-            "username",
-            "password"
-        }));
+        subsPanel = new URLSubstitutionsPanel(Arrays.asList("url", "fragment", "host", "path",
+                "port", "query", "protocol", "username", "password"));
         subsPanel.setVisible(custom.isSelected());
 
         updateSelection();