Fixes issue 3427: new window menu code doesn't use menu scrollers

Fixes issue 3419: Unable to execute thread. — addons.ui_swing.framemanager.windowmenu.WindowMenuScroller.<init>(WindowMenuScroller.java:59)

Change-Id: I93190266e54bcc4770554a73bb42ab8b71c5fbf1
Reviewed-on: http://gerrit.dmdirc.com/296
Tested-by: Gregory Holmes <greboid@dmdirc.com>
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>

src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenu.java

@@ -24,6 +24,7 @@
 package com.dmdirc.addons.ui_swing.framemanager.windowmenu;
 
 import com.dmdirc.FrameContainer;
+import com.dmdirc.addons.ui_swing.SwingController;
 import com.dmdirc.interfaces.FrameInfoListener;
 import com.dmdirc.interfaces.SelectionListener;
 import com.dmdirc.ui.IconManager;
@@ -55,10 +56,13 @@ public class FrameContainerMenu extends JMenu implements FrameInfoListener,
      * Instantiates a new FrameContainer menu item wrapping the specified frame.
      *
      * @param frame Wrapped frame
+     * @param controller Controller
      */
-    public FrameContainerMenu(final FrameContainer frame) {
+    public FrameContainerMenu(final FrameContainer frame,
+            final SwingController controller) {
         super(frame.toString());
         setIcon(IconManager.getIconManager().getIcon(frame.getIcon()));
+        new WindowMenuScroller(this, controller.getDomain(), 0);
 
         this.frame = frame;
 

src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/WindowMenuFrameManager.java

@@ -171,7 +171,7 @@ public final class WindowMenuFrameManager extends JMenu implements
         JMenu parentMenu;
         if (!menus.containsKey(parent)) {
             final FrameContainerMenu replacement =
-                    new FrameContainerMenu(parent);
+                    new FrameContainerMenu(parent, controller);
             replaceItemWithMenu(getParentMenu(parent), items.get(parent),
                     replacement);
             parentMenu = replacement;

src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/WindowMenuScroller.java

@@ -53,6 +53,9 @@ public class WindowMenuScroller implements ConfigChangeListener {
      */
     public WindowMenuScroller(final JMenu menu, final String configDomain,
             final int fixedCount) {
+        if (IdentityManager.getGlobalConfig() == null) {
+            throw new IllegalArgumentException("null global config");
+        }
         this.menu = menu;
         this.configDomain = configDomain;
         this.fixedCount = fixedCount;

src/com/dmdirc/addons/ui_swing/plugin.config

@@ -28,7 +28,7 @@ provides:
 
 defaults:
     debugEDT=false
-    windowMenuItems=20
+    windowMenuItems=30
     windowMenuScrollInterval=250
     showtopicbar=true
     shownicklist=true