getURI() now always returns a valid URI. Fixes issue 3209
setURI() now actually sets the URI rather than just parsing it and doing nothing with it. Fixes issue 3210
If the URI given to the parser has no port or an invalid port, default to 6667. Fixes issue 3208
Change-Id: I90ac6dbcc6544d82effee6dcd655d87d05126742
Reviewed-on: http://gerrit.dmdirc.com/126
Tested-by: Shane Mc Cormack <shane@dmdirc.com>
Reviewed-by: Gregory Holmes <greboid@dmdirc.com>
Tested-by: Gregory Holmes <greboid@dmdirc.com>
Add getMap() to Parser and IRCParser. Fixes issue 3206
Add getMap() to ChannelInfo and make getMap() in IRCChannelInfo behave the same way as in IRCClientInfo and IRCChannelClientInfo
Change-Id: I2cdce2eb87e77139520254eec98b51288510f043
Reviewed-on: http://gerrit.dmdirc.com/125
Tested-by: Shane Mc Cormack <shane@dmdirc.com>
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
- IRCAuthenticator only stores a username/password for a proxyhost:proxyport pair for as long as there are servers registerd that use that proxy. (Servers configured to use the proxy but with no username/password are not known by the IRCAuthenticator)
Rework how the IRCParser uses the IRCAuthenticator:
- Connecting to any socks-proxied server is now semaphored to 1 at a time so that it shouldn't be possible for the IRCAuthenticator to know of more than 1 username/password pair at a time (which negates the need for the above change when used by this IRCParser)
This should prevent the issue described in issue 1852 from happening.
Change-Id: Ifaa3aaca5aafcddf11b2e8fcbc691903c2fefd10
Reviewed-on: http://gerrit.dmdirc.com/112
Tested-by: Shane Mc Cormack <shane@dmdirc.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>
This should work for most cases of irc links, but irc://irc.quakenet.org/#foo,#bar will cause URI to complain long before it gets to the parser to even attempt to handle it. (Altho the /newserver command makes it appear as "Invalid port")
Fixes Issue 3112
Change-Id: I45f38664753eaf446880f7d6c36fade0328dcca2
Reviewed-on: http://gerrit.dmdirc.com/107
Reviewed-by: Gregory Holmes <greboid@dmdirc.com>
Tested-by: Gregory Holmes <greboid@dmdirc.com>
If we have a 0-length string just ignore it.
Fixes issue 2942
Change-Id: I963aab86ff426fed0fa22fdbd1b3dce36818106a
Reviewed-on: http://gerrit.dmdirc.com/88
Reviewed-by: Chris Smith <chris@dmdirc.com>
Tested-by: Chris Smith <chris@dmdirc.com>
OutputHandlers are now incharge of creating QueueItems and comparing them.
Parser now allows for replacing the OutputQueue entirely
Default OutputQueue allows replacing of the OutputHandler (by giving it a new QueueFactory that outputs the alternative QueueHandler)
Sending PING is now High Priority
QueueItems now sort by a unique itemNumber not time, as priority queue doesn't guarentee order for itesm of teh same priority created at the same time
Add a rate-limited OutputQueue