Chris Smith
0b786eef84
Start using dagger.
9 år sedan
Chris Smith
db20dd3434
Remove unused circular dep, tidy tests.
Remove all tests that depend on TestParser - they're rubbish and
need to be completely rewritten to be proper unit tests.
9 år sedan
Chris Smith
861b7f4e33
Delete callback interfaces.
9 år sedan
Chris Smith
4301740680
Publish events.
9 år sedan
Shane Mc Cormack
177bbb5f9a
2015!
9 år sedan
Chris Smith
1a6a31d9ea
Make IRCProcessor implement handles().
Seems a bit odd for each implementation to define a method that
*always* returns a static String[] when we can just pass that
up to the base class.
9 år sedan
Chris Smith
3f6318d3d2
Quit passing null into callbacks.
9 år sedan
Chris Smith
b01c257343
Don't expose the CallbackManager to processors.
Just add a utility method to get the callback proxy instead.
Think this is a bit nicer, and is one less thing to have to change
if we switch to events.
9 år sedan
Chris Smith
d25b195470
Remove all usages of getCallbackType.
All callbacks are now done through getCallback, which offers
type safety (gasp!) and is potentially extensible in the future
(wow!).
This means that nothing can depend on callbacks existing, so
there are two functional changes:
- the parser will no longer disconnect automatically on failed
pings; users have to listen for the event and handle it
themselves;
- the parser will no longer attempt to automatically use alt
nicknames or create new nicknames on connection; users have to
listen for the event and implement the logic themselves
Both of these were really weird anyway, as adding a listener (even
for debugging purposes) disabled the built-in behaviour.
9 år sedan
Chris Smith
ac736524d8
Split irc/common into separate dirs.
Change-Id: I1d81392650d8193503621b2e69fbe66cd0eb736a
Reviewed-on: http://gerrit.dmdirc.com/4058
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 år sedan
Chris Smith
830e54a9f7
Apply most inspections to the processors package.
Change-Id: I0034aa2dfa84a00adb47e7b6e766108aaf1f8c78
Reviewed-on: http://gerrit.dmdirc.com/3994
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 år sedan
Chris Smith
0e461954b7
Move processors into their own package.
Make all package-private fields and methods they hackily touched
into public, for now.
Change-Id: Ica056a901535b0c0f503283d27ff5210fe625d26
Reviewed-on: http://gerrit.dmdirc.com/3952
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 år sedan
Chris Smith
4d3eb87f06
Final a few things
Change-Id: I22300a4ec7a09ee30a1fbc4d6fb91ff049ca3e39
Reviewed-on: http://gerrit.dmdirc.com/3839
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 år sedan
Shane Mc Cormack
077e65c71e
Update Copyright to 2014
Change-Id: Iad5e74e45bb052f65b761ce8e334b571838edc10
Reviewed-on: http://gerrit.dmdirc.com/2978
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 år sedan
Greg Holmes
f05823ce1c
Tidy javadoc
Change-Id: If8c377f64b3b336203ab4d01aaaa0a731f0545a1
Reviewed-on: http://gerrit.dmdirc.com/2885
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 år sedan
Shane Mc Cormack
807ad3358b
Update copyright for 2013
Change-Id: I1c711ca0525af9a78cbd7c07876eaf6cc91c1434
Reviewed-on: http://gerrit.dmdirc.com/2604
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 år sedan
Shane Mc Cormack
afbd2870b3
Update copyright for 2012
Change-Id: Ie7236e561d04eed00576a8ff6b43228106d3bff5
Reviewed-on: http://gerrit.dmdirc.com/2288
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 år sedan
Chris Smith
43c5d3ee62
Parser tidying
Remove public non-final fields in favour of getters
Remove some unused and some useless methods
Change-Id: I3c0841494242da9a7c3a73f776b783965e6619fb
Reviewed-on: http://gerrit.dmdirc.com/2182
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 år sedan
Shane Mc Cormack
1f8d164115
Add some more parser debugging.
Ignore modes for clients not on the channel.
Change-Id: If5a89ca2450e2583005045af60bdfc00b2a88765
Reviewed-on: http://gerrit.dmdirc.com/2138
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 år sedan
Greg Holmes
002b8b2aa2
Change header?
Change-Id: I4a4bd2f45c18759bced41fc0aec1e570f11dfa6f
Reviewed-on: http://gerrit.dmdirc.com/2073
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 år sedan
Chris Smith
69c5e57258
Style fixes
Change-Id: Ia1d78711f050f6938753a1e8e1dd5dd8b1457b5d
Reviewed-on: http://gerrit.dmdirc.com/1977
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 år sedan
Shane Mc Cormack
f5c407dad2
Update Copyright
Change-Id: I4a6c51789e37e0f96967344c98010ee7ff760506
Reviewed-on: http://gerrit.dmdirc.com/1723
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 år sedan
Greg Holmes
83e12d6517
Fix PMD bugs in parser.
Change-Id: Ifd55c3c04740aa88f349aae5abee7fa817b82e39
Reviewed-on: http://gerrit.dmdirc.com/1692
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 år sedan
Gregory Holmes
6e2c46187b
Style fixes
Change-Id: Ic91544916082a64c1add84fd9e0b68dd91552c40
Reviewed-on: http://gerrit.dmdirc.com/1598
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 år sedan
Chris Smith
b2a61ceabf
Style fixes
Change-Id: I920ca1847ac1af6cf3a13e891e6340f68c6abb91
Reviewed-on: http://gerrit.dmdirc.com/1335
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 år sedan
Chris Smith
acde4c2d05
Style fixes
Change-Id: I51d0e3c7975740b1ede5d6226639022bd15a482a
Reviewed-on: http://gerrit.dmdirc.com/1328
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 år sedan
Shane Mc Cormack
8020751b37
Update the copyright date on all files.
Change-Id: I581861c8c8743cb835c45d128c4b4768372de807
Reviewed-on: http://gerrit.dmdirc.com/201
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
14 år sedan
Shane Mc Cormack
6c97cd0869
Initial commit of parser stuff.
15 år sedan