Browse Source

Tidy up tests.

pull/47/head
Chris Smith 9 years ago
parent
commit
78de406e6f
1 changed files with 23 additions and 19 deletions
  1. 23
    19
      irc/test/com/dmdirc/parser/irc/IRCParserTest.java

+ 23
- 19
irc/test/com/dmdirc/parser/irc/IRCParserTest.java View File

@@ -22,12 +22,10 @@
22 22
 
23 23
 package com.dmdirc.parser.irc;
24 24
 
25
-import com.dmdirc.parser.common.MyInfo;
26
-import com.dmdirc.parser.common.ParserError;
27 25
 import com.dmdirc.harness.parser.TestParser;
28
-import com.dmdirc.parser.interfaces.Parser;
29
-import com.dmdirc.parser.interfaces.callbacks.AuthNoticeListener;
30 26
 import com.dmdirc.parser.common.CallbackNotFoundException;
27
+import com.dmdirc.parser.common.MyInfo;
28
+import com.dmdirc.parser.interfaces.callbacks.AuthNoticeListener;
31 29
 import com.dmdirc.parser.interfaces.callbacks.CallbackInterface;
32 30
 import com.dmdirc.parser.interfaces.callbacks.ChannelKickListener;
33 31
 import com.dmdirc.parser.interfaces.callbacks.ConnectErrorListener;
@@ -39,13 +37,21 @@ import com.dmdirc.parser.interfaces.callbacks.ServerReadyListener;
39 37
 import java.net.URI;
40 38
 import java.net.URISyntaxException;
41 39
 import java.util.Arrays;
42
-import java.util.Date;
43 40
 
44 41
 import javax.net.ssl.TrustManager;
45 42
 
46 43
 import org.junit.Test;
47
-import static org.junit.Assert.*;
48
-import static org.mockito.Mockito.*;
44
+
45
+import static org.junit.Assert.assertEquals;
46
+import static org.junit.Assert.assertFalse;
47
+import static org.junit.Assert.assertTrue;
48
+import static org.mockito.Mockito.anyObject;
49
+import static org.mockito.Mockito.anyString;
50
+import static org.mockito.Mockito.eq;
51
+import static org.mockito.Mockito.mock;
52
+import static org.mockito.Mockito.never;
53
+import static org.mockito.Mockito.same;
54
+import static org.mockito.Mockito.verify;
49 55
 
50 56
 public class IRCParserTest {
51 57
 
@@ -70,8 +76,7 @@ public class IRCParserTest {
70 76
         myParser.injectConnectionStrings();
71 77
         myParser.injectLine(":nick2!ident@host NICK :nick");
72 78
 
73
-        verify(error, never()).onErrorInfo(same(myParser), (Date) anyObject(),
74
-                (ParserError) anyObject());
79
+        verify(error, never()).onErrorInfo(same(myParser), anyObject(), anyObject());
75 80
     }
76 81
 
77 82
     @Test
@@ -152,7 +157,7 @@ public class IRCParserTest {
152 157
         parser.getCallbackManager().addCallback(ServerErrorListener.class, test);
153 158
         parser.injectLine("ERROR :You smell of cheese");
154 159
 
155
-        verify(test).onServerError(same(parser), (Date) anyObject(), eq("You smell of cheese"));
160
+        verify(test).onServerError(same(parser), anyObject(), eq("You smell of cheese"));
156 161
     }
157 162
 
158 163
     @Test
@@ -163,7 +168,7 @@ public class IRCParserTest {
163 168
         parser.sendConnectionStrings();
164 169
 
165 170
         parser.injectLine("NOTICE AUTH :Random auth notice?");
166
-        verify(test).onNoticeAuth(same(parser), (Date) anyObject(), eq("Random auth notice?"));
171
+        verify(test).onNoticeAuth(same(parser), anyObject(), eq("Random auth notice?"));
167 172
     }
168 173
 
169 174
     @Test
@@ -174,7 +179,7 @@ public class IRCParserTest {
174 179
         parser.sendConnectionStrings();
175 180
 
176 181
         parser.injectLine(":us.ircnet.org 020 * :Stupid notice");
177
-        verify(test).onNoticeAuth(same(parser), (Date) anyObject(), eq("Stupid notice"));
182
+        verify(test).onNoticeAuth(same(parser), anyObject(), eq("Stupid notice"));
178 183
     }
179 184
 
180 185
     @Test
@@ -185,7 +190,7 @@ public class IRCParserTest {
185 190
         parser.sendConnectionStrings();
186 191
         parser.injectLine(":chris!@ NICK :user2");
187 192
 
188
-        verify(test, never()).onNoticeAuth((Parser) anyObject(), (Date) anyObject(), anyString());
193
+        verify(test, never()).onNoticeAuth(anyObject(), anyObject(), anyString());
189 194
     }
190 195
 
191 196
     @Test
@@ -196,7 +201,7 @@ public class IRCParserTest {
196 201
 
197 202
         parser.injectLine(":server 001 nick :Hi there, nick");
198 203
 
199
-        verify(test).onNumeric(same(parser), (Date) anyObject(), eq(1),
204
+        verify(test).onNumeric(same(parser), anyObject(), eq(1),
200 205
                 eq(new String[]{":server", "001", "nick", "Hi there, nick"}));
201 206
     }
202 207
 
@@ -221,11 +226,11 @@ public class IRCParserTest {
221 226
         };
222 227
 
223 228
         for (String string : strings) {
224
-            verify(test, never()).onServerReady((Parser) anyObject(), (Date) anyObject());
229
+            verify(test, never()).onServerReady(anyObject(), anyObject());
225 230
             parser.injectLine(string);
226 231
         }
227 232
 
228
-        verify(test).onServerReady(same(parser), (Date) anyObject());
233
+        verify(test).onServerReady(same(parser), anyObject());
229 234
     }
230 235
 
231 236
     @Test
@@ -333,8 +338,7 @@ public class IRCParserTest {
333 338
         parser.getCallbackManager().addCallback(ChannelKickListener.class, ick, "#D");
334 339
         parser.injectLine(":bar!me@moo KICK #D nick :Bye!");
335 340
 
336
-        verify(ick).onChannelKick(same(parser), (Date) anyObject(), (IRCChannelInfo) anyObject(),
337
-                (IRCChannelClientInfo) anyObject(), (IRCChannelClientInfo) anyObject(),
341
+        verify(ick).onChannelKick(same(parser), anyObject(), anyObject(), anyObject(), anyObject(),
338 342
                 anyString(), anyString());
339 343
     }
340 344
 
@@ -344,7 +348,7 @@ public class IRCParserTest {
344 348
         final ConnectErrorListener tiei = mock(ConnectErrorListener.class);
345 349
         tp.getCallbackManager().addCallback(ConnectErrorListener.class, tiei);
346 350
         tp.runSuper();
347
-        verify(tiei).onConnectError(same(tp), (Date) anyObject(), (ParserError) anyObject());
351
+        verify(tiei).onConnectError(same(tp), anyObject(), anyObject());
348 352
     }
349 353
 
350 354
 }

Loading…
Cancel
Save