Rename confusing method name and add correctly functioning one.
This fixes portable mode when running from a jar only.
Change-Id: I8272e2ff2fe1c6d88d6f6c41c859eb2d2124e04c
Issue: CLIENT-496
Reviewed-on: http://gerrit.dmdirc.com/3402
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
Use the right method when checking bundled plugins
Certain PluginManager methods will read plugin info from disk,
while others just use cached info. There's no obvious way to
tell which is which, and we ended up calling the wrong one.
Now we actually know about plugins that're installed, we can
extract the bundled ones. Yay.
Conflicts:
src/com/dmdirc/ClientModule.java
Change-Id: I995f0a5bec8ef06db887127119d4f0f9209bf4bf
Fixes-Issue: CLIENT-498
Reviewed-on: http://gerrit.dmdirc.com/3374
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Reviewed-on: http://gerrit.dmdirc.com/3375
Handle errors when creating defaults dirs properly
If we can't create the defaults directory it's a Very Bad Sign™, and
we should bail out immediately. It probably means the user is running
from a directory they don't have write access to, and if we can't
write defaults then the client isn't going to work very well at all.
Previous behaviour tried to carry on and failed a precondition check
and died even more painfully.
Change-Id: Id72fb63c014939ac384ee03b9eb0f14baf6e18fe
Fixes-Issue: CLIENT-488
Reviewed-on: http://gerrit.dmdirc.com/3335
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Reviewed-on: http://gerrit.dmdirc.com/3348
If we pass required = false then the config manager will happily
return null if it encounters a disabled optional setting. We
don't accept null so that's a bit daft.
Change-Id: I37934ba15877b8c0caf188b5f80e3353c8555134
Fixes-Issue: CLIENT-491
Reviewed-on: http://gerrit.dmdirc.com/3333
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Reviewed-on: http://gerrit.dmdirc.com/3347
The current implementation has its own low priority thread pool.
We're already executing it in a thread ourselves, so just send
them right away.
I think this causes us to not log fatal errors to Sentry sometimes.
Conflicts:
src/com/dmdirc/logger/ProgramError.java
Change-Id: Ib4a105711e71be254e73b9aad1b244fc59fc79a4
Reviewed-on: http://gerrit.dmdirc.com/3328
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Reviewed-on: http://gerrit.dmdirc.com/3346
plugins:
773ff13 Greg Holmes <greg@dmdirc.com>
Show PMD directly from FRW isntead of via actions.
Also fix the debug command to show first run wizard.
Gerrit: http://gerrit.dmdirc.com/3234
Change-Id: Idabb6923b46a55f507089bf0427c12d4827725a4
plugins:
1bb3e67 Chris Smith <chris@dmdirc.com>
Fix NPE in FD notifications plugin.
We had two instances of the FDManager around - one for the command and
once owned by the plugin. The command's instance was never loaded so
had no icon.
Fixes-Issue: CLIENT-471
Gerrit: http://gerrit.dmdirc.com/3231
Change-Id: Ic6969ce5301427a73f2c816e5f278d6ff122519b
plugins:
f01ef8c Chris Smith <chris@dmdirc.com>
Make dagger version explicit.
Things built with 1.2.1 compiler won't run with the runtime library
from 1.2.0, so we need to ensure releases remain consistent.
Gerrit: http://gerrit.dmdirc.com/3230
Change-Id: I3931053ffb8fc9eb42ff1f31183824e2bdf957f6
Things built with 1.2.1 compiler won't run with the runtime library
from 1.2.0, so we need to ensure releases remain consistent.
Change-Id: Ie69349814cfce4c0d229be4372ce7210211a0497
Reviewed-on: http://gerrit.dmdirc.com/3229
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
plugins:
0e13564 Greg Holmes <greg@dmdirc.com>
Stop using objects before they exist in script plugin.
Fixes-Issue: CLIENT-467
Gerrit: http://gerrit.dmdirc.com/3226
Change-Id: I18ab0549e8198a84208f625e188f75e83509d644
plugins:
8664b2e Chris Smith <chris@dmdirc.com>
Fix error trying to save CSD settings.
Because of the ordering of assignments in ChannelSettingsDialog's ctor,
we weren't assigning the global config before passing it in to the
list modes pane. This caused NPEs if toggling the 'show extended info'
option and saving.
Fixes-Issue: CLIENT-454
Gerrit: http://gerrit.dmdirc.com/3212
Change-Id: Iad05e2ded5e368ec1c3b632c68d6c110adf2ed70
Previously /mode #channel failed with an exception trying to
get the arguments. Now it works as expected.
Also fix an issue with silence chars not being propagated to
channel command - /.topic #channel will now work silently.
Change-Id: Ifa314b0daf81a30003d5879b9484e759668bc763
Fixes-Issue: CLIENT-455
Reviewed-on: http://gerrit.dmdirc.com/3208
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
plugins:
2f2b81f Greg Holmes <greg@dmdirc.com>
Fix URL panel.
Reading settings needed to be done from the global config to pick
the defaults, writing settings to the user config.
Fixes-Issue: CLIENT-457
Gerrit: http://gerrit.dmdirc.com/3209
Change-Id: I76d483430727ed05e107ea39bfa8cc5c89cd02b9
plugins:
87ee148 Greg Holmes <greg@dmdirc.com>
Fix some errors in the PMD.
Validate profile names for uniqueness as well as filenames.
Remove spaces from auto generated nickname on creation of profile.
Fixes-Issue: CLIENT-461
Fixes-Issue: CLIENT-462
Gerrit: http://gerrit.dmdirc.com/3206
Change-Id: Ia6735b29a473bacbd87672605c0db204bf160847
Greg Holmes