Issue #750

Mockito now errors if a mock is unnecessary, plus a few other minor
API changes.

This is just an IntelliJ refactor, using EventBus in place of
DMDircMBassador whenever possible.

Stop swimming against the tide and accept what most of the rest of
the world does.

While it adds an annoying depth to the actual source code, it makes
the root directory nicer (no more 'test-res' dirs), means we don't
have to override the gradle config, and makes it nicer to work in
IDEA 2016.1.

Instead of passing them in to the FrameContainer ctor, create
them afterwards.

This means the reference in FrameContainer can't be final but
removes the horrible setOwner() kludge that was previously in
CommandParser, and cuts down the deps needed to pass in to the
FrameContainer ctor.

Remove them from the Connection interface.

Pointless now getChannel is optional.

Change-Id: I3665cac8af833da793ca418953d934cc3a333459
Depends-On: I348b37a14097439f8a56b0a671794410e46201ca
Depends-On: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3939
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Remove most references to Server.

Change-Id: I8888522d58ff4d332c4a477702442c29a82d12ff
Depends-On: Ic0e6e5f95adc30e773945c95e73d321d589503d2
Reviewed-on: http://gerrit.dmdirc.com/3872
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I5db4e866f20ca7e8d4c1ba596ef6248755f4d2ec
Depends-On: I58e485b06887b1215b4d4cba7f2244404a7b81aa
Reviewed-on: http://gerrit.dmdirc.com/3870
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: Id3cfa404a56528542120f79c969d992a5c183aba
Reviewed-on: http://gerrit.dmdirc.com/3771
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I2baa7e986ded54930093768238ed24cab8cf4bf7
Depends-On: I2cf35d5859c85c3609002f126241536fda5d588e
Reviewed-on: http://gerrit.dmdirc.com/3769
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Depends-On: I06ee87cf6f7795eb3ee07828fb43f4381a465ac3
Change-Id: Ibcfc059d943a64494842eab68428ea8351206a09
Reviewed-on: http://gerrit.dmdirc.com/3488
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Pass in a ScheduledExecutorService and use it for who timers and
reconnect timers.

Only run the who timer when we're connected, not the whole time.
This stops the Server ctor starting a timer.

Change-Id: Iea92d7046f33eda7666b8a2b739374345e8ea20d
Reviewed-on: http://gerrit.dmdirc.com/3419
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Id0904867640e49e12fca5c1c7c5b9e72c78e3a1b
Reviewed-on: http://gerrit.dmdirc.com/2976
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I64ae53a907ba8540cc7eb5e57b2374e8938dd52f
Reviewed-on: http://gerrit.dmdirc.com/2965
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I9890b67a410c382ac29bd8c264fb7deed389710e
Reviewed-on: http://gerrit.dmdirc.com/2921
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Ib3f12415ce518c7f2c735667c8a00a3970e75ad3
Reviewed-on: http://gerrit.dmdirc.com/2903
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

This hides most of the dependencies from the ServerManager.

Change-Id: I18e416a99244ad42ae35b30409aeb92f2c7454f4
Reviewed-on: http://gerrit.dmdirc.com/2892
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: Ie04c077e455ad146d4944bf4f69a580109da91ad
Reviewed-on: http://gerrit.dmdirc.com/2890
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: Iaafcea914d16f33ce98c331084cd3e9c8fdbbeda
Depends-On: I1cd8a5676beab1f3aba7f62b064dd5b2c2ce0f61
Reviewed-on: http://gerrit.dmdirc.com/2821
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Constructors shouldn't be leaking references to themselves all over
the place.

Change-Id: I4568a354e5dbd2561c247ff4b80badb781394662
Reviewed-on: http://gerrit.dmdirc.com/2808
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Make Servers use it to break their dependency on AliasWrapper,
which was odd and annoying.

Change-Id: I1c515b65d88049bd9288e1334e5ebe5fa9c31a80
Reviewed-on: http://gerrit.dmdirc.com/2792
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I4c464fae85be6822d6f03e243c1e3d874dcbff92
Reviewed-on: http://gerrit.dmdirc.com/2790
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I8d791451ead4b37f9181a9741e127cbc8b514d46
Depends-On: I94416680dfa9f0ee4896f5a6518889c6eb891909
Reviewed-on: http://gerrit.dmdirc.com/2754
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I3246495eb2e40231177d4ae14faec70252409ec2
Reviewed-on: http://gerrit.dmdirc.com/2728
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Fully initialise the PluginManager instead of passing around
one in various states of existance.

Move plugin extraction logic into a CorePluginExtractor class.

Inject UpdateManager where appropriate.

Change-Id: I6c15f7682cccd93b40dcc189a0a8466d067095f0
Reviewed-on: http://gerrit.dmdirc.com/2692
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Avoid static/singleton references, and use a temporary Provider<>
implementation that will eventually be replaced by Dagger.

Change-Id: Id1bda9437f71cc9ddceb0a9ed1ba38d4787f2226
Reviewed-on: http://gerrit.dmdirc.com/2671
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Remove all static/singleton references in the constructor so that
Servers can be instansiated sensibly without all the client existing.

Also change everything that creates a Server to use the appropriate
method in the ServerManager instead of doing it manually.

Depends-On: I3fff818d6e6694163660a36f47d60271d8f0e68e
Change-Id: I9842c20b4e4ff846c9bbf4858da794a843c3b053
Reviewed-on: http://gerrit.dmdirc.com/2655
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Depends-On: I72fe837b5ea2352ae0c695948336efcdd92c09c8
Change-Id: I4a3d9b78a5f80aab0330d0906e8c76d00813c97c
Reviewed-on: http://gerrit.dmdirc.com/2523
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.

Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

These need to be rewritten so the dependencies are mocked out

Change-Id: Id8890637da5483efaa112db7613e61fba366e878
Reviewed-on: http://gerrit.dmdirc.com/2378
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

Change-Id: If418fcbcafa64857e6a656bee08fef7399b6a2e3
Reviewed-on: http://gerrit.dmdirc.com/2280
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>

Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>

Depends-On: Ic938a7785a30477f47074e574ec8311723d803a9

Change-Id: I5ebf0bd52682cd0b1798d1b1b54353e5e65e793f
Reviewed-on: http://gerrit.dmdirc.com/1838
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Chris Smith <chris@dmdirc.com>

Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>

Change-Id: Icfab1de147645d80a999c3678daf268e7e115066
Reviewed-on: http://gerrit.dmdirc.com/1331
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>

Highlights:

  - FrameContainers are now generic, according to their window type
  - Writable frame containers now handle their tab completers
  - Redirect plugin works again
  - Windows are no longer actively requested from the UI; the UI
    creates and adds them in response to events from the WindowManager

fixes issue 3997, fixes issue 4000, fixes issue 4012, fixes issue 4030
fixes issue 4027, fixes issue 4028, fixes issue 4029, fixes issue 4031
fixes issue 4032, fixes issue 4033

Change-Id: Ife307728e46bd3b6dcd189be6886ab8b6fbd9212
Reviewed-on: http://gerrit.dmdirc.com/1144
Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Automatic-Compile: Gregory Holmes <greg@dmdirc.com>