plugins:
87cd3e2 Chris Smith <chris@dmdirc.com>
Desingleton DccCommandParser.
Can't see why it was a singleton, really.
Gerrit: http://gerrit.dmdirc.com/2838
Change-Id: I853426b1b1f13d1032195f4bbccd971fad7f001c
Whoever creates windows should add them to the window manager
(which saves passing a 'focus' boolean into the constructor,
which is odd), and fire the relevant action event.
Change-Id: I97d143c5250df734fa3adca0c7da4d76a5c87e8b
Reviewed-on: http://gerrit.dmdirc.com/2833
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
This removes some static references and simplifies the
constructors of some of our model classes quite a bit.
Change-Id: Ic1644412a4956aa01b67e1129be47420c7a47b46
Reviewed-on: http://gerrit.dmdirc.com/2832
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Don't manually iterate servers and look up the global window,
instead just use the WindowManager to find writable root windows.
This also fixes a bug whereby aliases were never removed from
the global window.
Change-Id: I8e009e03b1d48646a01b683d20712fd042628349
Reviewed-on: http://gerrit.dmdirc.com/2834
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
parser:
c15082c Chris Smith <chris@dmdirc.com>
Make CHANTYPES handling somewhat sane.
Get rid of weird round-the-houses method of processing, and avoid
duplicating the value in a map and a field.
This fixes our handling of servers doing really stupid, theoretical
things like resetting the CHANTYPES they support. (And by "fixes"
I mean the parser will keep state, while everything else burns
around it.)
Gerrit: http://gerrit.dmdirc.com/2831
Change-Id: I292c11f05ce14b90d419537c1df496004be8a4df
Allows injection of the global ConfigManager instead of having
to get an IdentityManager and call getGlobalConfig...().
Change-Id: Ifa79919e201c418c99899ce5a0a815ac646e5a77
Reviewed-on: http://gerrit.dmdirc.com/2830
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Introduces a ConfigProviderMigrator interface, which allows
migration of a ConfigProvider. This allows the owner of
the provider to migrate it, and pass around an instance,
while prevent any other user accidentally migrating it.
e.g. Server can own a ConfigProviderMigrator, and only
expose the inner ConfigProvider, so noone else can migrate
it to a different target.
Change-Id: I2a78947f60ba42c6877433c897ef458cead6a3e3
Fixes-Issue: CLIENT-408
Reviewed-on: http://gerrit.dmdirc.com/2828
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Errors that happen before the IdentityManager is configured
are useful to be able to see.
Change-Id: Iad6c54182aa101528e8bb2169ed08249f650f39c
Reviewed-on: http://gerrit.dmdirc.com/2827
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Remove the remaining WindowManager singleton refs.
Add a GlobalWindowManager to keep state and references, rather than
use static methods on GlobalWindow.
Minor tidying.
Change-Id: I65b84082f0a07cdc9e4c05263f6c5c77282e9b04
Reviewed-on: http://gerrit.dmdirc.com/2818
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
parser:
dac7f08 Chris Smith <chris@dmdirc.com>
Tidy up the 004/005 processor a bit.
Introduce methods for handling individual bits, instead of having
a pair of giant if statements of doom.
Tidy some comments and formatting up at the same time.
This is functionally the same as it was before.
Gerrit: http://gerrit.dmdirc.com/2812
Change-Id: If5d024870222097fe83f303fb85a201d87f9798e
When we split an outgoing query we displayed the whole line
locally for each split part going not, not the actual part.
Change-Id: I99e1ef3ce3f0c8a36b6b4a88d3ba9329bf693403
Fixes-issue: CLIENT-384
Reviewed-on: http://gerrit.dmdirc.com/2810
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Constructors shouldn't be leaking references to themselves all over
the place.
Change-Id: I4568a354e5dbd2561c247ff4b80badb781394662
Reviewed-on: http://gerrit.dmdirc.com/2808
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
plugins:
c6ed9e1 Chris Smith <chris@dmdirc.com>
Pass in CommandControllers to some plugin commands
I got bored about half way through, so more to go at some point.
Gerrit: http://gerrit.dmdirc.com/2807
Change-Id: Id751bc784de3d697deb3199f09143dba427651b1
If we add or remove components while an update check is ongoing
we used to throw a CME. This could happen either when the client
is first starting and in the process of adding components, or
if some listener decided to add/remove components as they were
being checked.
Change-Id: I200a3b4804bd7e815a4f053ca596b41f7c4c4c24
Fixes-issue: CLIENT-404
Reviewed-on: http://gerrit.dmdirc.com/2795
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Make Servers use it to break their dependency on AliasWrapper,
which was odd and annoying.
Change-Id: I1c515b65d88049bd9288e1334e5ebe5fa9c31a80
Reviewed-on: http://gerrit.dmdirc.com/2792
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Pass in identity controller, action controller and their directory.
This means the tests can stub out most things.
Change-Id: Ia42c0b913654dcd9fd0d460fd2c8a0bd0a4976a3
Reviewed-on: http://gerrit.dmdirc.com/2787
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
plugins:
8d38a54 Chris Smith <chris@dmdirc.com>
Use injected ActionFactory everywhere.
Depends-On: I9593bfaf82ac22b629e9fde5380e08f3aa0eea86
Gerrit: http://gerrit.dmdirc.com/2785
Change-Id: Id96c4130a4e07b50f3e7fd953be493f73a1f2806
Git