Chris Smith
fe114fb56f
Remove some more TestMain references.
Rework how Logger/ErrorManager interact so they can be half
mocked out (or, at least, used in a thread-safe-ish manner).
Change-Id: Ia5899640bdc101793819dab88c3fe6038a759abb
Reviewed-on: http://gerrit.dmdirc.com/2695
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 10 Jahren
Chris Smith
861fe41dfb
Fix tests that don't work in parallel.
Make the ColourManager into a proper class so it can have
dependencies, just like a real boy.
Change-Id: Ib49f046f7dee6f240cb0970603b4fcd3d71f3cba
Reviewed-on: http://gerrit.dmdirc.com/2696
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 10 Jahren
Chris Smith
c87f4de60a
Stop IdentityManager initialising itself.
Instead, have Main provide the instance which becomes the
singleton. This allows us to inject dependencies to it, and
construct it using dagger later, while keeping all of the
code that calls the static getIdentityManager() method working.
Change-Id: I4ceaa062c84509bed66824f39cca8e76d25d131c
Reviewed-on: http://gerrit.dmdirc.com/2677
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 10 Jahren
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 11 Jahren
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 11 Jahren
62db47acbb
Tidy up unit Prefs stuff (and unit test!)
Change-Id: I428aa1596e7d41e6842175d805d88a4421c1b764
Depends-On: Id8e090709271b6a908bc56273b9ff8dfd180370d
Reviewed-on: http://gerrit.dmdirc.com/2452
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 12 Jahren
Chris Smith
3031258c3b
Tidy the PrefrencesManager, add some basic unit tests
Change-Id: I908f44f84f8413d19950de6aebf419c1f747098a
Reviewed-on: http://gerrit.dmdirc.com/2431
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
Chris Smith
5c64a29c45
Deprecations
Change-Id: I1aa33d6e360f6050b02b7fe3f7db1312451c93fb
Reviewed-on: http://gerrit.dmdirc.com/2282
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 12 Jahren
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
Chris Smith
41304ccecb
More deprecation fixes
Change-Id: If418fcbcafa64857e6a656bee08fef7399b6a2e3
Reviewed-on: http://gerrit.dmdirc.com/2280
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 12 Jahren
Chris Smith
d4507e0b3a
Deprecation fixes
Sprinkle some annotations over the CommandManager
More fiddling with NB7.1 settings
Change-Id: I2a0b751798249d4cc3e527f6d2e5525d1936f0e1
Reviewed-on: http://gerrit.dmdirc.com/2278
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
80871d51a7
Begin to remove deprecated IdentityManager methods
Change-Id: I7c24baa6f2e64302406e656a8931390aff9d3c9d
Depends-On: I1fc7086057871a9b5f5f6d0ec790ec28b7ee067f
Reviewed-on: http://gerrit.dmdirc.com/2203
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
vor 12 Jahren
60d9db2dcf
Centralised interfaces packages.
Depends-On: I862891efc407a64559788812ee039a9ec565a973
Change-Id: If624693f050e1aa9cf4cabcd5264518604eb8bcd
Reviewed-on: http://gerrit.dmdirc.com/2167
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
vor 13 Jahren
61c7913433
Remove UI specific preferences methods from UIController.
Fixes CLIENT-274
Change-Id: I58feef90e9a80ef54549b84b6370fe0378e16996
Depends-On: Ic341d8fe573e6e2c0a8da07bd02e41110e7668e9
Reviewed-on: http://gerrit.dmdirc.com/2102
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 13 Jahren
a4031bdad2
Add getMetaData method to PluginInfo and use it
Change-Id: I0bf84a236b3d4a3a86bb3cdceadbfb972b7dec27
Reviewed-on: http://gerrit.dmdirc.com/2089
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 13 Jahren
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 13 Jahren
Chris Smith
521daeca81
Initial work in action error persistence
Also remove deprecated methods
Change-Id: Id3d1e92c7db813911b4bf4f27b92d4eff92bdd41
Depends-On: Ib20eb804c786b157a33c6d0610e9151200371400
Reviewed-on: http://gerrit.dmdirc.com/1963
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 13 Jahren
acdd8268bc
Remove deprecations.
Depends-On: Ic938a7785a30477f47074e574ec8311723d803a9
Change-Id: I5ebf0bd52682cd0b1798d1b1b54353e5e65e793f
Reviewed-on: http://gerrit.dmdirc.com/1838
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
vor 13 Jahren
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
vor 13 Jahren
Chris Smith
33bae9d01d
Rename PreferencesManager to PreferencesDialogModel
Change-Id: Ied76e21fbf72039d47ec2b35b236149c13941645
Depends-On: Ia126a15b60e54c08c1e780676fe363821e9b7518
Reviewed-on: http://gerrit.dmdirc.com/1591
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
vor 13 Jahren
Chris Smith
39693ea024
Rework how config sources handle invalid and disabled settings
Fixes CLIENT-46
Depends-On: I8434b810ba3ee5548467c3fd2b72faed4046a586
Change-Id: I79e9a19acf452c831ee6e671f50b54e8f674f2cd
Reviewed-on: http://gerrit.dmdirc.com/1569
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
vor 13 Jahren
Chris Smith
eafec02238
Make preferences manager use current UI
Fixes issue 4415
Change-Id: I52c7f76361f8b2fe4ebd38b00795e28ca4eee9e5
Reviewed-on: http://gerrit.dmdirc.com/1460
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
10ad8f480d
Move validators out of config.prefs.validator
Fixes issue 4253
Change-Id: Ibb46a6a1ba5c62d525b65f55d39632b82e335539
Reviewed-on: http://gerrit.dmdirc.com/1455
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
5d584f2068
Style fixes
Change-Id: Idffa6c2559bcc2112c9657b15349aa80579ab83a
Reviewed-on: http://gerrit.dmdirc.com/1336
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
6e42762d67
Style fixes
Change-Id: Icfab1de147645d80a999c3678daf268e7e115066
Reviewed-on: http://gerrit.dmdirc.com/1331
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
fc78513b1a
Fix config target unit test
Change-Id: I138e3023f0f92edb1c43520628fd58d9f55e9fa8
Reviewed-on: http://gerrit.dmdirc.com/1236
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
cca25e47e9
Minor random unit test changes
Change-Id: I8664f3e95f513642194cf5f96fb8b2d556cff7d1
Reviewed-on: http://gerrit.dmdirc.com/1070
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
vor 14 Jahren
Chris Smith
3fb1492b70
Unit tests
Change-Id: I0c1d6b4c0e1f60fb2be483dc23dfdf96928a6fbb
Reviewed-on: http://gerrit.dmdirc.com/798
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
Chris Smith
a032a667eb
Move CipherUtils into config package
It's not a general purpose util, and will only be used by the config system.
Change-Id: I2d0ac5ea23d8b7d0fcda6e467ddcf4ac08bc520a
Reviewed-on: http://gerrit.dmdirc.com/731
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
Chris Smith
b6e02f0a30
Fix some unit tests
Change-Id: I2f14be0cecbc842b23dc3c99b5df257b8e6b0d53
Reviewed-on: http://gerrit.dmdirc.com/390
Reviewed-by: Gregory Holmes <greboid@dmdirc.com >
Tested-by: Gregory Holmes <greboid@dmdirc.com >
vor 14 Jahren
450389ebe6
Fix broken unit tests
Change-Id: Ida646aa780dacbce74a6a942a455105f72654377
Reviewed-on: http://gerrit.dmdirc.com/218
Tested-by: Gregory Holmes <greboid@dmdirc.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
187d17230c
Fix the unit tests shane broke
Change-Id: I03af2311e541d60711d2cc801128764fe384d6e7
Reviewed-on: http://gerrit.dmdirc.com/206
Reviewed-by: Chris Smith <chris@dmdirc.com >
Tested-by: Gregory Holmes <greboid@dmdirc.com >
vor 14 Jahren
b691b14491
Update the copyright date on all files.
UpdateCopyright.sh now works out the year automatically.
UpdateCopyright.sh now ignores .git aswell as .svn
UpdateCopyright.sh now excludes Binary Files from being matched during the initial search, rather than as an afterthought.
Change-Id: I2cfc56851a4217a4c85cbc7361c7a90421aae717
Reviewed-on: http://gerrit.dmdirc.com/202
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
vor 14 Jahren
Chris Smith
aefae882de
PreferencesCategory unit tests
vor 15 Jahren
Chris Smith
678e66a2a0
Unit tests for PreferencesManager.{save,dismiss}
vor 15 Jahren
Chris Smith
bfbb990796
Stop IdentityTest creating a dozen or so identities per run. Might fix
quite a few timeouts!
vor 15 Jahren
Chris Smith
67723bd27e
Remove unneeded import which breaks test compilation (oops!)
vor 15 Jahren
Chris Smith
7826058c90
Mock SettingChangeListener instead of using a harness
vor 15 Jahren
Chris Smith
302df8c64b
Remove TestPreferencesInterface in favour of mocking
vor 15 Jahren
Chris Smith
0e29292263
Get rid of TestConfigListener in favour of mocking them when needed
vor 15 Jahren
Chris Smith
cd627c22da
Replace AIC with mocked instance
vor 15 Jahren
Chris Smith
b75ce907b0
Remove TestChangeListener in favour of mocking
vor 15 Jahren
Chris Smith
97899794af
Remove TestActionListener in favour of mocking one up
vor 15 Jahren
Chris Smith
891d6d7dbc
Add mockito library
Add some minor validator tests
vor 15 Jahren
Chris Smith
a248ca7092
Test fixes
vor 15 Jahren
Chris Smith
b435501251
Fix some broken unit tests
Remove junit 3 stuff
vor 15 Jahren
Chris Smith
f691e7ad16
Remove now-useless tests
vor 15 Jahren
Chris Smith
3337772fe8
PreferencesSettings may no longer take a fallback
vor 15 Jahren
Chris Smith
b3af85eb82
Fix prefs manager test, maybe
vor 15 Jahren
Chris Smith
Shane Mc Cormack