Use Guava's Preconditions instead, which throw appropriate exceptions
rather than AssertionErrors (whose idea was that?!)
Also fix weirdness in CommandArguments where start was allowed to be
1 greater than end when getting words.
Change-Id: Icce38e36da6507f645fb8b3b872dfe2c60c43ea7
Reviewed-on: http://gerrit.dmdirc.com/2961
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
plugins:
6f293a1 Chris Smith <chris@dmdirc.com>
Use the event bus for ClientOpened events.
Add Guava as a build-time dependency for plugins.
Gerrit: http://gerrit.dmdirc.com/2959
Change-Id: Ibda3afac0bca4aca08cef2d62330fed1d60d19ee
Swing UI + Apple is too tangled up to do it using nice DI atm :(
Change-Id: Ie06dc705e78b6475cda01cfc1850dcb732ebcdcc
Reviewed-on: http://gerrit.dmdirc.com/2957
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Don't include all libs on the CP when running.
Put the main libraries first, rather than letting plugins trash the classpath.
Change-Id: I0b048a603ba4c854370807c6ae89c5a400423686
Reviewed-on: http://gerrit.dmdirc.com/2953
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
plugins:
5138fca Chris Smith <chris@dmdirc.com>
FrameContainers now expose Connections.
Depends-On: I02a54b0bcfaef08d5757cc015c356f9779ec0371
Gerrit: http://gerrit.dmdirc.com/2949
Change-Id: Ie706661b324006fe70cece9f7c986574251f8920
Anywhere that doesn't just work with a Connection, cast back to a Server for
now. These can be tidied up later.
Change-Id: I02a54b0bcfaef08d5757cc015c356f9779ec0371
Depends-On: Id55c3611173be7ed79fae8f9e976996d713b8646
Reviewed-on: http://gerrit.dmdirc.com/2950
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Move Updater-based providers into a separate module, and inject
the actual dependencies into the DMDircUpdateManager instead of
various 2nd degree dependencies so it can make them itself.
This should make it easier to add other strategies/download
sites/etc.
Change-Id: Id8a7871fbf7d383b05c5fd08e31dea3bd3703444
Reviewed-on: http://gerrit.dmdirc.com/2932
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Why throw a ClassNotFoundException that the caller is expecting,
when you can completely break the ClassLoader contract and return
null? YAY. </snark>
Change-Id: I1d2aff71db8d0efde8d15f87e50edad962a2c52b
Reviewed-on: http://gerrit.dmdirc.com/2931
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Remove ctor that was only used in tests.
Use Connection interface rather than requiring a Server.
Change-Id: Id7fa18cab27302045f60c32b478173de99a5df4d
Reviewed-on: http://gerrit.dmdirc.com/2925
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
plugins:
ab9dd86 Chris Smith <chris@dmdirc.com>
Initial foray into Swing UI DI.
Add a SwingManager to manage the injected content - eventually
this will become the SwingController.
Gerrit: http://gerrit.dmdirc.com/2913
Change-Id: I2f1968de304ca1c49c2e54c6d5278c7afaa4a8c8
plugins:
8702c8f Chris Smith <chris@dmdirc.com>
Support non-static PopupManager.
Depends-On: Idbed116f8774b0be617c7123b1a35f52133cdac5
Gerrit: http://gerrit.dmdirc.com/2912
Change-Id: I6c7d6de27b5eccdab38b0d55ffb0effb6b865c36
plugins:
5c1cdc9 Chris Smith <chris@dmdirc.com>
Support for ActionSubstitutorFactories.
Depends-On: Ie2960171e29fa4069747ca9a6cd8b427ffc73003
Gerrit: http://gerrit.dmdirc.com/2910
Change-Id: If9d26eb4f4ada450da013d6215564b1dc7b876ff
This allows them to be injected with all their dependencies, removing
some deprecated singleton methods or constructor usages.
Change-Id: Ie2960171e29fa4069747ca9a6cd8b427ffc73003
Depends-On: I06b391f62bf6e72b0f24d2dda91e36242564fdff
Reviewed-on: http://gerrit.dmdirc.com/2915
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Git