Not using IconManager to minimise dependencies and reduce causes
of further errors.
Change-Id: I1e8dbfab5705e9965ee24c05f116891271b87326
Fixes-Issue: CLIENT-526
Reviewed-on: http://gerrit.dmdirc.com/3650
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
This is injectable - you shouldn't need a PluginManager to know
where the files are.
Also give CorePluginExtractor an injectable ctor instead of having
a useless provides method.
Change-Id: Id96f671dbd55a5ad8f130f45d4d2eb7ca3d2c9ab
Reviewed-on: http://gerrit.dmdirc.com/3649
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
When migrating make sure that existing multi-line aliases get
command chars (and any following silence chars) removed, rather
than just doing it from the first line.
Change-Id: I08b7081cd3f582901909001586048b209acbfa31
Fixes-Issue: CLIENT-512
Reviewed-on: http://gerrit.dmdirc.com/3645
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Disable some new 'controversial' PMD rules, and enable some of the
others we had suppressed.
Change-Id: Ia15d78858617e8b4dcc71c47b91d9975118206a9
Reviewed-on: http://gerrit.dmdirc.com/3642
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Not much point throwing an exception if the server's state has
already been mucked up.
Change-Id: I3c64b46ab8c8f432a8276cb717b8816af1bea56a
Reviewed-on: http://gerrit.dmdirc.com/3640
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Only squelsh the response if the event *has* been handled by
something else.
Change-Id: I173e89c26470c1f605ce56f3e6c04b0d29476b35
Reviewed-on: http://gerrit.dmdirc.com/3639
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Not sure why we didn't do this before.
Also unregister the config listener when the channel is closed,
because not leaking things is Good.
Change-Id: I76aaf1f9dad22c2066f78d66a0d87da24320e2a0
Reviewed-on: http://gerrit.dmdirc.com/3638
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
This model should happily cope with the existing profiles wrapper
being rewritten and when the UI uses this model should mean no UI
changes required to add support.
Change-Id: Iea3b7838cef94514865ecb77064c133ca4556030
Reviewed-on: http://gerrit.dmdirc.com/3619
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
The profiles wrapper needs to be replaced (probably), the model is
flexible enough to cope with this. It's still a little bit hacky
with the wrapped model and if we stick with them we should probably
change this model.
EditSelectedProfileNameValidator and EditSelectedNicknameValidator
are both a work in progress and quite like prevent the editing of
profiles.
This still needs to be unit tested.
Change-Id: I9dd73f62ae3641b8d11da9881ad13a11a5b4453b
Reviewed-on: http://gerrit.dmdirc.com/3617
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com>
For now this just allows everything (including replacing the
SecurityManager/Policy...) but we can start restricting things
later.
Change-Id: I3627bf06bd35fcebfb42bdc563617b830a999aaa
Reviewed-on: http://gerrit.dmdirc.com/3567
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
This allows it to be used to read other files, such as bundled
defaults.
Change-Id: I1db09ccf6e8048e00e8c73da4962f68c8bb8fb85
Reviewed-on: http://gerrit.dmdirc.com/3555
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Each line needs command chars adding, not just the first one.
Change-Id: I95976dcdf102744e25ed29ea99ff9dd6b32b44ef
Reviewed-on: http://gerrit.dmdirc.com/3554
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
The aliases system expects both names and substitutions to
be plain, as it will add the relevant chars itself.
Change-Id: I1dbe301952148937928d3b1867bce499b255cd3c
Reviewed-on: http://gerrit.dmdirc.com/3546
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Greg Holmes
