Remove the remaining WindowManager singleton refs.
Add a GlobalWindowManager to keep state and references, rather than
use static methods on GlobalWindow.
Minor tidying.
Change-Id: I65b84082f0a07cdc9e4c05263f6c5c77282e9b04
Reviewed-on: http://gerrit.dmdirc.com/2818
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
parser:
dac7f08 Chris Smith <chris@dmdirc.com>
Tidy up the 004/005 processor a bit.
Introduce methods for handling individual bits, instead of having
a pair of giant if statements of doom.
Tidy some comments and formatting up at the same time.
This is functionally the same as it was before.
Gerrit: http://gerrit.dmdirc.com/2812
Change-Id: If5d024870222097fe83f303fb85a201d87f9798e
When we split an outgoing query we displayed the whole line
locally for each split part going not, not the actual part.
Change-Id: I99e1ef3ce3f0c8a36b6b4a88d3ba9329bf693403
Fixes-issue: CLIENT-384
Reviewed-on: http://gerrit.dmdirc.com/2810
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Constructors shouldn't be leaking references to themselves all over
the place.
Change-Id: I4568a354e5dbd2561c247ff4b80badb781394662
Reviewed-on: http://gerrit.dmdirc.com/2808
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
plugins:
c6ed9e1 Chris Smith <chris@dmdirc.com>
Pass in CommandControllers to some plugin commands
I got bored about half way through, so more to go at some point.
Gerrit: http://gerrit.dmdirc.com/2807
Change-Id: Id751bc784de3d697deb3199f09143dba427651b1
If we add or remove components while an update check is ongoing
we used to throw a CME. This could happen either when the client
is first starting and in the process of adding components, or
if some listener decided to add/remove components as they were
being checked.
Change-Id: I200a3b4804bd7e815a4f053ca596b41f7c4c4c24
Fixes-issue: CLIENT-404
Reviewed-on: http://gerrit.dmdirc.com/2795
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Make Servers use it to break their dependency on AliasWrapper,
which was odd and annoying.
Change-Id: I1c515b65d88049bd9288e1334e5ebe5fa9c31a80
Reviewed-on: http://gerrit.dmdirc.com/2792
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Pass in identity controller, action controller and their directory.
This means the tests can stub out most things.
Change-Id: Ia42c0b913654dcd9fd0d460fd2c8a0bd0a4976a3
Reviewed-on: http://gerrit.dmdirc.com/2787
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
plugins:
8d38a54 Chris Smith <chris@dmdirc.com>
Use injected ActionFactory everywhere.
Depends-On: I9593bfaf82ac22b629e9fde5380e08f3aa0eea86
Gerrit: http://gerrit.dmdirc.com/2785
Change-Id: Id96c4130a4e07b50f3e7fd953be493f73a1f2806
This will make it easier to modify actions to have their
dependencies passed in, and be less generally horrible.
Change-Id: Iea79ea52732aec0fe430f16b31ae681e95474bce
Reviewed-on: http://gerrit.dmdirc.com/2784
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
plugins:
4751172 Chris Smith <chris@dmdirc.com>
Remove direct Identity usages.
Depends-On: I66b382d54b77ef030d88448e456a83eb98aca216
Gerrit: http://gerrit.dmdirc.com/2776
Change-Id: I45369bdf55b4966aa941ff4256797ab0ad02e305
Move static factory methods into IdentityFactory, and replace
almost every use of Identity with ConfigProvider.
Depends-On: I6a32f3592cb5fc3df99a23eee62ae961ce0fc143
Change-Id: I66b382d54b77ef030d88448e456a83eb98aca216
Reviewed-on: http://gerrit.dmdirc.com/2777
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
plugins:
f680720 Chris Smith <chris@dmdirc.com>
Remove a bunch of deprecated methods.
Depends-On: I06531664f45d26298d989b9ac82d614c67da8c55
Gerrit: http://gerrit.dmdirc.com/2775
Change-Id: I0e4344c2b2817cf5eb8df1d2880fabb7d5bfdfaf
Tests should include everything on the main classpath, otherwise
you get DMDirc classes extending 3rd party classes, and everything
starts to break when the base classes go bye-bye.
Change-Id: I7579d833bd31ccf12a93da8c3ea8fff3c2a0eff7
Reviewed-on: http://gerrit.dmdirc.com/2771
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Show the editor gutter at 100 cols not 80, as we don't really do
80 in many places.
Move static methods after normal methods, because I changed my
mind.
Change-Id: I2f69de3065f33476fb735ac7441a2184a63229bb
Reviewed-on: http://gerrit.dmdirc.com/2769
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
plugins:
526cb3e Chris Smith <chris@dmdirc.com>
Use config interfaces where possible.
Depends-On: Iaabedda2fa68c4e5562bb069dcdf15fa0c3beeea
Gerrit: http://gerrit.dmdirc.com/2767
Change-Id: Ibf9f673af600c9b02ce46c00826014c0d7fcce32
Git
Chris Smith