Chris Smith
6ae693893d
Enable PMD in gradle + apply fixes.
Change-Id: I3665cac8af833da793ca418953d934cc3a333459
Depends-On: I348b37a14097439f8a56b0a671794410e46201ca
Depends-On: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3939
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 gadus atpakaļ
746bb6081d
Generify MBassador.
Change-Id: Id3cfa404a56528542120f79c969d992a5c183aba
Reviewed-on: http://gerrit.dmdirc.com/3771
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
b12a0cb412
MBassador.
Change-Id: I2baa7e986ded54930093768238ed24cab8cf4bf7
Depends-On: I2cf35d5859c85c3609002f126241536fda5d588e
Reviewed-on: http://gerrit.dmdirc.com/3769
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
Chris Smith
05c552a0e3
Actions tidying.
Change-Id: I77c22319367b42840431e18ee998011a730ac6af
Reviewed-on: http://gerrit.dmdirc.com/3695
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
5337f506f6
Switch to nio for files in Action.
Change-Id: If5b1caa86eade5cb4f97fbe693b8029c5b5bbb95
Reviewed-on: http://gerrit.dmdirc.com/3495
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
ac3c86a653
Remove Action events.
Change-Id: I67b558de082c1ce196800d8b0aafa2d6ce87b298
Reviewed-on: http://gerrit.dmdirc.com/3455
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 gadus atpakaļ
Chris Smith
09cb002be2
Always specify an origin when parsing commands.
Where commands are executed globally, pass in a GlobalWindow.
Make the GlobalWindow a singleton that persists, and is simply
added/removed from the WindowManager when the user wants to
show/hide it.
Change-Id: Iac94848487442509bdbf8ec98f67983e313ed743
Reviewed-on: http://gerrit.dmdirc.com/3451
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
ff0beb9009
Don't leave temporary test directories.
Issue: CLIENT-453
Change-Id: I966a5bcffd3550f8e4b23de1448ae654ed2e7380
Reviewed-on: http://gerrit.dmdirc.com/3194
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
12b39dc0f8
Update Copyright to 2014
Change-Id: Id0904867640e49e12fca5c1c7c5b9e72c78e3a1b
Reviewed-on: http://gerrit.dmdirc.com/2976
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
9b39166bbd
Add a factory for ActionSubstitutors.
This allows them to be injected with all their dependencies, removing
some deprecated singleton methods or constructor usages.
Change-Id: Ie2960171e29fa4069747ca9a6cd8b427ffc73003
Depends-On: I06b391f62bf6e72b0f24d2dda91e36242564fdff
Reviewed-on: http://gerrit.dmdirc.com/2915
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
9591bda084
Inject GlobalCommandParser, and tidying up.
Rename ActionFactory methods to be consistent with @Factory-generated ones.
Change-Id: Iafd20682f2fb0a166c6d7502443b56c3263da85d
Depends-On: Ifa75714ab3445634e61df3d99792cdef602d319e
Reviewed-on: http://gerrit.dmdirc.com/2899
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
fbe6ef7165
Give actions some dependencies.
Pass in identity controller, action controller and their directory.
This means the tests can stub out most things.
Change-Id: Ia42c0b913654dcd9fd0d460fd2c8a0bd0a4976a3
Reviewed-on: http://gerrit.dmdirc.com/2787
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
Chris Smith
bdbe324fd3
Create all actions through a factory.
This will make it easier to modify actions to have their
dependencies passed in, and be less generally horrible.
Change-Id: Iea79ea52732aec0fe430f16b31ae681e95474bce
Reviewed-on: http://gerrit.dmdirc.com/2784
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 gadus atpakaļ
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 gadus atpakaļ
cde8093e4e
Disable broken unit tests
Change-Id: I9d6d9d68f7829105331b7c9a75e72a5f5d30375e
Reviewed-on: http://gerrit.dmdirc.com/2540
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 gadus atpakaļ
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 gadus atpakaļ
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 gadus atpakaļ
Chris Smith
41304ccecb
More deprecation fixes
Change-Id: If418fcbcafa64857e6a656bee08fef7399b6a2e3
Reviewed-on: http://gerrit.dmdirc.com/2280
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
Chris Smith
a7a57eca29
Fix fallout from util changes
Change-Id: I0bfd2dc61096dd9670b269463c27d9b00fd9a917
Depends-On: I6d0665e57f6e0e2ff2fb6a18742acb99010e79bf
Depends-On: Ia8de3c1a5fdc1eb9cfaa8b29a32bb3efb6d8ce6f
Reviewed-on: http://gerrit.dmdirc.com/2242
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 gadus atpakaļ
60d9db2dcf
Centralised interfaces packages.
Depends-On: I862891efc407a64559788812ee039a9ec565a973
Change-Id: If624693f050e1aa9cf4cabcd5264518604eb8bcd
Reviewed-on: http://gerrit.dmdirc.com/2167
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 gadus atpakaļ
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 gadus atpakaļ
Chris Smith
521daeca81
Initial work in action error persistence
Also remove deprecated methods
Change-Id: Id3d1e92c7db813911b4bf4f27b92d4eff92bdd41
Depends-On: Ib20eb804c786b157a33c6d0610e9151200371400
Reviewed-on: http://gerrit.dmdirc.com/1963
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 gadus atpakaļ
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 gadus atpakaļ
b691b14491
Update the copyright date on all files.
UpdateCopyright.sh now works out the year automatically.
UpdateCopyright.sh now ignores .git aswell as .svn
UpdateCopyright.sh now excludes Binary Files from being matched during the initial search, rather than as an afterthought.
Change-Id: I2cfc56851a4217a4c85cbc7361c7a90421aae717
Reviewed-on: http://gerrit.dmdirc.com/202
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Tested-by: Shane Mc Cormack <shane@dmdirc.com >
14 gadus atpakaļ
Chris Smith
b435501251
Fix some broken unit tests
Remove junit 3 stuff
15 gadus atpakaļ
ad6cddbba0
Update copyright header to 2009
15 gadus atpakaļ
Chris Smith
0382f0423e
Unit test issue 1734
git-svn-id: http://svn.dmdirc.com/trunk@4737 00569f92 -eb28-0410-84fd-f71c24880f
16 gadus atpakaļ
Chris Smith
47ceae6b4b
ConfigFile now extends TextFile instead of wrapping it rather oddly (groundwork for fixing issue 1154)
Fixed a couple of deprecated method uses in Server
Removed deprecated TextFile constructor
git-svn-id: http://svn.dmdirc.com/trunk@4005 00569f92 -eb28-0410-84fd-f71c24880f
16 gadus atpakaļ
Chris Smith
85f7ec82e3
Action unit test
git-svn-id: http://svn.dmdirc.com/trunk@3828 00569f92 -eb28-0410-84fd-f71c24880f
16 gadus atpakaļ
Chris Smith
6c5ed5c123
Added Action unit test
Fixed actions not creating directories as expected (thus group renaming not working as expected)
git-svn-id: http://svn.dmdirc.com/trunk@3664 00569f92 -eb28-0410-84fd-f71c24880f
16 gadus atpakaļ
Chris Smith
734bcb880a
Added ActionManager unit test
git-svn-id: http://svn.dmdirc.com/trunk@3663 00569f92 -eb28-0410-84fd-f71c24880f
16 gadus atpakaļ
Chris Smith
07db58ccc0
Remove unused unit tests
git-svn-id: http://svn.dmdirc.com/trunk@2143 00569f92 -eb28-0410-84fd-f71c24880f
17 gadus atpakaļ
Chris Smith
56cd2e8e40
Comment out incorrect unit tests
git-svn-id: http://svn.dmdirc.com/trunk@1971 00569f92 -eb28-0410-84fd-f71c24880f
17 gadus atpakaļ
Chris Smith
065ab57e1b
Tests are now compatible with older JUnit style
git-svn-id: http://svn.dmdirc.com/trunk@1845 00569f92 -eb28-0410-84fd-f71c24880f
17 gadus atpakaļ
83bc9d6152
Fixed tests again (was being norty last time)
git-svn-id: http://svn.dmdirc.com/trunk@1686 00569f92 -eb28-0410-84fd-f71c24880f
17 gadus atpakaļ
81fa9af04a
Updated tests to initialise the config before using it
git-svn-id: http://svn.dmdirc.com/trunk@1684 00569f92 -eb28-0410-84fd-f71c24880f
17 gadus atpakaļ
Chris Smith
9ea50d1f96
Added some small unit tests
git-svn-id: http://svn.dmdirc.com/trunk@1442 00569f92 -eb28-0410-84fd-f71c24880f
17 gadus atpakaļ
Chris Smith
Greg Holmes