Chris Smith
0d04b2f5bd
Add some more IdentityManager tests
Change-Id: Id7c65bb82cebaa33ef1642702a72465930e6bdf6
Reviewed-on: http://gerrit.dmdirc.com/4050
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 jaren geleden
Chris Smith
252f6702d1
Fix IdentityManager extraction, test.
Change-Id: Iad1d54ecebb7b3e5d13318ca2550ebc540cbd62b
Reviewed-on: http://gerrit.dmdirc.com/4044
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 jaren geleden
Chris Smith
b107fb8785
Start adding IdentityManager tests.
Change-Id: I66c8a3500310d214756f0c19a0fc26883d2da440
Reviewed-on: http://gerrit.dmdirc.com/4037
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 jaren geleden
Chris Smith
8c4160a590
Rewrite the ConfigFileBackedConfigProviderTest.
(aka the "IdentityTest")
Make it a lot less dumb, use a virtual FS so we can test reloading
and saving. Fix a bunch of bugs the tests highlighted.
Only things not really tested are the global config specific
behaviours.
Change-Id: I96448eb9c401ce864cd6f39fd95088a4a8a09727
Reviewed-on: http://gerrit.dmdirc.com/4015
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 jaren geleden
Chris Smith
e9b7bc394a
Stupid.
Change-Id: Iabb2d0644fb4412ead64a4c28afa96b1809244bc
Reviewed-on: http://gerrit.dmdirc.com/4013
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 jaren geleden
Chris Smith
aefb110fff
Path-ify the IdentityManager.
Change-Id: Iaf2b64f2bd6dcf834e3621e26ae3ff6b81cdb2b4
Reviewed-on: http://gerrit.dmdirc.com/4007
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 jaren geleden
Chris Smith
13b6b419d9
Remove CipherUtils.
We haven't used this in the N years it's existed, and it uses
scary MD5/DES stuff.
Change-Id: I3934d3cc769980527f03b16a5c273f76fc89cdfb
Reviewed-on: http://gerrit.dmdirc.com/3948
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 jaren geleden
Chris Smith
6ae693893d
Enable PMD in gradle + apply fixes.
Change-Id: I3665cac8af833da793ca418953d934cc3a333459
Depends-On: I348b37a14097439f8a56b0a671794410e46201ca
Depends-On: Ifc4aa601de14ca2526646f499f60329ed7c5935e
Reviewed-on: http://gerrit.dmdirc.com/3939
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
9 jaren geleden
Chris Smith
bbfad60371
Move test resources to test-res.
This breaks ant testing. I plan to change CI to use gradle then
remove the ant rules.
Change-Id: I38ca681b8742f316fc94ebfd8312b1bf4632354f
Reviewed-on: http://gerrit.dmdirc.com/3935
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 jaren geleden
Chris Smith
df55470ea4
Tidying
Change-Id: I2ae082b9a0a6596615627debd052b80502b92c58
Reviewed-on: http://gerrit.dmdirc.com/3920
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
9 jaren geleden
746bb6081d
Generify MBassador.
Change-Id: Id3cfa404a56528542120f79c969d992a5c183aba
Reviewed-on: http://gerrit.dmdirc.com/3771
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
9 jaren geleden
b12a0cb412
MBassador.
Change-Id: I2baa7e986ded54930093768238ed24cab8cf4bf7
Depends-On: I2cf35d5859c85c3609002f126241536fda5d588e
Reviewed-on: http://gerrit.dmdirc.com/3769
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
9 jaren geleden
7037a54c7d
EventBus the prefs events.
Change-Id: Ia3a86ce30a3ad96c2c67597dba341b2b10162c8e
Depends-On: I27e1059cc3228013d30bab85549434dea28f236c
Reviewed-on: http://gerrit.dmdirc.com/3417
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
10 jaren geleden
Chris Smith
fb6952bb5c
Introduce a preferences reader.
Change-Id: I951d38ca97e99e33146e5484512e8934e53daff5
Reviewed-on: http://gerrit.dmdirc.com/3326
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
912140c077
Remove singleton IdentityManager accessors.
Woohoo.
Change-Id: Ib5dfa40b37670633791a39cc166ef53aeb2c2e79
Fixes-Issue: CLIENT-423
Reviewed-on: http://gerrit.dmdirc.com/3145
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
Chris Smith
b9a74f7770
ConfigManager-related tidying.
Change-Id: I7de8a172cdb1d5634d924f897f902040a98ba8e3
Reviewed-on: http://gerrit.dmdirc.com/3084
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
12b39dc0f8
Update Copyright to 2014
Change-Id: Id0904867640e49e12fca5c1c7c5b9e72c78e3a1b
Reviewed-on: http://gerrit.dmdirc.com/2976
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
0b69247ea1
Rename some config classes.
Change-Id: Ieaa7897a5e0bf1168e5c2b4405585558e108ee52
Reviewed-on: http://gerrit.dmdirc.com/2781
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
Chris Smith
14da0a2938
Remove ConfigManager references.
Change-Id: I065a771ff81e565b37689f9d6ea82d4057cec2f1
Reviewed-on: http://gerrit.dmdirc.com/2779
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
d596e02ddc
Remove direct Identity usages.
Move static factory methods into IdentityFactory, and replace
almost every use of Identity with ConfigProvider.
Depends-On: I6a32f3592cb5fc3df99a23eee62ae961ce0fc143
Change-Id: I66b382d54b77ef030d88448e456a83eb98aca216
Reviewed-on: http://gerrit.dmdirc.com/2777
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
a335bf1208
Use config interfaces where possible.
Change-Id: Iaabedda2fa68c4e5562bb069dcdf15fa0c3beeea
Depends-On: I5f140e89bfb8c57804d0a500bbc9f5c18555b0e9
Reviewed-on: http://gerrit.dmdirc.com/2768
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
b354ebdb70
Move old config interfaces into config folder.
Change-Id: I8d791451ead4b37f9181a9741e127cbc8b514d46
Depends-On: I94416680dfa9f0ee4896f5a6518889c6eb891909
Reviewed-on: http://gerrit.dmdirc.com/2754
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 jaren geleden
Chris Smith
fe114fb56f
Remove some more TestMain references.
Rework how Logger/ErrorManager interact so they can be half
mocked out (or, at least, used in a thread-safe-ish manner).
Change-Id: Ia5899640bdc101793819dab88c3fe6038a759abb
Reviewed-on: http://gerrit.dmdirc.com/2695
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
Chris Smith
861fe41dfb
Fix tests that don't work in parallel.
Make the ColourManager into a proper class so it can have
dependencies, just like a real boy.
Change-Id: Ib49f046f7dee6f240cb0970603b4fcd3d71f3cba
Reviewed-on: http://gerrit.dmdirc.com/2696
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
Chris Smith
c87f4de60a
Stop IdentityManager initialising itself.
Instead, have Main provide the instance which becomes the
singleton. This allows us to inject dependencies to it, and
construct it using dagger later, while keeping all of the
code that calls the static getIdentityManager() method working.
Change-Id: I4ceaa062c84509bed66824f39cca8e76d25d131c
Reviewed-on: http://gerrit.dmdirc.com/2677
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 jaren geleden
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 jaren geleden
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 jaren geleden
62db47acbb
Tidy up unit Prefs stuff (and unit test!)
Change-Id: I428aa1596e7d41e6842175d805d88a4421c1b764
Depends-On: Id8e090709271b6a908bc56273b9ff8dfd180370d
Reviewed-on: http://gerrit.dmdirc.com/2452
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 jaren geleden
Chris Smith
3031258c3b
Tidy the PrefrencesManager, add some basic unit tests
Change-Id: I908f44f84f8413d19950de6aebf419c1f747098a
Reviewed-on: http://gerrit.dmdirc.com/2431
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
Chris Smith
5c64a29c45
Deprecations
Change-Id: I1aa33d6e360f6050b02b7fe3f7db1312451c93fb
Reviewed-on: http://gerrit.dmdirc.com/2282
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 jaren geleden
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
Chris Smith
41304ccecb
More deprecation fixes
Change-Id: If418fcbcafa64857e6a656bee08fef7399b6a2e3
Reviewed-on: http://gerrit.dmdirc.com/2280
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 jaren geleden
Chris Smith
d4507e0b3a
Deprecation fixes
Sprinkle some annotations over the CommandManager
More fiddling with NB7.1 settings
Change-Id: I2a0b751798249d4cc3e527f6d2e5525d1936f0e1
Reviewed-on: http://gerrit.dmdirc.com/2278
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
80871d51a7
Begin to remove deprecated IdentityManager methods
Change-Id: I7c24baa6f2e64302406e656a8931390aff9d3c9d
Depends-On: I1fc7086057871a9b5f5f6d0ec790ec28b7ee067f
Reviewed-on: http://gerrit.dmdirc.com/2203
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 jaren geleden
60d9db2dcf
Centralised interfaces packages.
Depends-On: I862891efc407a64559788812ee039a9ec565a973
Change-Id: If624693f050e1aa9cf4cabcd5264518604eb8bcd
Reviewed-on: http://gerrit.dmdirc.com/2167
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 jaren geleden
61c7913433
Remove UI specific preferences methods from UIController.
Fixes CLIENT-274
Change-Id: I58feef90e9a80ef54549b84b6370fe0378e16996
Depends-On: Ic341d8fe573e6e2c0a8da07bd02e41110e7668e9
Reviewed-on: http://gerrit.dmdirc.com/2102
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 jaren geleden
a4031bdad2
Add getMetaData method to PluginInfo and use it
Change-Id: I0bf84a236b3d4a3a86bb3cdceadbfb972b7dec27
Reviewed-on: http://gerrit.dmdirc.com/2089
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 jaren geleden
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 jaren geleden
Chris Smith
521daeca81
Initial work in action error persistence
Also remove deprecated methods
Change-Id: Id3d1e92c7db813911b4bf4f27b92d4eff92bdd41
Depends-On: Ib20eb804c786b157a33c6d0610e9151200371400
Reviewed-on: http://gerrit.dmdirc.com/1963
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 jaren geleden
acdd8268bc
Remove deprecations.
Depends-On: Ic938a7785a30477f47074e574ec8311723d803a9
Change-Id: I5ebf0bd52682cd0b1798d1b1b54353e5e65e793f
Reviewed-on: http://gerrit.dmdirc.com/1838
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 jaren geleden
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 jaren geleden
Chris Smith
33bae9d01d
Rename PreferencesManager to PreferencesDialogModel
Change-Id: Ied76e21fbf72039d47ec2b35b236149c13941645
Depends-On: Ia126a15b60e54c08c1e780676fe363821e9b7518
Reviewed-on: http://gerrit.dmdirc.com/1591
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 jaren geleden
Chris Smith
39693ea024
Rework how config sources handle invalid and disabled settings
Fixes CLIENT-46
Depends-On: I8434b810ba3ee5548467c3fd2b72faed4046a586
Change-Id: I79e9a19acf452c831ee6e671f50b54e8f674f2cd
Reviewed-on: http://gerrit.dmdirc.com/1569
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 jaren geleden
Chris Smith
eafec02238
Make preferences manager use current UI
Fixes issue 4415
Change-Id: I52c7f76361f8b2fe4ebd38b00795e28ca4eee9e5
Reviewed-on: http://gerrit.dmdirc.com/1460
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 jaren geleden
Chris Smith
10ad8f480d
Move validators out of config.prefs.validator
Fixes issue 4253
Change-Id: Ibb46a6a1ba5c62d525b65f55d39632b82e335539
Reviewed-on: http://gerrit.dmdirc.com/1455
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 jaren geleden
Chris Smith
5d584f2068
Style fixes
Change-Id: Idffa6c2559bcc2112c9657b15349aa80579ab83a
Reviewed-on: http://gerrit.dmdirc.com/1336
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 jaren geleden
Chris Smith
6e42762d67
Style fixes
Change-Id: Icfab1de147645d80a999c3678daf268e7e115066
Reviewed-on: http://gerrit.dmdirc.com/1331
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 jaren geleden
Chris Smith
fc78513b1a
Fix config target unit test
Change-Id: I138e3023f0f92edb1c43520628fd58d9f55e9fa8
Reviewed-on: http://gerrit.dmdirc.com/1236
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 jaren geleden
Chris Smith
cca25e47e9
Minor random unit test changes
Change-Id: I8664f3e95f513642194cf5f96fb8b2d556cff7d1
Reviewed-on: http://gerrit.dmdirc.com/1070
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 jaren geleden
Chris Smith
Greg Holmes