Chris Smith
263d9e330d
Inject some action wrappers.
Change-Id: Iee5c2f5062ad1ae3237731fb79b1e03f54566b1f
Reviewed-on: http://gerrit.dmdirc.com/2694
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
4a05d0a32d
Improve some actions tests.
Change-Id: I286836ff0c1b23af34726fcaaa7bebd947b30c7d
Reviewed-on: http://gerrit.dmdirc.com/2685
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
297d591758
Change how the ActionManager's initialised.
Do the same as the IdentityManager, to make it easier to DI later.
Change-Id: I29e96fa04615fa86c028b384ccd26a7a53fee6cf
Reviewed-on: http://gerrit.dmdirc.com/2678
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
ec24b3ece8
Remove ActionManager's Main reference.
URLBuilder can use a static reference for now, as it makes a lot
more sense than getting a PluginManager from an ActionManager(?!?!).
Eventually we'll need to rewrite URLBuilder to not be a bunch of
static methods, so it can be instansiated with a PluginManager.
Change-Id: I609153d236f82dfd632c7da27d841eb6f031e2dd
Reviewed-on: http://gerrit.dmdirc.com/2664
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
7243ab1fba
Pass in most dependencies to Server.
Remove all static/singleton references in the constructor so that
Servers can be instansiated sensibly without all the client existing.
Also change everything that creates a Server to use the appropriate
method in the ServerManager instead of doing it manually.
Depends-On: I3fff818d6e6694163660a36f47d60271d8f0e68e
Change-Id: I9842c20b4e4ff846c9bbf4858da794a843c3b053
Reviewed-on: http://gerrit.dmdirc.com/2655
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
10 vuotta sitten
Chris Smith
29c0c560b6
Remove ActionComponentArgument.
This only exists to pass around global state, and is only used
by one plugin. It's nicer for now if that plugin just accesses
a singleton/static state directly until it can be injected,
rather than make lots of classes and tests depend on Main.
Change-Id: I8ed6e4c90b9c6bdbcaeb01fc276df5819cb47e1a
Depends-On: I4ec47f958b40eb0a03ab50d4a5611e00b0c83f39
Reviewed-on: http://gerrit.dmdirc.com/2656
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
10 vuotta sitten
0de66ad59f
Fix bug introduced in Id3d1e92c7db813911b4bf4f27b92d4eff92bdd41 that stops actions actually being deleted.
Change-Id: If6e8325a94b5796df6a08d63e2d1d6b69364da55
Reviewed-on: http://gerrit.dmdirc.com/2630
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
11 vuotta sitten
b87e3ba335
Update copyright for 2013
Change-Id: Idf38f5027a92166daf99039de75b759d47431de1
Reviewed-on: http://gerrit.dmdirc.com/2607
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
11 vuotta sitten
4edc853bbf
Desingleton PluginManager (and as a side-effect, ServerManager).
Depends-On: I72fe837b5ea2352ae0c695948336efcdd92c09c8
Change-Id: I4a3d9b78a5f80aab0330d0906e8c76d00813c97c
Reviewed-on: http://gerrit.dmdirc.com/2523
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 vuotta sitten
792f3cc7dc
Make main less static.
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
11 vuotta sitten
ab45825e88
De-singleton + unit test
Change-Id: Iadcf92d4390034828d005a9c9e92d9a8ba189c99
Depends-On: I17790a0e71a6c004a088a6eb51332293b23062a4
Reviewed-on: http://gerrit.dmdirc.com/2455
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
12 vuotta sitten
Chris Smith
0a6af6d64f
Remove/tidy some iffy tests
Change-Id: I79f722c55277f8b54221558af44e43e133f1daf7
Reviewed-on: http://gerrit.dmdirc.com/2445
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
cab5631bef
Stop components registering themselves in constructors
Change-Id: I00147e129abae032e1087766e60581f89378eb81
Reviewed-on: http://gerrit.dmdirc.com/2383
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
Chris Smith
5b1b627465
Remove CLIENT_STRING_STYLED as it's a bit weird, not used, and seems wasteful
Drop some ActionManager logging to trace
Change-Id: I271ced675771163dbeddbd91efeda638d73ff9b3
Reviewed-on: http://gerrit.dmdirc.com/2332
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
ac16253f43
Use slf4j not java logging
Sprinkle lombok and config binding around
Change-Id: Ie4daf4451ed7e252e033ebf3bc59f6a606523a82
Reviewed-on: http://gerrit.dmdirc.com/2331
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
12 vuotta sitten
d26602c9dc
Update Copyright for 2012
Change-Id: I0d40c3ac86b9e06fad3f29bc36612b4162e54d1c
Reviewed-on: http://gerrit.dmdirc.com/2287
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
5c64a29c45
Deprecations
Change-Id: I1aa33d6e360f6050b02b7fe3f7db1312451c93fb
Reviewed-on: http://gerrit.dmdirc.com/2282
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
Chris Smith
ebbd1daff5
Import fixing!
Change-Id: Ia90cb759b0777cf8d30eb6bfe30a5bece0105d24
Reviewed-on: http://gerrit.dmdirc.com/2281
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
d4507e0b3a
Deprecation fixes
Sprinkle some annotations over the CommandManager
More fiddling with NB7.1 settings
Change-Id: I2a0b751798249d4cc3e527f6d2e5525d1936f0e1
Reviewed-on: http://gerrit.dmdirc.com/2278
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
a7a57eca29
Fix fallout from util changes
Change-Id: I0bfd2dc61096dd9670b269463c27d9b00fd9a917
Depends-On: I6d0665e57f6e0e2ff2fb6a18742acb99010e79bf
Depends-On: Ia8de3c1a5fdc1eb9cfaa8b29a32bb3efb6d8ce6f
Reviewed-on: http://gerrit.dmdirc.com/2242
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
80871d51a7
Begin to remove deprecated IdentityManager methods
Change-Id: I7c24baa6f2e64302406e656a8931390aff9d3c9d
Depends-On: I1fc7086057871a9b5f5f6d0ec790ec28b7ee067f
Reviewed-on: http://gerrit.dmdirc.com/2203
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
12 vuotta sitten
Chris Smith
72b2a5a910
Initial work on an abstract colour representation.
Styliser still injects AWT Colors for simplicity at this stage.
Change-Id: I691b6dca615fd6a197712d9f11cedafdc9a8bc5d
Depends-On: I978e118b20c507cbc305d5ee5c6ecabf6d7454b8
Reviewed-on: http://gerrit.dmdirc.com/2187
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
12 vuotta sitten
60d9db2dcf
Centralised interfaces packages.
Depends-On: I862891efc407a64559788812ee039a9ec565a973
Change-Id: If624693f050e1aa9cf4cabcd5264518604eb8bcd
Reviewed-on: http://gerrit.dmdirc.com/2167
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 vuotta sitten
Chris Smith
2c8bd069af
Make things more interfacey
Change-Id: Ica2535149c0a4af21d4e4248f036b73ecdfd0101
Reviewed-on: http://gerrit.dmdirc.com/2164
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
0d64fe3e22
Actions tidying
- Extract interface for ActionManager
- Decouple ActionManager and IdentityManager a bit
- Remove unused ActionGroupValidator
Change-Id: Ic62778231933b99f26b2a2a9658b5bde06f18ad7
Reviewed-on: http://gerrit.dmdirc.com/2163
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
a838c5a15d
Remove some unused deprecated methods
Change-Id: I432e3356bbcf625c5ba5398c76f17df49594f71e
Reviewed-on: http://gerrit.dmdirc.com/2158
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
8465351131
Local variables must be final where appropriate. Yay.
Change-Id: I472c5dba1dd01c8cd37a58b314cebd60c4583857
Depends-On: Ied3a5a2d993bd74c04eaa357bcbef7218871f529
Reviewed-on: http://gerrit.dmdirc.com/2083
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Build Manager
13 vuotta sitten
Chris Smith
6a06e9abae
Get rid of @author tags
Change-Id: Ib8d0b8886b769777267f0b757faea00787c149f7
Reviewed-on: http://gerrit.dmdirc.com/2080
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
d04e2bea4f
Change header?
Change-Id: I635e0d111ed182713132145e4d5fb1654f776ec4
Reviewed-on: http://gerrit.dmdirc.com/2071
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
935c21ebf8
Remove windows from commands
Change-Id: I5b6e7e2ca81d114028fef6cac0d88498def62ea0
Depends-On: I895be099fa526e4e4b566e7178120b5d1ad0912c
Reviewed-on: http://gerrit.dmdirc.com/2011
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
Chris Smith
949770857a
Make CommandManager a singleton
CLIENT-84
Change-Id: I48182a9cd7c8f49612025ba208ae90d3bb19ee2b
Depends-On: Ib62d32dbfdadaf38930ceacf667ff533de047599
Reviewed-on: http://gerrit.dmdirc.com/1996
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
521daeca81
Initial work in action error persistence
Also remove deprecated methods
Change-Id: Id3d1e92c7db813911b4bf4f27b92d4eff92bdd41
Depends-On: Ib20eb804c786b157a33c6d0610e9151200371400
Reviewed-on: http://gerrit.dmdirc.com/1963
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
ef8a269d00
Make UIs responsible for their own selection handling.
This removes the core concept of an active window,
and as such the 'active' notification target has
been removed. Fixes CLIENT-214.
Change-Id: Ieddf71114e55e0d3e3b040751d21a5523d4438d4
Depends-On: I9a135fb48b197bb555f470d3052f2ebc9a0a426c
Reviewed-on: http://gerrit.dmdirc.com/1948
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
77b570a30f
Style fixes
Change-Id: If63e94dcf0aec9e9aa99e84f9962879fca46051f
Reviewed-on: http://gerrit.dmdirc.com/1931
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
f2018c541b
Remove trailing spaces
Change-Id: I9f382ab3d7b078fb759cbaca618bec5d21b8b5d9
Reviewed-on: http://gerrit.dmdirc.com/1919
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
198a1597cc
Rework FrameContainer/UI interaction
- FrameContainers are no longer parameterised
- Introduced notion of window "Components"
- Removed per-window interfaces - fixes CLIENT-218
Change-Id: Ieefbf2d1e157e3638dbe8fdedbd4f32642061329
Depends-On: Iecbb2941c99a3412dc2eb3b7f56fc584d2db483e
Reviewed-on: http://gerrit.dmdirc.com/1885
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
cc979023da
Deprecation/mass deletion
Depends-On: I65a4cbe48f772dc7e400d585b1bfab15521fdd12
Change-Id: Ib499b44b594fa6dd85ac65fba5b95f16beb23c48
Reviewed-on: http://gerrit.dmdirc.com/1872
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
13 vuotta sitten
acdd8268bc
Remove deprecations.
Depends-On: Ic938a7785a30477f47074e574ec8311723d803a9
Change-Id: I5ebf0bd52682cd0b1798d1b1b54353e5e65e793f
Reviewed-on: http://gerrit.dmdirc.com/1838
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
Chris Smith
8eb818807b
Deprecation and style fixes
Change-Id: I9b5c03d7a9800d067af232101ea05f338a05101b
Reviewed-on: http://gerrit.dmdirc.com/1788
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
6ea269d2a4
Make the ActionManager into a singleton
CLIENT-84
Change-Id: I3a874129485b94635edd932399a218347a209ea5
Reviewed-on: http://gerrit.dmdirc.com/1785
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
e089e1f295
Adds change listener for disable_action when new action is created via AED
Fixes issue CLIENT-160
Change-Id: I768e39cfd231302946443808e9d267ab391f6330
Reviewed-on: http://gerrit.dmdirc.com/1761
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Greg Holmes <greg@dmdirc.com >
13 vuotta sitten
Chris Smith
09536a7a1e
Fix action enable state saving
Actions no longer alternate between enabled and disabled every
time you try to save an enabled action.
Fixes CLIENT-159
Change-Id: Id6297ac92ae4f8eae2eeae1e269db4d7f65e2180
Reviewed-on: http://gerrit.dmdirc.com/1760
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
4f1a8af7c8
Fix untriggered actions stopping default behaviour
Fixes CLIENT-116
Change-Id: I38c2366b64e2ed3f32c074ccbf55aa4d5e6df549
Reviewed-on: http://gerrit.dmdirc.com/1755
Reviewed-by: Shane Mc Cormack <shane@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
68b0ed1d1f
Style fixes
Change-Id: I94a245fd1824ba6a5c8c32e66a45a0c9be806aa1
Reviewed-on: http://gerrit.dmdirc.com/1750
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
fd83b6b2a9
Update Copyright
Change-Id: I7f63fdd02ea0109fe31e55c44b078edae3862f32
Reviewed-on: http://gerrit.dmdirc.com/1726
Reviewed-by: Chris Smith <chris@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
a1c4dde046
Fix some PMD errors.
Change-Id: Ia8c864cc8abab3bfdcabeac30b41f6fb29233e73
Reviewed-on: http://gerrit.dmdirc.com/1689
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
6e881fd810
Add action and trigger it when plugin lists should be refreshed.
Issue CLIENT-134
Change-Id: Ib31c7b3e641d9771d937fe2665c819b0509b5276
Reviewed-on: http://gerrit.dmdirc.com/1682
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
Reviewed-by: Chris Smith <chris@dmdirc.com >
13 vuotta sitten
Chris Smith
1214640654
Core support for defining channel/server-specific prefs
Fixes CLIENT-85
Change-Id: I4cf493f58536b792de4de68b91f5c8f2541a90a0
Reviewed-on: http://gerrit.dmdirc.com/1596
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
33bae9d01d
Rename PreferencesManager to PreferencesDialogModel
Change-Id: Ied76e21fbf72039d47ec2b35b236149c13941645
Depends-On: Ia126a15b60e54c08c1e780676fe363821e9b7518
Reviewed-on: http://gerrit.dmdirc.com/1591
Reviewed-by: Greg Holmes <greg@dmdirc.com >
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com >
13 vuotta sitten
Chris Smith
10ad8f480d
Move validators out of config.prefs.validator
Fixes issue 4253
Change-Id: Ibb46a6a1ba5c62d525b65f55d39632b82e335539
Reviewed-on: http://gerrit.dmdirc.com/1455
Automatic-Compile: Gregory Holmes <greg@dmdirc.com >
Reviewed-by: Gregory Holmes <greg@dmdirc.com >
14 vuotta sitten
Chris Smith
Shane Mc Cormack