Where commands are executed globally, pass in a GlobalWindow.
Make the GlobalWindow a singleton that persists, and is simply
added/removed from the WindowManager when the user wants to
show/hide it.
Change-Id: Iac94848487442509bdbf8ec98f67983e313ed743
Reviewed-on: http://gerrit.dmdirc.com/3451
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Anywhere that doesn't just work with a Connection, cast back to a Server for
now. These can be tidied up later.
Change-Id: I02a54b0bcfaef08d5757cc015c356f9779ec0371
Depends-On: Id55c3611173be7ed79fae8f9e976996d713b8646
Reviewed-on: http://gerrit.dmdirc.com/2950
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
This allows them to be injected with all their dependencies, removing
some deprecated singleton methods or constructor usages.
Change-Id: Ie2960171e29fa4069747ca9a6cd8b427ffc73003
Depends-On: I06b391f62bf6e72b0f24d2dda91e36242564fdff
Reviewed-on: http://gerrit.dmdirc.com/2915
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Don't manually iterate servers and look up the global window,
instead just use the WindowManager to find writable root windows.
This also fixes a bug whereby aliases were never removed from
the global window.
Change-Id: I8e009e03b1d48646a01b683d20712fd042628349
Reviewed-on: http://gerrit.dmdirc.com/2834
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Pass in identity controller, action controller and their directory.
This means the tests can stub out most things.
Change-Id: Ia42c0b913654dcd9fd0d460fd2c8a0bd0a4976a3
Reviewed-on: http://gerrit.dmdirc.com/2787
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
This will make it easier to modify actions to have their
dependencies passed in, and be less generally horrible.
Change-Id: Iea79ea52732aec0fe430f16b31ae681e95474bce
Reviewed-on: http://gerrit.dmdirc.com/2784
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Rework how Logger/ErrorManager interact so they can be half
mocked out (or, at least, used in a thread-safe-ish manner).
Change-Id: Ia5899640bdc101793819dab88c3fe6038a759abb
Reviewed-on: http://gerrit.dmdirc.com/2695
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Instead, have Main provide the instance which becomes the
singleton. This allows us to inject dependencies to it, and
construct it using dagger later, while keeping all of the
code that calls the static getIdentityManager() method working.
Change-Id: I4ceaa062c84509bed66824f39cca8e76d25d131c
Reviewed-on: http://gerrit.dmdirc.com/2677
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Remove dependency on real ActionManager from test.
ActionComponentChain can be passed a simple mocked ActionManager,
instead of using a real ActionManager which requires half the
client to be initialised (via TestMain).
Change-Id: I294285d170e8facfa00e49683dd61068725d4f3e
Reviewed-on: http://gerrit.dmdirc.com/2657
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
This only exists to pass around global state, and is only used
by one plugin. It's nicer for now if that plugin just accesses
a singleton/static state directly until it can be injected,
rather than make lots of classes and tests depend on Main.
Change-Id: I8ed6e4c90b9c6bdbcaeb01fc276df5819cb47e1a
Depends-On: I4ec47f958b40eb0a03ab50d4a5611e00b0c83f39
Reviewed-on: http://gerrit.dmdirc.com/2656
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Don't ask Main for the config directory.
Remove getMain() from Main.
Everything that needs a main now either gets given it, or asks something else.
Unfortunately, a few more dependencies on the static IdentityManager.getIdentityManager()
were introduced, but they can be tackled separately.
Fix unit tests for the above.
Change-Id: I9e42ac7f74453b739209a681d0a31f50c1be2a04
Depends-On: Ib5a9fdea5a2e25d5471d0b849f4f65fa0286d1f8
Reviewed-on: http://gerrit.dmdirc.com/2520
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Squashed commit of the following:
commit 81c3cb41fe
Author: Chris Smith <chris@dmdirc.com>
Date: Sun Feb 28 21:13:03 2010 +0000
Fix a couple of escaping edge cases
Change-Id: I8cd9c3493a932039b7bae704c522f79778946d55
commit cde2d943dc
Author: Chris Smith <chris@dmdirc.com>
Date: Thu Feb 25 05:51:38 2010 +0000
Working actions substitutor replacement
Fixes issue 3804
Change-Id: Id714c47d599815461826f403942bfe490ac587ff
commit f450ce592a
Author: Chris Smith <chris@dmdirc.com>
Date: Thu Feb 25 00:01:55 2010 +0000
Support for config and server substitutions
Change-Id: I0b10332f340212d05ac478d4025ee557d2e66351
commit 4d2357a28f
Author: Chris Smith <chris@dmdirc.com>
Date: Tue Feb 23 21:41:54 2010 +0000
Implement word and component substitutions
Change-Id: I120f50e6eec3dc968beff42d79c0171a5908155e
commit 0bb9fbb970
Author: Chris Smith <chris@dmdirc.com>
Date: Mon Jan 25 21:32:00 2010 +0000
Unit test for actions substitutor
Change-Id: I4d8b2084f7b78cf2b30f0409e1a7fdfe5a9ee5aa
Reviewed-on: http://gerrit.dmdirc.com/927
Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
Reviewed-by: Gregory Holmes <greg@dmdirc.com>