Plugins shouldn't be required to have getters and setters for
something that's constant.
Change-Id: I99ebc7d10f558008a7889252cc3c96f39747303e
Reviewed-on: http://gerrit.dmdirc.com/2860
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Getting hold of a CommandController is annoying and fiddly,
so add a CommandHelper class to hide that away from plugins.
Allow registering of a command given just its class/info.
Change-Id: Ia208db1f23e3356d83a87ff2372e4f7aa49b24cc
Reviewed-on: http://gerrit.dmdirc.com/2854
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
plugins:
d42a901 Chris Smith <chris@dmdirc.com>
Add dagger dependency to plugins (again).
Keeping the compiler in the build group prevents it being put on
the classpath twice and causing massive problems.
Gerrit: http://gerrit.dmdirc.com/2850
Change-Id: Iee1cbf27061028b261b5211a88db55ced6d1f37d
plugins:
4252d6e Chris Smith <chris@dmdirc.com>
Support plugin changes.
Depends-On: I053a57b82f77e9f570efdc463f86dd6653355a3e
Gerrit: http://gerrit.dmdirc.com/2848
Change-Id: Ic5b06afa2dfd5a57fee1179506e38c5ce49d7ce7
We can't support multiple parents with the new DI framework,
and looking at the code it seems they never fully worked anyway.
Change-Id: I053a57b82f77e9f570efdc463f86dd6653355a3e
Depends-On: If8938f708244ed20d8d9e1c481ecb76bd2c0fac5
Reviewed-on: http://gerrit.dmdirc.com/2849
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
New dependency-injection supporting methods, and ample javadoc.
Stub the methods out in BasePlugin so everything carries on working.
Change-Id: Iaea88b091a4680c568f8e55a75a3b0d97c9842eb
Reviewed-on: http://gerrit.dmdirc.com/2846
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
- Don't have FrameContainers add themselves to the WindowManager in
the constructor.
- Don't make FrameContainers keep a reference to WindowManager just
to remove themselves when they're closed
- Instead have WindowManager register a FrameClosed listener and use
that to remove windows itself.
Change-Id: Iadbca8a28f7ef3372df7fda722a3cbba2a0fbad6
Depends-On: I0f60ac23438313cab49cdb86c089938f5ee44abc
Reviewed-on: http://gerrit.dmdirc.com/2842
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
plugins:
a831641 Chris Smith <chris@dmdirc.com>
Fix most getIconManager() calls.
Depends-On: Id672fec154a19c999b078b3980681937f62bfb41
Gerrit: http://gerrit.dmdirc.com/2841
Change-Id: I1401800b36851502253bdbd6a8e68591d3e15220
FrameContainer shouldn't be responsible for exposing a WindowManager,
and shouldn't keep an IconManager reference just to pass it on to
other classes.
Change-Id: Id672fec154a19c999b078b3980681937f62bfb41
Reviewed-on: http://gerrit.dmdirc.com/2840
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
parser:
53058f9 Shane Mc Cormack <shane@dmdirc.com>
Add missing null check to OutputQueue when changing the enabled state of the queue.
Gerrit: http://gerrit.dmdirc.com/2839
Change-Id: Id6affc978eb80bcc2f6eea04eac7eeef55856061
plugins:
87cd3e2 Chris Smith <chris@dmdirc.com>
Desingleton DccCommandParser.
Can't see why it was a singleton, really.
Gerrit: http://gerrit.dmdirc.com/2838
Change-Id: I853426b1b1f13d1032195f4bbccd971fad7f001c
Whoever creates windows should add them to the window manager
(which saves passing a 'focus' boolean into the constructor,
which is odd), and fire the relevant action event.
Change-Id: I97d143c5250df734fa3adca0c7da4d76a5c87e8b
Reviewed-on: http://gerrit.dmdirc.com/2833
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
This removes some static references and simplifies the
constructors of some of our model classes quite a bit.
Change-Id: Ic1644412a4956aa01b67e1129be47420c7a47b46
Reviewed-on: http://gerrit.dmdirc.com/2832
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Don't manually iterate servers and look up the global window,
instead just use the WindowManager to find writable root windows.
This also fixes a bug whereby aliases were never removed from
the global window.
Change-Id: I8e009e03b1d48646a01b683d20712fd042628349
Reviewed-on: http://gerrit.dmdirc.com/2834
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
parser:
c15082c Chris Smith <chris@dmdirc.com>
Make CHANTYPES handling somewhat sane.
Get rid of weird round-the-houses method of processing, and avoid
duplicating the value in a map and a field.
This fixes our handling of servers doing really stupid, theoretical
things like resetting the CHANTYPES they support. (And by "fixes"
I mean the parser will keep state, while everything else burns
around it.)
Gerrit: http://gerrit.dmdirc.com/2831
Change-Id: I292c11f05ce14b90d419537c1df496004be8a4df
Allows injection of the global ConfigManager instead of having
to get an IdentityManager and call getGlobalConfig...().
Change-Id: Ifa79919e201c418c99899ce5a0a815ac646e5a77
Reviewed-on: http://gerrit.dmdirc.com/2830
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Introduces a ConfigProviderMigrator interface, which allows
migration of a ConfigProvider. This allows the owner of
the provider to migrate it, and pass around an instance,
while prevent any other user accidentally migrating it.
e.g. Server can own a ConfigProviderMigrator, and only
expose the inner ConfigProvider, so noone else can migrate
it to a different target.
Change-Id: I2a78947f60ba42c6877433c897ef458cead6a3e3
Fixes-Issue: CLIENT-408
Reviewed-on: http://gerrit.dmdirc.com/2828
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Errors that happen before the IdentityManager is configured
are useful to be able to see.
Change-Id: Iad6c54182aa101528e8bb2169ed08249f650f39c
Reviewed-on: http://gerrit.dmdirc.com/2827
Reviewed-by: Greg Holmes <greg@dmdirc.com>
Automatic-Compile: DMDirc Build Manager
Remove the remaining WindowManager singleton refs.
Add a GlobalWindowManager to keep state and references, rather than
use static methods on GlobalWindow.
Minor tidying.
Change-Id: I65b84082f0a07cdc9e4c05263f6c5c77282e9b04
Reviewed-on: http://gerrit.dmdirc.com/2818
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
parser:
dac7f08 Chris Smith <chris@dmdirc.com>
Tidy up the 004/005 processor a bit.
Introduce methods for handling individual bits, instead of having
a pair of giant if statements of doom.
Tidy some comments and formatting up at the same time.
This is functionally the same as it was before.
Gerrit: http://gerrit.dmdirc.com/2812
Change-Id: If5d024870222097fe83f303fb85a201d87f9798e
Chris Smith
Git