If submodule.noupdate=true is defined in private.properties, then the user is responsible for updating submodules themselves rather than having it handled automatically.

Fix ant complaining about modules/plugins/lib not existing if it hasn't been checked out yet.

Change-Id: Iba429fcdee0d4b9e546101c1a28dffb32ffbb842
Reviewed-on: http://gerrit.dmdirc.com/325
Tested-by: Shane Mc Cormack <shane@dmdirc.com>
Reviewed-by: Gregory Holmes <greboid@dmdirc.com>
Tested-by: Gregory Holmes <greboid@dmdirc.com>

build.xml

@@ -12,7 +12,7 @@
     <import file="build-tests.xml"/>
     <import file="build-versioning.xml"/>
 
-    <target name="-submodules">
+    <target name="-submodules" unless="submodule.noupdate">
         <exec executable="git">
             <arg value="submodule"/>
             <arg value="init"/>

nbproject/build-impl.xml

@@ -34,6 +34,9 @@ is divided into following sections:
         <!-- You can override this target in the ../build.xml file. -->
     </target>
     <target depends="-pre-init" name="-init-private">
+        <!-- Try to set this property only after -pre-init has been called. -->
+        <property name="plugins.libs.path" value="${toString:plugins.libs}" />
+
         <property file="nbproject/private/config.properties"/>
         <property file="nbproject/private/configs/${config}.properties"/>
         <property file="nbproject/private/private.properties"/>
@@ -50,7 +53,7 @@ is divided into following sections:
         <property file="nbproject/project.properties"/>
         <!-- Echo this here to make it easy for people to copy/paste into
              private.properties. -->
-        <echo message="Found Libraries: ${toString:plugins.libs}" />
+        <echo message="Found Libraries: ${plugins.libs.path}" />
     </target>
     <target depends="-pre-init,-init-private,-init-user,-init-project,-init-macrodef-property" name="-do-init">
         <available file="${manifest.file}" property="manifest.available"/>

nbproject/project.properties

@@ -58,7 +58,7 @@ parser.test.dir=modules/parser/test
 plugins.test.dir=modules/plugins/test
 
 # Classpaths
-# ${toString:plugins.libs} generates at compile-time a string containing all
+# ${plugins.libs.path} generates at compile-time a string containing all
 # the plugin jars.
 # However netbeans fails miserably at understanding this in  the IDE, so we
 # have the private.classpath variable that can be defined by the user in
@@ -66,7 +66,7 @@ plugins.test.dir=modules/plugins/test
 # suckiness.
 # Without this parameter, everything will still compile, but netbeans won't
 # know about any files it isn't explicitly told about.
-javac.classpath=${private.classpath}:${toString:plugins.libs}
+javac.classpath=${private.classpath}:${plugins.libs.path}
 javac.test.classpath=\
     ${javac.classpath}:\
     ${build.classes.dir}:\