Browse Source

Merge pull request #175 from csmith/gradle-pmd

Fix some PMD errors.
pull/176/head
Greg Holmes 9 years ago
parent
commit
dd51745206

+ 1
- 1
src/com/dmdirc/commandparser/commands/global/SetCommand.java View File

315
             res.add("--server");
315
             res.add("--server");
316
             res.add("--channel");
316
             res.add("--channel");
317
             res.excludeAll();
317
             res.excludeAll();
318
-        } else if (arg == 1 && previousArgs.size() >= 1) {
318
+        } else if (arg == 1 && !previousArgs.isEmpty()) {
319
             if ("--unset".equalsIgnoreCase(previousArgs.get(0))
319
             if ("--unset".equalsIgnoreCase(previousArgs.get(0))
320
                     || "--append".equalsIgnoreCase(previousArgs.get(0))
320
                     || "--append".equalsIgnoreCase(previousArgs.get(0))
321
                     || "--server".equalsIgnoreCase(previousArgs.get(0))
321
                     || "--server".equalsIgnoreCase(previousArgs.get(0))

+ 3
- 3
src/com/dmdirc/ui/core/feedback/FeedbackSender.java View File

88
         try {
88
         try {
89
             final List<String> response = downloader.getPage(
89
             final List<String> response = downloader.getPage(
90
                     "https://feedback.dmdirc.com/dialog/", postData);
90
                     "https://feedback.dmdirc.com/dialog/", postData);
91
-            if (response.size() >= 1) {
92
-                return response.get(0);
93
-            } else {
91
+            if (response.isEmpty()) {
94
                 return "Feedback failure: Unknown response from the server.";
92
                 return "Feedback failure: Unknown response from the server.";
93
+            } else {
94
+                return response.get(0);
95
             }
95
             }
96
         } catch (IOException ex) {
96
         } catch (IOException ex) {
97
             return "Feedback failure: " + ex.getMessage();
97
             return "Feedback failure: " + ex.getMessage();

Loading…
Cancel
Save