Browse Source

Updates now store UpdateComponents.

Fixes "Unknown" being displayed on restart-requiring components
Fixes issue 1279

git-svn-id: http://svn.dmdirc.com/trunk@4134 00569f92-eb28-0410-84fd-f71c24880f
tags/0.6
Chris Smith 16 years ago
parent
commit
d4b0319535

+ 1
- 7
src/com/dmdirc/ui/swing/dialogs/updater/UpdateTableModel.java View File

@@ -152,13 +152,7 @@ public class UpdateTableModel extends AbstractTableModel implements UpdateListen
152 152
             case 0:
153 153
                 return enabled.get(updates.get(rowIndex));
154 154
             case 1:
155
-                if (UpdateChecker.findComponent(updates.get(rowIndex).
156
-                        getComponent()) == null) {
157
-                    return "Unknown";
158
-                } else {
159
-                    return UpdateChecker.findComponent(updates.get(rowIndex).
160
-                            getComponent());
161
-                }
155
+                return updates.get(rowIndex).getComponent();
162 156
             case 2:
163 157
                 return updates.get(rowIndex).getRemoteVersion();
164 158
             case 3:

+ 5
- 14
src/com/dmdirc/updater/Update.java View File

@@ -40,11 +40,7 @@ import java.util.List;
40 40
 public final class Update implements DownloadListener {
41 41
 
42 42
     /** Update component. */
43
-    private final String component;
44
-    /** Channel name. */
45
-    private final String channel;
46
-    /** Remote version number. */
47
-    private final String versionID;
43
+    private final UpdateComponent component;
48 44
     /** Remote version name. */
49 45
     private final String versionName;
50 46
     /** Update url. */
@@ -69,15 +65,11 @@ public final class Update implements DownloadListener {
69 65
         final String[] parts = updateInfo.split(" ");
70 66
 
71 67
         if (parts.length == 6) {
72
-            component = parts[1];
73
-            channel = parts[2];
74
-            versionID = parts[3];
68
+            component = UpdateChecker.findComponent(parts[1]);
75 69
             versionName = parts[4];
76 70
             url = parts[5];
77 71
         } else {
78 72
             component = null;
79
-            channel = null;
80
-            versionID = null;
81 73
             versionName = null;
82 74
             url = null;
83 75
 
@@ -92,7 +84,7 @@ public final class Update implements DownloadListener {
92 84
      *
93 85
      * @return The component of this update
94 86
      */
95
-    public String getComponent() {
87
+    public UpdateComponent getComponent() {
96 88
         return component;
97 89
     }
98 90
 
@@ -183,12 +175,11 @@ public final class Update implements DownloadListener {
183 175
                 setStatus(UpdateStatus.INSTALLING);
184 176
 
185 177
                 try {
186
-                    final boolean restart = UpdateChecker.findComponent(getComponent())
187
-                            .doInstall(path);
178
+                    final boolean restart = getComponent().doInstall(path);
188 179
 
189 180
                     if (restart) {
190 181
                         setStatus(UpdateStatus.RESTART_NEEDED);
191
-                        UpdateChecker.removeComponent(getComponent());
182
+                        UpdateChecker.removeComponent(getComponent().getName());
192 183
                     } else {
193 184
                         setStatus(UpdateStatus.INSTALLED);
194 185
                     }

Loading…
Cancel
Save