소스 검색

Remove some statusbar manager uses.

pull/97/head
Greg Holmes 9 년 전
부모
커밋
bc39d2c3af
4개의 변경된 파일17개의 추가작업 그리고 27개의 파일을 삭제
  1. 4
    9
      src/com/dmdirc/Server.java
  2. 4
    8
      src/com/dmdirc/ServerFactoryImpl.java
  3. 9
    7
      src/com/dmdirc/messages/StatusBarMessageSink.java
  4. 0
    3
      test/com/dmdirc/ServerTest.java

+ 4
- 9
src/com/dmdirc/Server.java 파일 보기

@@ -32,6 +32,7 @@ import com.dmdirc.events.ServerConnectingEvent;
32 32
 import com.dmdirc.events.ServerDisconnectedEvent;
33 33
 import com.dmdirc.events.ServerNopingEvent;
34 34
 import com.dmdirc.events.ServerNumericEvent;
35
+import com.dmdirc.events.StatusBarMessageEvent;
35 36
 import com.dmdirc.interfaces.AwayStateListener;
36 37
 import com.dmdirc.interfaces.Connection;
37 38
 import com.dmdirc.interfaces.InviteListener;
@@ -59,7 +60,6 @@ import com.dmdirc.tls.CertificateManager;
59 60
 import com.dmdirc.tls.CertificateProblemListener;
60 61
 import com.dmdirc.ui.StatusMessage;
61 62
 import com.dmdirc.ui.WindowManager;
62
-import com.dmdirc.ui.core.components.StatusBarManager;
63 63
 import com.dmdirc.ui.core.components.WindowComponent;
64 64
 import com.dmdirc.ui.input.TabCompleterFactory;
65 65
 import com.dmdirc.ui.input.TabCompletionType;
@@ -177,8 +177,6 @@ public class Server extends FrameContainer implements ConfigChangeListener,
177 177
     private final RawFactory rawFactory;
178 178
     /** The config provider to write user settings to. */
179 179
     private final ConfigProvider userSettings;
180
-    /** The manager to use to add status bar messages. */
181
-    private final StatusBarManager statusBarManager;
182 180
     /** Executor service to use to schedule repeated events. */
183 181
     private final ScheduledExecutorService executorService;
184 182
     /** The message encoder factory to create a message encoder with. */
@@ -200,7 +198,6 @@ public class Server extends FrameContainer implements ConfigChangeListener,
200 198
      * @param tabCompleterFactory   The factory to use for tab completers.
201 199
      * @param identityFactory       The factory to use to create identities.
202 200
      * @param messageSinkManager    The sink manager to use to dispatch messages.
203
-     * @param statusBarManager      The manager to use to add status bar messages.
204 201
      * @param windowManager         Window Manager
205 202
      * @param channelFactory        The factory to use to create channels.
206 203
      * @param queryFactory          The factory to use to create queries.
@@ -221,7 +218,6 @@ public class Server extends FrameContainer implements ConfigChangeListener,
221 218
             final TabCompleterFactory tabCompleterFactory,
222 219
             final IdentityFactory identityFactory,
223 220
             final MessageSinkManager messageSinkManager,
224
-            final StatusBarManager statusBarManager,
225 221
             final WindowManager windowManager,
226 222
             final ChannelFactory channelFactory,
227 223
             final QueryFactory queryFactory,
@@ -260,7 +256,6 @@ public class Server extends FrameContainer implements ConfigChangeListener,
260 256
         this.rawFactory = rawFactory;
261 257
         this.executorService = executorService;
262 258
         this.userSettings = userSettings;
263
-        this.statusBarManager = statusBarManager;
264 259
         this.messageEncoderFactory = messageEncoderFactory;
265 260
 
266 261
         eventHandler = new ServerEventHandler(this, eventBus);
@@ -1326,10 +1321,10 @@ public class Server extends FrameContainer implements ConfigChangeListener,
1326 1321
      * Called when we fail to receive a ping reply within a set period of time.
1327 1322
      */
1328 1323
     public void onPingFailed() {
1329
-        statusBarManager.setMessage(new StatusMessage(
1324
+        getEventBus().publishAsync(new StatusBarMessageEvent(new StatusMessage(
1330 1325
                 "No ping reply from " + getName() + " for over "
1331
-                + (int) Math.floor(parser.getPingTime() / 1000.0)
1332
-                + " seconds.", getConfigManager()));
1326
+                        + (int) Math.floor(parser.getPingTime() / 1000.0)
1327
+                        + " seconds.", getConfigManager())));
1333 1328
 
1334 1329
         getEventBus().publishAsync(new ServerNopingEvent(this, parser.getPingTime()));
1335 1330
 

+ 4
- 8
src/com/dmdirc/ServerFactoryImpl.java 파일 보기

@@ -28,7 +28,6 @@ import com.dmdirc.interfaces.config.ConfigProviderMigrator;
28 28
 import com.dmdirc.interfaces.config.IdentityFactory;
29 29
 import com.dmdirc.messages.MessageSinkManager;
30 30
 import com.dmdirc.ui.WindowManager;
31
-import com.dmdirc.ui.core.components.StatusBarManager;
32 31
 import com.dmdirc.ui.input.TabCompleterFactory;
33 32
 import com.dmdirc.ui.messages.ColourManagerFactory;
34 33
 import com.dmdirc.util.URLBuilder;
@@ -51,7 +50,6 @@ public class ServerFactoryImpl {
51 50
     private final TabCompleterFactory tabCompleterFactory;
52 51
     private final IdentityFactory identityFactory;
53 52
     private final MessageSinkManager messageSinkManager;
54
-    private final StatusBarManager statusBarManager;
55 53
     private final WindowManager windowManager;
56 54
     private final Provider<ChannelFactory> channelFactory;
57 55
     private final Provider<QueryFactory> queryFactory;
@@ -69,7 +67,6 @@ public class ServerFactoryImpl {
69 67
             final TabCompleterFactory tabCompleterFactory,
70 68
             final IdentityFactory identityFactory,
71 69
             final MessageSinkManager messageSinkManager,
72
-            final StatusBarManager statusBarManager,
73 70
             final WindowManager windowManager,
74 71
             final Provider<ChannelFactory> channelFactory,
75 72
             final Provider<QueryFactory> queryFactory,
@@ -84,7 +81,6 @@ public class ServerFactoryImpl {
84 81
         this.tabCompleterFactory = tabCompleterFactory;
85 82
         this.identityFactory = identityFactory;
86 83
         this.messageSinkManager = messageSinkManager;
87
-        this.statusBarManager = statusBarManager;
88 84
         this.windowManager = windowManager;
89 85
         this.channelFactory = channelFactory;
90 86
         this.queryFactory = queryFactory;
@@ -103,9 +99,9 @@ public class ServerFactoryImpl {
103 99
             final URI uri,
104 100
             final ConfigProvider profile) {
105 101
         return new Server(manager.get(), configMigrator, commandParser, parserFactory,
106
-                tabCompleterFactory, identityFactory, messageSinkManager, statusBarManager,
107
-                windowManager, channelFactory.get(), queryFactory.get(), rawFactory.get(),
108
-                urlBuilder, eventBus, messageEncoderFactory, userSettings, executorService, uri,
109
-                profile, colourManagerFactory);
102
+                tabCompleterFactory, identityFactory, messageSinkManager, windowManager,
103
+                channelFactory.get(), queryFactory.get(), rawFactory.get(),urlBuilder, eventBus,
104
+                messageEncoderFactory, userSettings, executorService, uri, profile,
105
+                colourManagerFactory);
110 106
     }
111 107
 }

+ 9
- 7
src/com/dmdirc/messages/StatusBarMessageSink.java 파일 보기

@@ -22,9 +22,10 @@
22 22
 
23 23
 package com.dmdirc.messages;
24 24
 
25
+import com.dmdirc.DMDircMBassador;
25 26
 import com.dmdirc.FrameContainer;
27
+import com.dmdirc.events.StatusBarMessageEvent;
26 28
 import com.dmdirc.ui.StatusMessage;
27
-import com.dmdirc.ui.core.components.StatusBarManager;
28 29
 import com.dmdirc.ui.messages.Formatter;
29 30
 
30 31
 import java.util.Date;
@@ -39,17 +40,17 @@ public class StatusBarMessageSink implements MessageSink {
39 40
 
40 41
     /** The pattern to use to match this sink. */
41 42
     private static final Pattern PATTERN = Pattern.compile("statusbar");
42
-    /** The status bar manager to add messages to. */
43
-    private final StatusBarManager statusBarManager;
43
+    /** The event bus to post status messages to. */
44
+    private final DMDircMBassador eventBus;
44 45
 
45 46
     /**
46 47
      * Creates a new instance of {@link StatusBarMessageSink}.
47 48
      *
48
-     * @param statusBarManager The status bar manager to add messages to.
49
+     * @param eventBus The event bus to post status messages to
49 50
      */
50 51
     @Inject
51
-    public StatusBarMessageSink(final StatusBarManager statusBarManager) {
52
-        this.statusBarManager = statusBarManager;
52
+    public StatusBarMessageSink(final DMDircMBassador eventBus) {
53
+        this.eventBus = eventBus;
53 54
     }
54 55
 
55 56
     @Override
@@ -64,7 +65,8 @@ public class StatusBarMessageSink implements MessageSink {
64 65
             final String messageType, final Object... args) {
65 66
         final String message = Formatter.formatMessage(source.getConfigManager(),
66 67
                 messageType, args);
67
-        statusBarManager.setMessage(new StatusMessage(message, source.getConfigManager()));
68
+        eventBus.publishAsync(new StatusBarMessageEvent(new StatusMessage(message,
69
+                source.getConfigManager())));
68 70
     }
69 71
 
70 72
 }

+ 0
- 3
test/com/dmdirc/ServerTest.java 파일 보기

@@ -30,7 +30,6 @@ import com.dmdirc.interfaces.config.ConfigProviderMigrator;
30 30
 import com.dmdirc.interfaces.config.IdentityFactory;
31 31
 import com.dmdirc.messages.MessageSinkManager;
32 32
 import com.dmdirc.ui.WindowManager;
33
-import com.dmdirc.ui.core.components.StatusBarManager;
34 33
 import com.dmdirc.ui.input.TabCompleter;
35 34
 import com.dmdirc.ui.input.TabCompleterFactory;
36 35
 import com.dmdirc.ui.messages.ColourManagerFactory;
@@ -67,7 +66,6 @@ public class ServerTest {
67 66
     @Mock private ChannelFactory channelFactory;
68 67
     @Mock private QueryFactory queryFactory;
69 68
     @Mock private RawFactory rawFactory;
70
-    @Mock private StatusBarManager statusBarManager;
71 69
     @Mock private URLBuilder urlBuilder;
72 70
     @Mock private DMDircMBassador eventBus;
73 71
     @Mock private ScheduledExecutorService executorService;
@@ -92,7 +90,6 @@ public class ServerTest {
92 90
                 tabCompleterFactory,
93 91
                 identityFactory,
94 92
                 messageSinkManager,
95
-                statusBarManager,
96 93
                 windowManager,
97 94
                 channelFactory,
98 95
                 queryFactory,

Loading…
취소
저장