Browse Source

Die, TestMain, die.

It's been horrible knowing you.

Change-Id: Icd8eaeb9c4e481013dfbfa34757455f8d9e852f8
Reviewed-on: http://gerrit.dmdirc.com/2788
Automatic-Compile: DMDirc Build Manager
Reviewed-by: Greg Holmes <greg@dmdirc.com>
tags/0.8rc1
Chris Smith 10 years ago
parent
commit
ae888ef208

+ 17
- 10
src/com/dmdirc/ui/messages/Styliser.java View File

143
     private final Server server;
143
     private final Server server;
144
     /** Config manager to retrieve settings from. */
144
     /** Config manager to retrieve settings from. */
145
     private final AggregateConfigProvider configManager;
145
     private final AggregateConfigProvider configManager;
146
+    /** Colour manager to use to parse colours. */
147
+    private final ColourManager colourManager;
146
 
148
 
147
     /**
149
     /**
148
      * Creates a new instance of Styliser.
150
      * Creates a new instance of Styliser.
164
         this.server = server;
166
         this.server = server;
165
         this.configManager = configManager;
167
         this.configManager = configManager;
166
 
168
 
169
+        // TODO: This should probably be passed in, not created here.
170
+        this.colourManager = new ColourManager(configManager);
171
+
167
         configManager.addChangeListener("ui", "linkcolour", this);
172
         configManager.addChangeListener("ui", "linkcolour", this);
168
         configManager.addChangeListener("ui", "channelcolour", this);
173
         configManager.addChangeListener("ui", "channelcolour", this);
169
         configManager.addChangeListener("ui", "stylelinks", this);
174
         configManager.addChangeListener("ui", "stylelinks", this);
824
      * @param attribs The attribute set to modify
829
      * @param attribs The attribute set to modify
825
      * @param foreground The colour code/hex of the new foreground colour
830
      * @param foreground The colour code/hex of the new foreground colour
826
      */
831
      */
827
-    private static void setForeground(final SimpleAttributeSet attribs,
832
+    private void setForeground(final SimpleAttributeSet attribs,
828
             final String foreground) {
833
             final String foreground) {
829
         if (attribs.isDefined(StyleConstants.Foreground)) {
834
         if (attribs.isDefined(StyleConstants.Foreground)) {
830
             attribs.removeAttribute(StyleConstants.Foreground);
835
             attribs.removeAttribute(StyleConstants.Foreground);
831
         }
836
         }
832
-        attribs.addAttribute(StyleConstants.Foreground, convertColour(ColourManager.parseColour(foreground)));
837
+        attribs.addAttribute(StyleConstants.Foreground,
838
+                convertColour(colourManager.getColourFromString(foreground, Colour.WHITE)));
833
     }
839
     }
834
 
840
 
835
     /**
841
     /**
838
      * @param attribs The attribute set to modify
844
      * @param attribs The attribute set to modify
839
      * @param background The colour code/hex of the new background colour
845
      * @param background The colour code/hex of the new background colour
840
      */
846
      */
841
-    private static void setBackground(final SimpleAttributeSet attribs,
847
+    private void setBackground(final SimpleAttributeSet attribs,
842
             final String background) {
848
             final String background) {
843
         if (attribs.isDefined(StyleConstants.Background)) {
849
         if (attribs.isDefined(StyleConstants.Background)) {
844
             attribs.removeAttribute(StyleConstants.Background);
850
             attribs.removeAttribute(StyleConstants.Background);
845
         }
851
         }
846
-        attribs.addAttribute(StyleConstants.Background, convertColour(ColourManager.parseColour(background)));
852
+        attribs.addAttribute(StyleConstants.Background,
853
+                convertColour(colourManager.getColourFromString(background, Colour.WHITE)));
847
     }
854
     }
848
 
855
 
849
     /**
856
     /**
851
      * @param attribs The attribute set to apply this default on
858
      * @param attribs The attribute set to apply this default on
852
      * @param foreground The default foreground colour
859
      * @param foreground The default foreground colour
853
      */
860
      */
854
-    private static void setDefaultForeground(final SimpleAttributeSet attribs,
855
-            final String foreground) {
856
-        attribs.addAttribute("DefaultForeground", convertColour(ColourManager.parseColour(foreground)));
861
+    private void setDefaultForeground(final SimpleAttributeSet attribs, final String foreground) {
862
+        attribs.addAttribute("DefaultForeground",
863
+                convertColour(colourManager.getColourFromString(foreground, Colour.WHITE)));
857
     }
864
     }
858
 
865
 
859
     /**
866
     /**
861
      * @param attribs The attribute set to apply this default on
868
      * @param attribs The attribute set to apply this default on
862
      * @param background The default background colour
869
      * @param background The default background colour
863
      */
870
      */
864
-    private static void setDefaultBackground(final SimpleAttributeSet attribs,
865
-            final String background) {
866
-        attribs.addAttribute("DefaultBackground", convertColour(ColourManager.parseColour(background)));
871
+    private void setDefaultBackground(final SimpleAttributeSet attribs, final String background) {
872
+        attribs.addAttribute("DefaultBackground",
873
+                convertColour(colourManager.getColourFromString(background, Colour.WHITE)));
867
     }
874
     }
868
 
875
 
869
     /** {@inheritDoc} */
876
     /** {@inheritDoc} */

+ 0
- 144
test/com/dmdirc/TestMain.java View File

1
-package com.dmdirc;
2
-
3
-import com.dmdirc.actions.ActionFactory;
4
-import com.dmdirc.actions.ActionGroup;
5
-import com.dmdirc.actions.ActionManager;
6
-import com.dmdirc.commandline.CommandLineParser;
7
-import com.dmdirc.commandparser.CommandManager;
8
-import com.dmdirc.config.IdentityManager;
9
-import com.dmdirc.config.InvalidIdentityFileException;
10
-import com.dmdirc.interfaces.ActionController;
11
-import com.dmdirc.interfaces.CommandController.CommandDetails;
12
-import com.dmdirc.interfaces.config.IdentityController;
13
-import com.dmdirc.plugins.PluginManager;
14
-import com.dmdirc.updater.manager.UpdateManager;
15
-import com.dmdirc.util.URLBuilder;
16
-
17
-import java.io.File;
18
-import java.io.IOException;
19
-import java.util.Collections;
20
-
21
-import javax.inject.Provider;
22
-import static org.mockito.Mockito.*;
23
-
24
-/**
25
- * Main subclass to init things needed for testing.
26
- *
27
- * @deprecated Tests shouldn't need the entire universe created.
28
- */
29
-@Deprecated
30
-public class TestMain extends Main {
31
-
32
-    private static Main instance;
33
-
34
-    private final IdentityManager identityManager;
35
-    private final PluginManager pluginManager;
36
-    private final CommandManager commandManager;
37
-
38
-    public TestMain(final IdentityManager identityManager,
39
-            final ServerManager serverManager,
40
-            final ActionManager actionManager,
41
-            final CommandLineParser commandLineParser,
42
-            final PluginManager pluginManager,
43
-            final CommandManager commandManager,
44
-            final CorePluginExtractor corePluginExtractor) {
45
-        super(identityManager, serverManager, actionManager, commandLineParser,
46
-                pluginManager, commandManager, null, null, corePluginExtractor,
47
-                mock(URLBuilder.class), Collections.<CommandDetails>emptySet());
48
-        this.identityManager = identityManager;
49
-        this.pluginManager = pluginManager;
50
-        this.commandManager = commandManager;
51
-    }
52
-
53
-    /** {@inheritDoc} */
54
-    @Override
55
-    public void init() {
56
-        try {
57
-            identityManager.initialise();
58
-        } catch (InvalidIdentityFileException ex) {
59
-            // If a bad config dir exists, try to continue anyway, maybe the
60
-            // test doesn't need it.
61
-            // DON'T do anything to the user's configuration... (so no calls
62
-            // to handleInvalidConfigFile(); here)
63
-        }
64
-
65
-        pluginManager.refreshPlugins();
66
-        commandManager.initialise(identityManager.getGlobalConfiguration());
67
-        CommandManager.setCommandManager(commandManager);
68
-
69
-        ActionManager.getActionManager().initialise();
70
-    }
71
-
72
-    /**
73
-     * Singleton method for convenience so that we don't need to init a billion
74
-     * TestMain instances to run tests.
75
-     *
76
-     * Separate instances of TestMain are available, but probably pointless as
77
-     * long as IdentityManager, PluginManager and ConfigManater are still
78
-     * singletons.
79
-     *
80
-     * @return A Singleton instance of TestMain
81
-     */
82
-    public static Main getTestMain() {
83
-        if (instance == null) {
84
-            try {
85
-                File tempFile = File.createTempFile("dmdirc", "test");
86
-                tempFile.delete();
87
-                tempFile.mkdir();
88
-                tempFile.deleteOnExit();
89
-
90
-                final String configDirectory = tempFile.getAbsolutePath() + File.separator;
91
-                final String pluginDirectory = configDirectory + "plugins" + File.separator;
92
-                final String actionsDirectory = configDirectory + "actions" + File.separator;
93
-
94
-                // TODO: Tests probably shouldn't rely on a config dir... Who knows
95
-                //       what the user has done with their config.
96
-                final IdentityManager identityManager = new IdentityManager(configDirectory);
97
-                IdentityManager.setIdentityManager(identityManager);
98
-                IdentityManager.getIdentityManager().loadVersionIdentity();
99
-
100
-                final ServerManager serverManager = mock(ServerManager.class);
101
-                final CommandManager commandManager = new CommandManager(serverManager);
102
-
103
-                final ActionFactory actionFactory = new ActionFactory(
104
-                        new DummyProvider<>(mock(ActionController.class)),
105
-                        new DummyProvider<IdentityController>(identityManager),
106
-                        actionsDirectory);
107
-                final ActionManager actionManager = new ActionManager(
108
-                        serverManager, identityManager, actionFactory,
109
-                        new DummyProvider<>(Collections.<ActionGroup>emptySet()));
110
-                ActionManager.setActionManager(actionManager);
111
-
112
-                final PluginManager pluginManager = new PluginManager(
113
-                        identityManager, actionManager,
114
-                        mock(UpdateManager.class),
115
-                        mock(Provider.class),
116
-                        pluginDirectory);
117
-                final CorePluginExtractor corePluginExtractor =
118
-                        new CorePluginExtractor(pluginManager, pluginDirectory);
119
-
120
-                instance = new TestMain(identityManager, serverManager,
121
-                        actionManager, null, pluginManager, commandManager,
122
-                        corePluginExtractor);
123
-                instance.init();
124
-            } catch (IOException ex) {
125
-                // Blargh.
126
-            }
127
-        }
128
-        return instance;
129
-    }
130
-
131
-    private static class DummyProvider<T> implements Provider<T> {
132
-
133
-        private final T value;
134
-
135
-        public DummyProvider(T value) {
136
-            this.value = value;
137
-        }
138
-
139
-        @Override
140
-        public T get() {
141
-            return value;
142
-        }
143
-    }
144
-}

+ 0
- 1
test/com/dmdirc/commandparser/commands/channel/SetNickColourTest.java View File

21
  */
21
  */
22
 package com.dmdirc.commandparser.commands.channel;
22
 package com.dmdirc.commandparser.commands.channel;
23
 
23
 
24
-import com.dmdirc.TestMain;
25
 import com.dmdirc.Channel;
24
 import com.dmdirc.Channel;
26
 import com.dmdirc.FrameContainer;
25
 import com.dmdirc.FrameContainer;
27
 import com.dmdirc.commandparser.CommandArguments;
26
 import com.dmdirc.commandparser.CommandArguments;

+ 0
- 8
test/com/dmdirc/ui/messages/IntelligentLinkingTest.java View File

23
 
23
 
24
 import com.dmdirc.FrameContainer;
24
 import com.dmdirc.FrameContainer;
25
 import com.dmdirc.Server;
25
 import com.dmdirc.Server;
26
-import com.dmdirc.TestMain;
27
-import com.dmdirc.config.InvalidIdentityFileException;
28
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
26
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
29
 
27
 
30
 import java.util.Arrays;
28
 import java.util.Arrays;
31
 import java.util.List;
29
 import java.util.List;
32
 
30
 
33
-import org.junit.BeforeClass;
34
 import org.junit.Test;
31
 import org.junit.Test;
35
 import org.junit.runner.RunWith;
32
 import org.junit.runner.RunWith;
36
 import org.junit.runners.Parameterized;
33
 import org.junit.runners.Parameterized;
58
         styliser = new Styliser(container);
55
         styliser = new Styliser(container);
59
     }
56
     }
60
 
57
 
61
-    @BeforeClass
62
-    public static void setUp() throws InvalidIdentityFileException {
63
-        TestMain.getTestMain();
64
-    }
65
-
66
     @Test
58
     @Test
67
     public void testLink() throws InterruptedException {
59
     public void testLink() throws InterruptedException {
68
         assertEquals(expected, styliser.doLinks(input)
60
         assertEquals(expected, styliser.doLinks(input)

+ 0
- 8
test/com/dmdirc/ui/messages/StyliserStylesTest.java View File

23
 package com.dmdirc.ui.messages;
23
 package com.dmdirc.ui.messages;
24
 
24
 
25
 import com.dmdirc.FrameContainer;
25
 import com.dmdirc.FrameContainer;
26
-import com.dmdirc.TestMain;
27
-import com.dmdirc.config.InvalidIdentityFileException;
28
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
26
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
29
 import com.dmdirc.ui.core.util.Utils;
27
 import com.dmdirc.ui.core.util.Utils;
30
 
28
 
37
 
35
 
38
 import javax.swing.text.DefaultStyledDocument;
36
 import javax.swing.text.DefaultStyledDocument;
39
 
37
 
40
-import org.junit.BeforeClass;
41
 import org.junit.Ignore;
38
 import org.junit.Ignore;
42
 import org.junit.Test;
39
 import org.junit.Test;
43
 import org.junit.runner.RunWith;
40
 import org.junit.runner.RunWith;
57
         this.output = output;
54
         this.output = output;
58
     }
55
     }
59
 
56
 
60
-    @BeforeClass
61
-    public static void setUp() throws InvalidIdentityFileException {
62
-        TestMain.getTestMain();
63
-    }
64
-
65
     @Test
57
     @Test
66
     public void testStyle() {
58
     public void testStyle() {
67
         assertEquals(output, style(input));
59
         assertEquals(output, style(input));

+ 0
- 8
test/com/dmdirc/ui/messages/StyliserTest.java View File

23
 package com.dmdirc.ui.messages;
23
 package com.dmdirc.ui.messages;
24
 
24
 
25
 import com.dmdirc.FrameContainer;
25
 import com.dmdirc.FrameContainer;
26
-import com.dmdirc.TestMain;
27
-import com.dmdirc.config.InvalidIdentityFileException;
28
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
26
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
29
 
27
 
30
 import java.util.Enumeration;
28
 import java.util.Enumeration;
31
 
29
 
32
-import org.junit.Before;
33
 import org.junit.Ignore;
30
 import org.junit.Ignore;
34
 import org.junit.Test;
31
 import org.junit.Test;
35
 
32
 
38
 
35
 
39
 public class StyliserTest {
36
 public class StyliserTest {
40
 
37
 
41
-    @Before
42
-    public void setUp() throws InvalidIdentityFileException {
43
-        TestMain.getTestMain();
44
-    }
45
-
46
     @Test
38
     @Test
47
     public void testStripControlCodes1() {
39
     public void testStripControlCodes1() {
48
         String input = "This"+((char) 2)+" is "+((char) 17)+"a test";
40
         String input = "This"+((char) 2)+" is "+((char) 17)+"a test";

Loading…
Cancel
Save