Bläddra i källkod

Some reports fixes.

git-svn-id: http://svn.dmdirc.com/trunk@1772 00569f92-eb28-0410-84fd-f71c24880f
tags/0.5
Gregory Holmes 17 år sedan
förälder
incheckning
ada2970b30
29 ändrade filer med 107 tillägg och 66 borttagningar
  1. 1
    1
      src/com/dmdirc/commandparser/commands/global/Ifplugin.java
  2. 5
    1
      src/com/dmdirc/logger/DMDircExceptionHandler.java
  3. 1
    1
      src/com/dmdirc/ui/input/InputHandler.java
  4. 1
    0
      src/com/dmdirc/ui/interfaces/ChannelWindow.java
  5. 0
    1
      src/com/dmdirc/ui/interfaces/PreferencesPanel.java
  6. 1
    0
      src/com/dmdirc/ui/interfaces/StatusBar.java
  7. 2
    1
      src/com/dmdirc/ui/interfaces/UIController.java
  8. 1
    1
      src/com/dmdirc/ui/interfaces/UpdaterDialog.java
  9. 2
    2
      src/com/dmdirc/ui/swing/ChannelFrame.java
  10. 1
    1
      src/com/dmdirc/ui/swing/CustomInputFrame.java
  11. 4
    4
      src/com/dmdirc/ui/swing/MainFrame.java
  12. 1
    1
      src/com/dmdirc/ui/swing/QueryFrame.java
  13. 2
    2
      src/com/dmdirc/ui/swing/ServerFrame.java
  14. 13
    6
      src/com/dmdirc/ui/swing/SwingController.java
  15. 3
    3
      src/com/dmdirc/ui/swing/components/InputFrame.java
  16. 2
    2
      src/com/dmdirc/ui/swing/components/SwingStatusBar.java
  17. 34
    14
      src/com/dmdirc/ui/swing/components/reorderablelist/ArrayListTransferHandler.java
  18. 11
    3
      src/com/dmdirc/ui/swing/components/reorderablelist/ArrayListTransferable.java
  19. 6
    4
      src/com/dmdirc/ui/swing/components/reorderablelist/ReorderableJList.java
  20. 2
    1
      src/com/dmdirc/ui/swing/components/reorderablelist/ReorderableJListCellRenderer.java
  21. 1
    2
      src/com/dmdirc/ui/swing/dialogs/NewServerDialog.java
  22. 0
    1
      src/com/dmdirc/ui/swing/dialogs/PasteDialog.java
  23. 2
    2
      src/com/dmdirc/ui/swing/dialogs/SwingUpdaterDialog.java
  24. 3
    4
      src/com/dmdirc/ui/swing/dialogs/firstrunwizard/SwingFirstRunWizard.java
  25. 1
    1
      src/com/dmdirc/ui/swing/framemanager/MainFrameManager.java
  26. 1
    1
      src/com/dmdirc/ui/swing/framemanager/buttonbar/ButtonBar.java
  27. 1
    2
      src/com/dmdirc/ui/swing/framemanager/windowmenu/WindowMenuFrameManager.java
  28. 4
    4
      src/com/dmdirc/ui/swing/textpane/TextPane.java
  29. 1
    0
      src/com/dmdirc/ui/swing/textpane/TextPaneCanvas.java

+ 1
- 1
src/com/dmdirc/commandparser/commands/global/Ifplugin.java Visa fil

@@ -75,7 +75,7 @@ public final class Ifplugin extends GlobalCommand implements IntelligentCommand
75 75
         
76 76
         if (result != negative) {
77 77
             if (origin == null) {
78
-                GlobalCommandParser.getGlobalCommandParser().parseCommand(origin, implodeArgs(1, args));
78
+                GlobalCommandParser.getGlobalCommandParser().parseCommand(null, implodeArgs(1, args));
79 79
             } else {
80 80
                 origin.getCommandParser().parseCommand(origin, implodeArgs(1, args));
81 81
             }

+ 5
- 1
src/com/dmdirc/logger/DMDircExceptionHandler.java Visa fil

@@ -22,13 +22,17 @@
22 22
 
23 23
 package com.dmdirc.logger;
24 24
 
25
-public class DMDircExceptionHandler implements Thread.UncaughtExceptionHandler {
25
+/**
26
+ * Passes uncaught exceptions to the logger.
27
+ */
28
+public final class DMDircExceptionHandler implements Thread.UncaughtExceptionHandler {
26 29
     
27 30
     /** Instantiates the Exception handler. */
28 31
     public DMDircExceptionHandler() {
29 32
         super();
30 33
     }
31 34
     
35
+    /** {@inheritDoc} */
32 36
     public void uncaughtException(final Thread thread, final Throwable throwable) {
33 37
         Logger.appError(ErrorLevel.HIGH, "Uncaught exception", throwable);
34 38
     }

+ 1
- 1
src/com/dmdirc/ui/input/InputHandler.java Visa fil

@@ -29,9 +29,9 @@ import com.dmdirc.commandparser.Command;
29 29
 import com.dmdirc.commandparser.CommandManager;
30 30
 import com.dmdirc.commandparser.CommandParser;
31 31
 import com.dmdirc.commandparser.IntelligentCommand;
32
-import com.dmdirc.ui.swing.components.ColourPickerDialog;
33 32
 import com.dmdirc.ui.interfaces.InputWindow;
34 33
 import com.dmdirc.ui.messages.Styliser;
34
+import com.dmdirc.ui.swing.components.ColourPickerDialog;
35 35
 
36 36
 import java.awt.event.ActionEvent;
37 37
 import java.awt.event.ActionListener;

+ 1
- 0
src/com/dmdirc/ui/interfaces/ChannelWindow.java Visa fil

@@ -23,6 +23,7 @@
23 23
 package com.dmdirc.ui.interfaces;
24 24
 
25 25
 import com.dmdirc.parser.ChannelClientInfo;
26
+
26 27
 import java.util.List;
27 28
 
28 29
 /**

+ 0
- 1
src/com/dmdirc/ui/interfaces/PreferencesPanel.java Visa fil

@@ -61,7 +61,6 @@ public interface PreferencesPanel {
61 61
      * @param parentCategory parent category
62 62
      * @param name Category name
63 63
      * @param blurb category blurb
64
-     * @param nodeIcon icon for the node
65 64
      */
66 65
     void addCategory(final String parentCategory, final String name,
67 66
             final String blurb);

+ 1
- 0
src/com/dmdirc/ui/interfaces/StatusBar.java Visa fil

@@ -23,6 +23,7 @@
23 23
 package com.dmdirc.ui.interfaces;
24 24
 
25 25
 import java.awt.Component;
26
+
26 27
 import javax.swing.Icon;
27 28
 
28 29
 /**

+ 2
- 1
src/com/dmdirc/ui/interfaces/UIController.java Visa fil

@@ -29,6 +29,7 @@ import com.dmdirc.WritableFrameContainer;
29 29
 import com.dmdirc.commandparser.CommandParser;
30 30
 import com.dmdirc.ui.swing.MainFrame;
31 31
 import com.dmdirc.updater.Update;
32
+
32 33
 import java.util.List;
33 34
 
34 35
 /**
@@ -97,7 +98,7 @@ public interface UIController {
97 98
      * Creates a new preferences panel for the specified parent.
98 99
      *
99 100
      * @param parent Preferences panel parent
100
-     * @param text Preferences panel title
101
+     * @param title Preferences panel title
101 102
      *
102 103
      * @return PreferencesPanel
103 104
      */

+ 1
- 1
src/com/dmdirc/ui/interfaces/UpdaterDialog.java Visa fil

@@ -23,7 +23,7 @@
23 23
 package com.dmdirc.ui.interfaces;
24 24
 
25 25
 /**
26
- * Updater dialog
26
+ * Updater dialog.
27 27
  */
28 28
 public interface UpdaterDialog {
29 29
     

+ 2
- 2
src/com/dmdirc/ui/swing/ChannelFrame.java Visa fil

@@ -31,10 +31,10 @@ import com.dmdirc.commandparser.CommandManager;
31 31
 import com.dmdirc.commandparser.CommandParser;
32 32
 import com.dmdirc.commandparser.ServerCommand;
33 33
 import com.dmdirc.parser.ChannelClientInfo;
34
-import com.dmdirc.ui.swing.components.InputFrame;
35
-import com.dmdirc.ui.swing.dialogs.channelsetting.ChannelSettingsDialog;
36 34
 import com.dmdirc.ui.input.InputHandler;
37 35
 import com.dmdirc.ui.interfaces.ChannelWindow;
36
+import com.dmdirc.ui.swing.components.InputFrame;
37
+import com.dmdirc.ui.swing.dialogs.channelsetting.ChannelSettingsDialog;
38 38
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
39 39
 
40 40
 import java.awt.BorderLayout;

+ 1
- 1
src/com/dmdirc/ui/swing/CustomInputFrame.java Visa fil

@@ -24,8 +24,8 @@ package com.dmdirc.ui.swing;
24 24
 
25 25
 import com.dmdirc.WritableFrameContainer;
26 26
 import com.dmdirc.commandparser.CommandParser;
27
-import com.dmdirc.ui.swing.components.InputFrame;
28 27
 import com.dmdirc.ui.input.InputHandler;
28
+import com.dmdirc.ui.swing.components.InputFrame;
29 29
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
30 30
 
31 31
 import java.awt.GridBagConstraints;

+ 4
- 4
src/com/dmdirc/ui/swing/MainFrame.java Visa fil

@@ -31,6 +31,10 @@ import com.dmdirc.actions.ActionManager;
31 31
 import com.dmdirc.actions.CoreActionType;
32 32
 import com.dmdirc.logger.ErrorLevel;
33 33
 import com.dmdirc.logger.Logger;
34
+import com.dmdirc.ui.interfaces.FrameManager;
35
+import com.dmdirc.ui.interfaces.FramemanagerPosition;
36
+import com.dmdirc.ui.interfaces.StatusBar;
37
+import com.dmdirc.ui.interfaces.Window;
34 38
 import com.dmdirc.ui.swing.components.Frame;
35 39
 import com.dmdirc.ui.swing.components.SwingStatusBar;
36 40
 import com.dmdirc.ui.swing.dialogs.ActionsManagerDialog;
@@ -39,13 +43,9 @@ import com.dmdirc.ui.swing.dialogs.PluginDialog;
39 43
 import com.dmdirc.ui.swing.dialogs.PreferencesDialog;
40 44
 import com.dmdirc.ui.swing.dialogs.ProfileEditorDialog;
41 45
 import com.dmdirc.ui.swing.dialogs.about.AboutDialog;
42
-import com.dmdirc.ui.interfaces.FrameManager;
43
-import com.dmdirc.ui.interfaces.FramemanagerPosition;
44 46
 import com.dmdirc.ui.swing.framemanager.MainFrameManager;
45 47
 import com.dmdirc.ui.swing.framemanager.windowmenu.WindowMenuFrameManager;
46
-import com.dmdirc.ui.interfaces.Window;
47 48
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
48
-import com.dmdirc.ui.interfaces.StatusBar;
49 49
 
50 50
 import java.awt.BorderLayout;
51 51
 import java.awt.Color;

+ 1
- 1
src/com/dmdirc/ui/swing/QueryFrame.java Visa fil

@@ -25,9 +25,9 @@ package com.dmdirc.ui.swing;
25 25
 import com.dmdirc.Query;
26 26
 import com.dmdirc.commandparser.CommandParser;
27 27
 import com.dmdirc.commandparser.QueryCommandParser;
28
-import com.dmdirc.ui.swing.components.InputFrame;
29 28
 import com.dmdirc.ui.input.InputHandler;
30 29
 import com.dmdirc.ui.interfaces.QueryWindow;
30
+import com.dmdirc.ui.swing.components.InputFrame;
31 31
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
32 32
 
33 33
 import java.awt.GridBagConstraints;

+ 2
- 2
src/com/dmdirc/ui/swing/ServerFrame.java Visa fil

@@ -27,10 +27,10 @@ import com.dmdirc.Config;
27 27
 import com.dmdirc.Server;
28 28
 import com.dmdirc.commandparser.CommandParser;
29 29
 import com.dmdirc.commandparser.ServerCommandParser;
30
-import com.dmdirc.ui.swing.components.InputFrame;
31
-import com.dmdirc.ui.swing.dialogs.serversetting.ServerSettingsDialog;
32 30
 import com.dmdirc.ui.input.InputHandler;
33 31
 import com.dmdirc.ui.interfaces.ServerWindow;
32
+import com.dmdirc.ui.swing.components.InputFrame;
33
+import com.dmdirc.ui.swing.dialogs.serversetting.ServerSettingsDialog;
34 34
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
35 35
 
36 36
 import java.awt.BorderLayout;

+ 13
- 6
src/com/dmdirc/ui/swing/SwingController.java Visa fil

@@ -22,6 +22,7 @@
22 22
 
23 23
 package com.dmdirc.ui.swing;
24 24
 
25
+
25 26
 import com.dmdirc.Channel;
26 27
 import com.dmdirc.Config;
27 28
 import com.dmdirc.Main;
@@ -31,12 +32,8 @@ import com.dmdirc.WritableFrameContainer;
31 32
 import com.dmdirc.commandparser.CommandParser;
32 33
 import com.dmdirc.logger.ErrorLevel;
33 34
 import com.dmdirc.logger.Logger;
34
-import com.dmdirc.ui.swing.components.SwingPreferencesPanel;
35
-import com.dmdirc.ui.swing.dialogs.SwingUpdaterDialog;
36
-import com.dmdirc.ui.swing.dialogs.channelsetting.ChannelSettingsDialog;
37
-import com.dmdirc.ui.swing.dialogs.firstrunwizard.SwingFirstRunWizard;
38
-import com.dmdirc.ui.interfaces.FrameManager;
39 35
 import com.dmdirc.ui.interfaces.ChannelWindow;
36
+import com.dmdirc.ui.interfaces.FrameManager;
40 37
 import com.dmdirc.ui.interfaces.InputWindow;
41 38
 import com.dmdirc.ui.interfaces.PreferencesInterface;
42 39
 import com.dmdirc.ui.interfaces.PreferencesPanel;
@@ -45,6 +42,10 @@ import com.dmdirc.ui.interfaces.ServerWindow;
45 42
 import com.dmdirc.ui.interfaces.StatusBar;
46 43
 import com.dmdirc.ui.interfaces.UIController;
47 44
 import com.dmdirc.ui.interfaces.UpdaterDialog;
45
+import com.dmdirc.ui.swing.components.SwingPreferencesPanel;
46
+import com.dmdirc.ui.swing.dialogs.SwingUpdaterDialog;
47
+import com.dmdirc.ui.swing.dialogs.channelsetting.ChannelSettingsDialog;
48
+import com.dmdirc.ui.swing.dialogs.firstrunwizard.SwingFirstRunWizard;
48 49
 import com.dmdirc.ui.swing.dialogs.serversetting.ServerSettingsDialog;
49 50
 import com.dmdirc.updater.Update;
50 51
 
@@ -53,6 +54,7 @@ import java.awt.Font;
53 54
 import java.awt.Insets;
54 55
 import java.awt.Toolkit;
55 56
 import java.util.List;
57
+
56 58
 import javax.swing.BorderFactory;
57 59
 import javax.swing.UIManager;
58 60
 import javax.swing.UIManager.LookAndFeelInfo;
@@ -64,13 +66,18 @@ import javax.swing.plaf.FontUIResource;
64 66
  *
65 67
  * @author Chris
66 68
  */
67
-public class SwingController implements UIController {
69
+public final class SwingController implements UIController {
68 70
     
69 71
     /**
70 72
      * Singleton instance of MainFrame.
71 73
      */
72 74
     private static MainFrame me;
73 75
     
76
+    /** Instantiates a new SwingController. */
77
+    public SwingController() {
78
+        //Do nothing
79
+    }
80
+    
74 81
     /** {@inheritDoc} */
75 82
     public synchronized MainFrame getMainWindow() {
76 83
         if (me == null) {

+ 3
- 3
src/com/dmdirc/ui/swing/components/InputFrame.java Visa fil

@@ -27,12 +27,12 @@ import com.dmdirc.WritableFrameContainer;
27 27
 import com.dmdirc.config.ConfigManager;
28 28
 import com.dmdirc.logger.ErrorLevel;
29 29
 import com.dmdirc.logger.Logger;
30
-import com.dmdirc.ui.swing.actions.InputFramePasteAction;
30
+import com.dmdirc.ui.input.InputHandler;
31
+import com.dmdirc.ui.interfaces.InputWindow;
31 32
 import com.dmdirc.ui.swing.actions.CopyAction;
32 33
 import com.dmdirc.ui.swing.actions.CutAction;
34
+import com.dmdirc.ui.swing.actions.InputFramePasteAction;
33 35
 import com.dmdirc.ui.swing.dialogs.PasteDialog;
34
-import com.dmdirc.ui.input.InputHandler;
35
-import com.dmdirc.ui.interfaces.InputWindow;
36 36
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
37 37
 
38 38
 import java.awt.AWTException;

+ 2
- 2
src/com/dmdirc/ui/swing/components/SwingStatusBar.java Visa fil

@@ -27,11 +27,11 @@ import com.dmdirc.IconManager;
27 27
 import com.dmdirc.logger.ErrorListener;
28 28
 import com.dmdirc.logger.ErrorManager;
29 29
 import com.dmdirc.logger.ProgramError;
30
-import com.dmdirc.ui.swing.dialogs.error.ErrorListDialog;
30
+import com.dmdirc.ui.interfaces.StatusBar;
31 31
 import com.dmdirc.ui.interfaces.StatusErrorNotifier;
32 32
 import com.dmdirc.ui.interfaces.StatusMessageNotifier;
33
+import com.dmdirc.ui.swing.dialogs.error.ErrorListDialog;
33 34
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
34
-import com.dmdirc.ui.interfaces.StatusBar;
35 35
 
36 36
 import java.awt.Component;
37 37
 import java.awt.Dimension;

+ 34
- 14
src/com/dmdirc/ui/swing/components/reorderablelist/ArrayListTransferHandler.java Visa fil

@@ -24,6 +24,7 @@ package com.dmdirc.ui.swing.components.reorderablelist;
24 24
 
25 25
 import com.dmdirc.logger.ErrorLevel;
26 26
 import com.dmdirc.logger.Logger;
27
+
27 28
 import java.awt.datatransfer.DataFlavor;
28 29
 import java.awt.datatransfer.Transferable;
29 30
 import java.awt.datatransfer.UnsupportedFlavorException;
@@ -38,7 +39,7 @@ import javax.swing.TransferHandler;
38 39
 /**
39 40
  * Arraylist Transfer handler.
40 41
  */
41
-public class ArrayListTransferHandler extends TransferHandler {
42
+public final class ArrayListTransferHandler extends TransferHandler {
42 43
     
43 44
     /**
44 45
      * A version number for this class. It should be changed whenever the class
@@ -47,13 +48,20 @@ public class ArrayListTransferHandler extends TransferHandler {
47 48
      */
48 49
     private static final long serialVersionUID = 1;
49 50
     
51
+    /** Local Transfer flavour. */
50 52
     private DataFlavor localArrayListFlavor;
53
+    /** Serial Transfer flavour. */
51 54
     private final DataFlavor serialArrayListFlavor;
52
-    private JList source = null;
53
-    private int[] indices = null;
54
-    private int addIndex = -1; //Location where items were added
55
-    private int addCount = 0;  //Number of items added
55
+    /** Source component. */
56
+    private JList source;
57
+    /** Dragged Indices. */
58
+    private int[] indices;
59
+    /** Index to add item(s). */
60
+    private int addIndex = -1;
61
+    /** Number of items to add. */
62
+    private int addCount;
56 63
     
64
+    /** Instantiates a new ArrayListTransferHandler. */
57 65
     public ArrayListTransferHandler() {
58 66
         super();
59 67
         
@@ -78,11 +86,11 @@ public class ArrayListTransferHandler extends TransferHandler {
78 86
         }
79 87
         
80 88
         try {
81
-            target = (JList)c;
89
+            target = (JList) c;
82 90
             if (hasLocalArrayListFlavor(t.getTransferDataFlavors())) {
83
-                alist = (ArrayList)t.getTransferData(localArrayListFlavor);
91
+                alist = (ArrayList) t.getTransferData(localArrayListFlavor);
84 92
             } else if (hasSerialArrayListFlavor(t.getTransferDataFlavors())) {
85
-                alist = (ArrayList)t.getTransferData(serialArrayListFlavor);
93
+                alist = (ArrayList) t.getTransferData(serialArrayListFlavor);
86 94
             } else {
87 95
                 return false;
88 96
             }
@@ -104,7 +112,7 @@ public class ArrayListTransferHandler extends TransferHandler {
104 112
             return true;
105 113
         }
106 114
         
107
-        final DefaultListModel listModel = (DefaultListModel)target.getModel();
115
+        final DefaultListModel listModel = (DefaultListModel) target.getModel();
108 116
         final int max = listModel.getSize();
109 117
         
110 118
         if (index < 0) {
@@ -119,7 +127,7 @@ public class ArrayListTransferHandler extends TransferHandler {
119 127
         addIndex = index;
120 128
         addCount = alist.size();
121 129
         
122
-        for (int i=0; i < alist.size(); i++) {
130
+        for (int i = 0; i < alist.size(); i++) {
123 131
             listModel.add(index++, alist.get(i));
124 132
         }
125 133
         
@@ -130,7 +138,7 @@ public class ArrayListTransferHandler extends TransferHandler {
130 138
     protected void exportDone(final JComponent c, final Transferable data,
131 139
             final int action) {
132 140
         if ((action == MOVE) && (indices != null)) {
133
-            final DefaultListModel model = (DefaultListModel)source.getModel();
141
+            final DefaultListModel model = (DefaultListModel) source.getModel();
134 142
             
135 143
             if (addCount > 0) {
136 144
                 for (int i = 0; i < indices.length; i++) {
@@ -139,7 +147,7 @@ public class ArrayListTransferHandler extends TransferHandler {
139 147
                     }
140 148
                 }
141 149
             }
142
-            for (int i = indices.length -1; i >= 0; i--) {
150
+            for (int i = indices.length - 1; i >= 0; i--) {
143 151
                 model.remove(indices[i]);
144 152
             }
145 153
         }
@@ -149,7 +157,13 @@ public class ArrayListTransferHandler extends TransferHandler {
149 157
         addCount = 0;
150 158
     }
151 159
     
152
-    /** {@inheritDoc} */
160
+    /** 
161
+     * Do any of the specified flavours match the local flavour.
162
+     * 
163
+     * @param flavors Flavours to check
164
+     *
165
+     * @return whether the flavour is supported
166
+     */
153 167
     private boolean hasLocalArrayListFlavor(final DataFlavor[] flavors) {
154 168
         if (localArrayListFlavor == null) {
155 169
             return false;
@@ -164,7 +178,13 @@ public class ArrayListTransferHandler extends TransferHandler {
164 178
         return false;
165 179
     }
166 180
     
167
-    /** {@inheritDoc} */
181
+    /** 
182
+     * Do any of the specified flavours match the serial flavour.
183
+     * 
184
+     * @param flavors Flavours to check
185
+     *
186
+     * @return whether the flavour is supported
187
+     */
168 188
     private boolean hasSerialArrayListFlavor(final DataFlavor[] flavors) {
169 189
         if (serialArrayListFlavor == null) {
170 190
             return false;

+ 11
- 3
src/com/dmdirc/ui/swing/components/reorderablelist/ArrayListTransferable.java Visa fil

@@ -24,6 +24,7 @@ package com.dmdirc.ui.swing.components.reorderablelist;
24 24
 
25 25
 import com.dmdirc.logger.ErrorLevel;
26 26
 import com.dmdirc.logger.Logger;
27
+
27 28
 import java.awt.datatransfer.DataFlavor;
28 29
 import java.awt.datatransfer.Transferable;
29 30
 import java.awt.datatransfer.UnsupportedFlavorException;
@@ -32,13 +33,20 @@ import java.util.ArrayList;
32 33
 /**
33 34
  * Arraylist transferable.
34 35
  */
35
-public class ArrayListTransferable implements Transferable {
36
+public final class ArrayListTransferable implements Transferable {
36 37
     
38
+    /** Local tranfer flavour. */
37 39
     private DataFlavor localArrayListFlavor;
40
+    /** Serial transfer flavour. */
38 41
     private final DataFlavor serialArrayListFlavor;
42
+    /** Transferred ArrayList. */
39 43
     private final ArrayList data; //NOPMD
40 44
     
41
-    /** Initialises the ArrayListTransferable. */
45
+    /** 
46
+     * Initialises the ArrayListTransferable. 
47
+     *
48
+     * @param alist ArrayList to transfer
49
+     */
42 50
     public ArrayListTransferable(final ArrayList alist) { //NOPMD
43 51
         super();
44 52
         
@@ -68,7 +76,7 @@ public class ArrayListTransferable implements Transferable {
68 76
     
69 77
     /** {@inheritDoc} */
70 78
     public DataFlavor[] getTransferDataFlavors() {
71
-        return new DataFlavor[] { localArrayListFlavor, serialArrayListFlavor };
79
+        return new DataFlavor[]{localArrayListFlavor, serialArrayListFlavor, };
72 80
     }
73 81
     
74 82
     /** {@inheritDoc} */

+ 6
- 4
src/com/dmdirc/ui/swing/components/reorderablelist/ReorderableJList.java Visa fil

@@ -47,8 +47,8 @@ import java.awt.dnd.DropTargetEvent;
47 47
 import java.awt.dnd.DropTargetListener;
48 48
 import java.io.IOException;
49 49
 import java.util.ArrayList;
50
-import javax.swing.DefaultListModel;
51 50
 
51
+import javax.swing.DefaultListModel;
52 52
 import javax.swing.JList;
53 53
 import javax.swing.ListSelectionModel;
54 54
 
@@ -123,6 +123,8 @@ public final class ReorderableJList extends JList implements DragSourceListener,
123 123
     
124 124
     /**
125 125
      * Returns whether the target is below the drop cell.
126
+     *
127
+     * @return if the target is above or below the point
126 128
      */
127 129
     public boolean getBelowTarget() {
128 130
         return belowTarget;
@@ -239,9 +241,9 @@ public final class ReorderableJList extends JList implements DragSourceListener,
239 241
         }
240 242
         
241 243
         //move items
242
-        final boolean sourceBeforeTarget = (draggedIndex < index);
244
+        final boolean sourceBeforeTarget = draggedIndex < index;
243 245
         final DefaultListModel mod = getModel();
244
-        final int newIndex = (sourceBeforeTarget ? index - 1 : index);
246
+        final int newIndex = sourceBeforeTarget ? index - 1 : index;
245 247
         mod.remove(draggedIndex);
246 248
         for (Object item : (ArrayList) dragged) {
247 249
             mod.add(newIndex, item);
@@ -271,7 +273,7 @@ public final class ReorderableJList extends JList implements DragSourceListener,
271 273
         final Transferable trans = new ArrayListTransferable(transferObject);
272 274
         //start drag
273 275
         draggedIndex = index;
274
-        dragSource.startDrag(dge,Cursor.getDefaultCursor(), trans, this);
276
+        dragSource.startDrag(dge, Cursor.getDefaultCursor(), trans, this);
275 277
     }
276 278
 }
277 279
 

+ 2
- 1
src/com/dmdirc/ui/swing/components/reorderablelist/ReorderableJListCellRenderer.java Visa fil

@@ -24,6 +24,7 @@ package com.dmdirc.ui.swing.components.reorderablelist;
24 24
 
25 25
 import java.awt.BorderLayout;
26 26
 import java.awt.Component;
27
+
27 28
 import javax.swing.JLabel;
28 29
 import javax.swing.JList;
29 30
 import javax.swing.JPanel;
@@ -63,7 +64,7 @@ class ReorderableJListCellRenderer implements ListCellRenderer {
63 64
             final boolean hasFocus) {
64 65
         final JPanel panel = new JPanel();
65 66
         panel.setLayout(new BorderLayout());
66
-        final boolean isTargetCell = (value == parent.getTargetCell());
67
+        final boolean isTargetCell = value == parent.getTargetCell();
67 68
         
68 69
         final boolean showSelected = isSelected & (parent.getTargetCell() == null);
69 70
         

+ 1
- 2
src/com/dmdirc/ui/swing/dialogs/NewServerDialog.java Visa fil

@@ -28,9 +28,8 @@ import com.dmdirc.Server;
28 28
 import com.dmdirc.ServerManager;
29 29
 import com.dmdirc.config.Identity;
30 30
 import com.dmdirc.config.IdentityManager;
31
-import com.dmdirc.ui.swing.MainFrame;
32
-import com.dmdirc.ui.swing.components.StandardDialog;
33 31
 import com.dmdirc.ui.interfaces.Window;
32
+import com.dmdirc.ui.swing.components.StandardDialog;
34 33
 import static com.dmdirc.ui.swing.UIUtilities.LARGE_BORDER;
35 34
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
36 35
 

+ 0
- 1
src/com/dmdirc/ui/swing/dialogs/PasteDialog.java Visa fil

@@ -23,7 +23,6 @@
23 23
 package com.dmdirc.ui.swing.dialogs;
24 24
 
25 25
 import com.dmdirc.Main;
26
-import com.dmdirc.ui.swing.MainFrame;
27 26
 import com.dmdirc.ui.swing.components.InputFrame;
28 27
 import com.dmdirc.ui.swing.components.StandardDialog;
29 28
 import static com.dmdirc.ui.swing.UIUtilities.LARGE_BORDER;

+ 2
- 2
src/com/dmdirc/ui/swing/dialogs/SwingUpdaterDialog.java Visa fil

@@ -23,11 +23,11 @@
23 23
 package com.dmdirc.ui.swing.dialogs;
24 24
 
25 25
 import com.dmdirc.Main;
26
+import com.dmdirc.ui.interfaces.UpdaterDialog;
26 27
 import com.dmdirc.ui.swing.components.StandardDialog;
27 28
 import com.dmdirc.updater.Update;
28 29
 import static com.dmdirc.ui.swing.UIUtilities.LARGE_BORDER;
29 30
 import static com.dmdirc.ui.swing.UIUtilities.SMALL_BORDER;
30
-import com.dmdirc.ui.interfaces.UpdaterDialog;
31 31
 
32 32
 import java.awt.BorderLayout;
33 33
 import java.awt.Dimension;
@@ -84,7 +84,7 @@ public final class SwingUpdaterDialog extends StandardDialog implements
84 84
         
85 85
         setLayout(new BorderLayout());
86 86
         
87
-        JLabel header = new JLabel("<html><big>Update Available</big><br><br>"
87
+        final JLabel header = new JLabel("<html><big>Update Available</big><br><br>"
88 88
                 + "An update is available for one or more "
89 89
                 + "components of DMDirc:</html>");
90 90
         header.setBorder(BorderFactory.createEmptyBorder(LARGE_BORDER,

+ 3
- 4
src/com/dmdirc/ui/swing/dialogs/firstrunwizard/SwingFirstRunWizard.java Visa fil

@@ -26,11 +26,11 @@ import com.dmdirc.Config;
26 26
 import com.dmdirc.logger.ErrorLevel;
27 27
 import com.dmdirc.logger.Logger;
28 28
 import com.dmdirc.resourcemanager.ResourceManager;
29
+import com.dmdirc.ui.interfaces.FirstRunWizard;
29 30
 import com.dmdirc.ui.swing.dialogs.ProfileEditorDialog;
30 31
 import com.dmdirc.ui.swing.dialogs.wizard.Step;
31 32
 import com.dmdirc.ui.swing.dialogs.wizard.Wizard;
32 33
 import com.dmdirc.ui.swing.dialogs.wizard.WizardDialog;
33
-import com.dmdirc.ui.interfaces.FirstRunWizard;
34 34
 
35 35
 import java.awt.Dimension;
36 36
 import java.io.File;
@@ -47,7 +47,7 @@ import java.util.Map.Entry;
47 47
 public final class SwingFirstRunWizard implements Wizard, FirstRunWizard {
48 48
     
49 49
     /** Wizard dialog. */
50
-    private static WizardDialog wizardDialog;
50
+    private WizardDialog wizardDialog;
51 51
     
52 52
     /** Instatiate the wizard. */
53 53
     public SwingFirstRunWizard() {
@@ -125,8 +125,7 @@ public final class SwingFirstRunWizard implements Wizard, FirstRunWizard {
125 125
         steps.add(new StepOne());
126 126
         steps.add(new StepTwo());
127 127
         
128
-        wizardDialog = new WizardDialog("Setup wizard", steps,
129
-                new SwingFirstRunWizard(), true);
128
+        wizardDialog = new WizardDialog("Setup wizard", steps, this, true);
130 129
         
131 130
         wizardDialog.setPreferredSize(new Dimension(400, 350));
132 131
         

+ 1
- 1
src/com/dmdirc/ui/swing/framemanager/MainFrameManager.java Visa fil

@@ -27,10 +27,10 @@ import com.dmdirc.Config;
27 27
 import com.dmdirc.FrameContainer;
28 28
 import com.dmdirc.Query;
29 29
 import com.dmdirc.Server;
30
+import com.dmdirc.ui.interfaces.FrameManager;
30 31
 import com.dmdirc.ui.swing.framemanager.buttonbar.ButtonBar;
31 32
 import com.dmdirc.ui.swing.framemanager.tree.TreeFrameManager;
32 33
 import com.dmdirc.ui.swing.framemanager.windowmenu.WindowMenuFrameManager;
33
-import com.dmdirc.ui.interfaces.FrameManager;
34 34
 
35 35
 import java.awt.Color;
36 36
 import java.io.IOException;

+ 1
- 1
src/com/dmdirc/ui/swing/framemanager/buttonbar/ButtonBar.java Visa fil

@@ -28,10 +28,10 @@ import com.dmdirc.FrameContainer;
28 28
 import com.dmdirc.Main;
29 29
 import com.dmdirc.Query;
30 30
 import com.dmdirc.Server;
31
-import com.dmdirc.ui.swing.UIUtilities;
32 31
 import com.dmdirc.ui.interfaces.FrameManager;
33 32
 import com.dmdirc.ui.interfaces.FramemanagerPosition;
34 33
 import com.dmdirc.ui.interfaces.Window;
34
+import com.dmdirc.ui.swing.UIUtilities;
35 35
 
36 36
 import java.awt.BorderLayout;
37 37
 import java.awt.Color;

+ 1
- 2
src/com/dmdirc/ui/swing/framemanager/windowmenu/WindowMenuFrameManager.java Visa fil

@@ -27,9 +27,8 @@ import com.dmdirc.FrameContainer;
27 27
 import com.dmdirc.Main;
28 28
 import com.dmdirc.Query;
29 29
 import com.dmdirc.Server;
30
-import com.dmdirc.ui.swing.MainFrame;
31
-import com.dmdirc.ui.swing.components.FrameContainerComparator;
32 30
 import com.dmdirc.ui.interfaces.FrameManager;
31
+import com.dmdirc.ui.swing.components.FrameContainerComparator;
33 32
 
34 33
 import java.awt.Color;
35 34
 import java.awt.Font;

+ 4
- 4
src/com/dmdirc/ui/swing/textpane/TextPane.java Visa fil

@@ -118,11 +118,11 @@ public final class TextPane extends JComponent implements AdjustmentListener,
118 118
     /**
119 119
      * Stylises the specified string and adds it to the passed TextPane.
120 120
      *
121
-     * @param doc The document which the output should be added to
122 121
      * @param string The line to be stylised and added
123 122
      */
124 123
     public void addStyledString(final String string) {
125
-        final AttributedString text = Styliser.styledDocumentToAttributedString(Styliser.getStyledString(new String[]{string, }));
124
+        final AttributedString text = Styliser.styledDocumentToAttributedString(
125
+                Styliser.getStyledString(new String[]{string, }));
126 126
         
127 127
         if (text.getIterator().getEndIndex() == 0) {
128 128
             addText(new AttributedString("\n"));
@@ -134,11 +134,11 @@ public final class TextPane extends JComponent implements AdjustmentListener,
134 134
     /**
135 135
      * Stylises the specified string and adds it to the passed TextPane.
136 136
      *
137
-     * @param doc The document which the output should be added to
138 137
      * @param strings The strings to be stylised and added to a line
139 138
      */
140 139
     public void addStyledString(final String[] strings) {
141
-        final AttributedString text = Styliser.styledDocumentToAttributedString(Styliser.getStyledString(strings));
140
+        final AttributedString text = Styliser.styledDocumentToAttributedString(
141
+                Styliser.getStyledString(strings));
142 142
         
143 143
         if (text.getIterator().getEndIndex() == 0) {
144 144
             addText(new AttributedString("\n"));

+ 1
- 0
src/com/dmdirc/ui/swing/textpane/TextPaneCanvas.java Visa fil

@@ -23,6 +23,7 @@
23 23
 package com.dmdirc.ui.swing.textpane;
24 24
 
25 25
 import com.dmdirc.ui.messages.IRCTextAttribute;
26
+
26 27
 import java.awt.Graphics;
27 28
 import java.awt.Graphics2D;
28 29
 import java.awt.Point;

Laddar…
Avbryt
Spara