If the UI is not visible (well, if there are no "ready" error listeners) the logger will now output errors to System.err

git-svn-id: http://svn.dmdirc.com/trunk@2373 00569f92-eb28-0410-84fd-f71c24880f

src/com/dmdirc/logger/ErrorListener.java

@@ -57,4 +57,11 @@ public interface ErrorListener extends EventListener {
      * @param error Error that has been altered
      */
     void errorStatusChanged(final ProgramError error);
+    
+    /**
+     * Returns true if the error listener is ready to receive errors
+     *
+     * @return true iif the error listener is ready for errors
+     */
+    boolean isReady();
 }

src/com/dmdirc/logger/ErrorManager.java

@@ -147,11 +147,10 @@ public final class ErrorManager implements Serializable {
      *
      * @param error error to be sent
      */
-    @SuppressWarnings("PMD.SystemPrintln")
     public static void sendError(final ProgramError error) {
         new Timer("ErrorManager Timer").schedule(new TimerTask() {
             public void run() {
-                sendErrorInternal(error);
+                getErrorManager().sendErrorInternal(error);
             }
         }, 0);
     }
@@ -161,8 +160,7 @@ public final class ErrorManager implements Serializable {
      *
      * @param error ProgramError to be sent
      */
-    @SuppressWarnings("PMD.SystemPrintln")
-    private static void sendErrorInternal(final ProgramError error) {
+    private void sendErrorInternal(final ProgramError error) {
         final Map<String, String> postData = new HashMap<String, String>();
         List<String> response = new ArrayList<String>();
         int tries = 0;
@@ -191,7 +189,7 @@ public final class ErrorManager implements Serializable {
             
             tries++;
         } while((response.isEmpty() || !response.get(response.size() - 1).
-                equalsIgnoreCase("Error report submitted. Thank you.")) 
+                equalsIgnoreCase("Error report submitted. Thank you."))
                 || tries >= 5);
         
         checkResponses(error, response);
@@ -253,12 +251,22 @@ public final class ErrorManager implements Serializable {
      * @param error Error that occurred
      */
     protected void fireErrorAdded(final ProgramError error) {
+        int firedListeners = 0;
         final Object[] listeners = errorListeners.getListenerList();
         for (int i = 0; i < listeners.length; i += 2) {
             if (listeners[i] == ErrorListener.class) {
-                ((ErrorListener) listeners[i + 1]).errorAdded(error);
+                final ErrorListener thisListener = ((ErrorListener) listeners[i + 1]);
+                if (thisListener.isReady()) {
+                    thisListener.errorAdded(error);
+                    firedListeners++;
+                }
             }
         }
+        
+        if (firedListeners == 0) {
+            System.err.println("An error has occurred: " + error.getLevel()
+            + ": " + error.getMessage());
+        }
     }
     
     /**
@@ -267,12 +275,21 @@ public final class ErrorManager implements Serializable {
      * @param error Error that occurred
      */
     protected void fireFatalError(final ProgramError error) {
+        int firedListeners = 0;
         final Object[] listeners = errorListeners.getListenerList();
         for (int i = 0; i < listeners.length; i += 2) {
             if (listeners[i] == ErrorListener.class) {
-                ((ErrorListener) listeners[i + 1]).fatalError(error);
+                final ErrorListener thisListener = ((ErrorListener) listeners[i + 1]);
+                if (thisListener.isReady()) {
+                    thisListener.fatalError(error);
+                    firedListeners++;
+                }
             }
         }
+         
+        if (firedListeners == 0) {
+            System.err.println("A fatal has occurred: " + error.getMessage());
+        }
     }
     
     /**

src/com/dmdirc/ui/dummy/DummyStatusBar.java

@@ -72,4 +72,9 @@ public final class DummyStatusBar implements StatusBar {
         // Do nothing
     }
 
+    /** {@inheritDoc} */
+    public boolean isVisible() {
+        return true;
+    }
+
 }

src/com/dmdirc/ui/interfaces/StatusBar.java

@@ -80,4 +80,11 @@ public interface StatusBar {
      */
     void removeComponent(final Component component);
     
+    /**
+     * Returns true if the status bar is visible.
+     *
+     * @return true iff the status bar is visible
+     */
+    boolean isVisible();
+    
 }

src/com/dmdirc/ui/swing/components/SwingStatusBar.java

@@ -269,4 +269,9 @@ public final class SwingStatusBar extends JPanel implements MouseListener,
         constraints.setWidth(constraints.getWidth());
         this.setVisible(true);
     }
+    
+    /** {@inheritDoc} */
+    public boolean isReady() {
+        return isValid();
+    }
 }

src/com/dmdirc/ui/swing/dialogs/error/ErrorDetailPanel.java

@@ -223,5 +223,10 @@ public final class ErrorDetailPanel extends JPanel implements ErrorListener {
             errorStatus.setText(error.getFixedStatus().toString());
         }
     }
+
+    /** {@inheritDoc} */
+    public boolean isReady() {
+        return isVisible();
+    }
     
 }

src/com/dmdirc/ui/swing/dialogs/error/ErrorListDialog.java

@@ -341,4 +341,9 @@ public final class ErrorListDialog extends StandardDialog implements
             me = null;
         }
     }
+
+    /** {@inheritDoc} */
+    public boolean isReady() {
+        return Main.getUI().getStatusBar().isVisible();
+    }
 }