Add more edge cases to URLBuilder test

Change-Id: Ieb694440470d084fff0d1a4fc4e89904bde07b07
Reviewed-on: http://gerrit.dmdirc.com/2874
Reviewed-by: Chris Smith <chris@dmdirc.com>
Automatic-Compile: DMDirc Build Manager

test/com/dmdirc/util/URLBuilderTest.java

@@ -74,12 +74,24 @@ public class URLBuilderTest {
         Assert.assertEquals(new URL("file://test"), urlBuilder.getUrlForFile("file://test"));
     }
 
+    @Test
+    public void testGetUrlInvalid() throws MalformedURLException {
+        URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
+        Assert.assertNull(urlBuilder.getUrlForFile("file://[test"));
+    }
+
     @Test
     public void testGetUrlForJarFile() throws MalformedURLException {
         URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
         Assert.assertEquals(new URL("jar:file:/jarFile!/test"), urlBuilder.getUrlForJarFile("jarFile", "test"));
     }
 
+    @Test
+    public void testGetUrlForJarFileInvalud() throws MalformedURLException {
+        URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
+        Assert.assertNull(urlBuilder.getUrlForJarFile("[jarFile", "test"));
+    }
+
     @Test
     public void testGetUrlForDMDircResourceNonExistant() {
         URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
@@ -120,30 +132,60 @@ public class URLBuilderTest {
         Assert.assertEquals(new URL("jar:file:/jarFile!/testFile"), urlBuilder.getUrl("jar://jarFile:testFile"));
     }
 
+    @Test
+    public void testGetUrlJarWithoutFile() throws MalformedURLException {
+        URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
+        Assert.assertNull(urlBuilder.getUrl("jar://jarFile"));
+    }
+
     @Test
     public void testGetUrlZip() throws MalformedURLException {
         URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
         Assert.assertEquals(new URL("jar:file:/zipFile!/testFile"), urlBuilder.getUrl("zip://zipFile:testFile"));
     }
 
+    @Test
+    public void testGetUrlZipWithoutFile() throws MalformedURLException {
+        URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
+        Assert.assertNull(urlBuilder.getUrl("zip://zipFile"));
+    }
+
     @Test
     public void testGetUrlPlugin() throws MalformedURLException {
         URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
         Assert.assertEquals(new URL("jar:file:/testPlugin!/testFile"), urlBuilder.getUrl("plugin://pluginFile:testFile"));
     }
 
+    @Test
+    public void testGetUrlPluginWithoutFile() throws MalformedURLException {
+        URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
+        Assert.assertNull(urlBuilder.getUrl("plugin://pluginFile"));
+    }
+
     @Test
     public void testGetUrlTheme() throws MalformedURLException {
         URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
         Assert.assertEquals(new URL("jar:file:/themes/themeFile.zip!/testFile"), urlBuilder.getUrl("theme://themeFile:testFile"));
     }
 
+    @Test
+    public void testGetUrlThemeWithoutFile() throws MalformedURLException {
+        URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
+        Assert.assertNull(urlBuilder.getUrl("theme://themeFile"));
+    }
+
     @Test
     public void testGetUrlHTTP() throws MalformedURLException {
         URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
         Assert.assertEquals(new URL("http://testDomain"), urlBuilder.getUrl("http://testDomain"));
     }
 
+    @Test
+    public void testGetUrlHTTPInvalid() throws MalformedURLException {
+        URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);
+        Assert.assertNull(urlBuilder.getUrl("http://[testDomain"));
+    }
+
     @Test
     public void testGetUrlFileWithPrefix() throws MalformedURLException {
         URLBuilder urlBuilder = new URLBuilder(pluginManagerProvider, themeManagerProvider);