Преглед изворни кода

Tidy up after changes.

pull/588/head
Greg Holmes пре 9 година
родитељ
комит
7f27d8ce48

+ 1
- 1
src/com/dmdirc/ClientModule.java Прегледај датотеку

@@ -144,7 +144,7 @@ public class ClientModule {
144 144
             final DMDircMBassador eventBus,
145 145
             final IdentityController controller,
146 146
             @Directory(DirectoryType.THEMES) final String directory) {
147
-        final ThemeManager manager = new ThemeManager(eventBus, controller, directory);
147
+        final ThemeManager manager = new ThemeManager(controller, directory);
148 148
         manager.refreshAndLoadThemes();
149 149
         return manager;
150 150
     }

+ 1
- 1
src/com/dmdirc/Server.java Прегледај датотеку

@@ -228,7 +228,7 @@ public class Server extends FrameContainer implements Connection {
228 228
 
229 229
         initBackBuffer();
230 230
         this.highlightManager = new HighlightManager(getConfigManager(),
231
-                new ColourManager(getConfigManager(), getEventBus()));
231
+                new ColourManager(getConfigManager()));
232 232
         highlightManager.init();
233 233
         getEventBus().subscribe(highlightManager);
234 234
     }

+ 1
- 1
src/com/dmdirc/plugins/PluginModule.java Прегледај датотеку

@@ -58,7 +58,7 @@ public class PluginModule {
58 58
                 identityController, updateManager, objectGraph, fileHandler, directory);
59 59
         manager.refreshPlugins();
60 60
 
61
-        final CorePluginExtractor extractor = new CorePluginExtractor(manager, directory, eventBus);
61
+        final CorePluginExtractor extractor = new CorePluginExtractor(manager, directory);
62 62
         pluginHelper.checkBundledPlugins(extractor, manager,
63 63
                 identityController.getGlobalConfiguration());
64 64
 

+ 2
- 6
src/com/dmdirc/ui/messages/ColourManagerFactory.java Прегледај датотеку

@@ -22,7 +22,6 @@
22 22
 
23 23
 package com.dmdirc.ui.messages;
24 24
 
25
-import com.dmdirc.DMDircMBassador;
26 25
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
27 26
 
28 27
 import javax.inject.Inject;
@@ -34,15 +33,12 @@ import javax.inject.Singleton;
34 33
 @Singleton
35 34
 public class ColourManagerFactory {
36 35
 
37
-    private final DMDircMBassador eventBus;
38
-
39 36
     @Inject
40
-    public ColourManagerFactory(final DMDircMBassador eventBus) {
41
-        this.eventBus = eventBus;
37
+    public ColourManagerFactory() {
42 38
     }
43 39
 
44 40
     public ColourManager getColourManager(final AggregateConfigProvider configManager) {
45
-        return new ColourManager(configManager, eventBus);
41
+        return new ColourManager(configManager);
46 42
     }
47 43
 
48 44
 }

+ 1
- 1
src/com/dmdirc/ui/messages/UnreadStatusManager.java Прегледај датотеку

@@ -56,7 +56,7 @@ public class UnreadStatusManager {
56 56
     public UnreadStatusManager(final WindowModel container) {
57 57
         this.container = container;
58 58
         this.eventBus = container.getEventBus();
59
-        this.colourManager = new ColourManager(container.getConfigManager(), eventBus);
59
+        this.colourManager = new ColourManager(container.getConfigManager());
60 60
     }
61 61
 
62 62
     @Handler

+ 1
- 1
src/com/dmdirc/ui/messages/sink/MessagesModule.java Прегледај датотеку

@@ -41,7 +41,7 @@ public class MessagesModule {
41 41
     @Singleton
42 42
     public MessageSinkManager getMessageSinkManager(final DMDircMBassador eventBus,
43 43
             final Set<MessageSink> defaultSinks) {
44
-        final MessageSinkManager messageSinkManager = new MessageSinkManager(eventBus);
44
+        final MessageSinkManager messageSinkManager = new MessageSinkManager();
45 45
         defaultSinks.forEach(messageSinkManager::addSink);
46 46
         return messageSinkManager;
47 47
     }

+ 1
- 1
src/com/dmdirc/updater/UpdaterModule.java Прегледај датотеку

@@ -107,7 +107,7 @@ public class UpdaterModule {
107 107
             final DMDircUpdateManager updateManager,
108 108
             final IdentityController identityController,
109 109
             final DMDircMBassador eventBus) {
110
-        UpdateChecker.init(updateManager, identityController, eventBus);
110
+        UpdateChecker.init(updateManager, identityController);
111 111
 
112 112
         commandLineParser.getLauncherVersion().ifPresent(version ->
113 113
                 LauncherComponent.setLauncherInfo(updateManager, version));

+ 1
- 1
test/com/dmdirc/ui/messages/ColourManagerTest.java Прегледај датотеку

@@ -57,7 +57,7 @@ public class ColourManagerTest {
57 57
 
58 58
     @Before
59 59
     public void setup() {
60
-        manager = new ColourManager(configManager, eventBus);
60
+        manager = new ColourManager(configManager);
61 61
         verify(configManager).addChangeListener(anyString(), configListener.capture());
62 62
     }
63 63
 

+ 1
- 1
test/com/dmdirc/ui/messages/EventPropertyManagerTest.java Прегледај датотеку

@@ -48,7 +48,7 @@ public class EventPropertyManagerTest {
48 48
 
49 49
     @Before
50 50
     public void setUp() {
51
-        manager = new EventPropertyManager(eventBus);
51
+        manager = new EventPropertyManager();
52 52
     }
53 53
 
54 54
     @Test

+ 1
- 2
test/com/dmdirc/ui/messages/IntelligentLinkingTest.java Прегледај датотеку

@@ -55,8 +55,7 @@ public class IntelligentLinkingTest {
55 55
         when(connection.getGroupChatManager()).thenReturn(groupChatManager);
56 56
         when(groupChatManager.getChannelPrefixes()).thenReturn("#&+");
57 57
 
58
-        styliser = new Styliser(connection, manager, new ColourManager(manager,
59
-                mock(DMDircMBassador.class)));
58
+        styliser = new Styliser(connection, manager, new ColourManager(manager));
60 59
     }
61 60
 
62 61
     @Test

+ 1
- 2
test/com/dmdirc/ui/messages/StyliserStylesTest.java Прегледај датотеку

@@ -68,8 +68,7 @@ public class StyliserStylesTest {
68 68
 
69 69
         final AggregateConfigProvider manager = mock(AggregateConfigProvider.class);
70 70
 
71
-        final Styliser styliser = new Styliser(null, manager, new ColourManager(manager,
72
-                mock(DMDircMBassador.class)));
71
+        final Styliser styliser = new Styliser(null, manager, new ColourManager(manager));
73 72
         styliser.addStyledString(null, input);  // TODO...
74 73
         final AttributedCharacterIterator aci = null; // TODO...
75 74
 

+ 1
- 2
test/com/dmdirc/ui/messages/StyliserTest.java Прегледај датотеку

@@ -88,8 +88,7 @@ public class StyliserTest {
88 88
         final String input2 = "abcdefghi";
89 89
 
90 90
         final AggregateConfigProvider manager = mock(AggregateConfigProvider.class);
91
-        final Styliser styliser = new Styliser(null, manager, new ColourManager(manager,
92
-                mock(DMDircMBassador.class)));
91
+        final Styliser styliser = new Styliser(null, manager, new ColourManager(manager));
93 92
 
94 93
         for (int i = 0; i < input2.length(); i++) {
95 94
             // TODO...

+ 22
- 22
test/com/dmdirc/util/URLBuilderTest.java Прегледај датотеку

@@ -72,49 +72,49 @@ public class URLBuilderTest {
72 72
     @Test
73 73
     public void testGetUrlForFileWithoutFilePrefix() throws MalformedURLException {
74 74
         final URLBuilder urlBuilder
75
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
75
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
76 76
         Assert.assertEquals(new URL("file://test"), urlBuilder.getUrlForFile("test"));
77 77
     }
78 78
 
79 79
     @Test
80 80
     public void testGetUrlForFileWithFilePrefix() throws MalformedURLException {
81 81
         final URLBuilder urlBuilder
82
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
82
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
83 83
         Assert.assertEquals(new URL("file://test"), urlBuilder.getUrlForFile("file://test"));
84 84
     }
85 85
 
86 86
     @Test
87 87
     public void testGetUrlInvalid() throws MalformedURLException {
88 88
         final URLBuilder urlBuilder
89
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
89
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
90 90
         Assert.assertNull(urlBuilder.getUrlForFile("file://[test"));
91 91
     }
92 92
 
93 93
     @Test
94 94
     public void testGetUrlForJarFile() throws MalformedURLException {
95 95
         final URLBuilder urlBuilder
96
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
96
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
97 97
         Assert.assertEquals(new URL("jar:file:/jarFile!/test"), urlBuilder.getUrlForJarFile("jarFile", "test"));
98 98
     }
99 99
 
100 100
     @Test
101 101
     public void testGetUrlForJarFileInvalud() throws MalformedURLException {
102 102
         final URLBuilder urlBuilder
103
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
103
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
104 104
         Assert.assertNull(urlBuilder.getUrlForJarFile("[jarFile", "test"));
105 105
     }
106 106
 
107 107
     @Test
108 108
     public void testGetUrlForDMDircResourceNonExistant() {
109 109
         final URLBuilder urlBuilder
110
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
110
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
111 111
         Assert.assertNull(urlBuilder.getUrlForDMDircResource("test12345678"));
112 112
     }
113 113
 
114 114
     @Test
115 115
     public void testGetUrlForDMDircResource() throws MalformedURLException {
116 116
         final URLBuilder urlBuilder
117
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
117
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
118 118
         final URL url = urlBuilder.getUrlForDMDircResource("com/dmdirc/Main.class");
119 119
         Assert.assertTrue("file".equals(url.getProtocol()) || "jar".equals(url.getProtocol()));
120 120
         Assert.assertTrue(url.getFile().endsWith("com/dmdirc/Main.class"));
@@ -123,21 +123,21 @@ public class URLBuilderTest {
123 123
     @Test
124 124
     public void testGetUrlForThemeResource() throws MalformedURLException {
125 125
         final URLBuilder urlBuilder
126
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
126
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
127 127
         Assert.assertEquals(new URL("jar:file:/themes/testTheme.zip!/testFile"), urlBuilder.getUrlForThemeResource("testTheme", "testFile"));
128 128
     }
129 129
 
130 130
     @Test
131 131
     public void testGetUrlForPluginResource() throws MalformedURLException {
132 132
         final URLBuilder urlBuilder
133
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
133
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
134 134
         Assert.assertEquals(new URL("jar:file:/testPlugin!/testFile"), urlBuilder.getUrlForPluginResource("testPlugin", "testFile"));
135 135
     }
136 136
 
137 137
     @Test
138 138
     public void testGetUrlDMDirc() {
139 139
         final URLBuilder urlBuilder
140
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
140
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
141 141
         final URL url = urlBuilder.getUrl("dmdirc://com/dmdirc/Main.class");
142 142
         Assert.assertTrue("file".equals(url.getProtocol()) || "jar".equals(url.getProtocol()));
143 143
         Assert.assertTrue(url.getFile().endsWith("com/dmdirc/Main.class"));
@@ -146,84 +146,84 @@ public class URLBuilderTest {
146 146
     @Test
147 147
     public void testGetUrlJar() throws MalformedURLException {
148 148
         final URLBuilder urlBuilder
149
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
149
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
150 150
         Assert.assertEquals(new URL("jar:file:/jarFile!/testFile"), urlBuilder.getUrl("jar://jarFile:testFile"));
151 151
     }
152 152
 
153 153
     @Test
154 154
     public void testGetUrlJarWithoutFile() throws MalformedURLException {
155 155
         final URLBuilder urlBuilder
156
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
156
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
157 157
         Assert.assertNull(urlBuilder.getUrl("jar://jarFile"));
158 158
     }
159 159
 
160 160
     @Test
161 161
     public void testGetUrlZip() throws MalformedURLException {
162 162
         final URLBuilder urlBuilder
163
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
163
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
164 164
         Assert.assertEquals(new URL("jar:file:/zipFile!/testFile"), urlBuilder.getUrl("zip://zipFile:testFile"));
165 165
     }
166 166
 
167 167
     @Test
168 168
     public void testGetUrlZipWithoutFile() throws MalformedURLException {
169 169
         final URLBuilder urlBuilder
170
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
170
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
171 171
         Assert.assertNull(urlBuilder.getUrl("zip://zipFile"));
172 172
     }
173 173
 
174 174
     @Test
175 175
     public void testGetUrlPlugin() throws MalformedURLException {
176 176
         final URLBuilder urlBuilder
177
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
177
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
178 178
         Assert.assertEquals(new URL("jar:file:/testPlugin!/testFile"), urlBuilder.getUrl("plugin://pluginFile:testFile"));
179 179
     }
180 180
 
181 181
     @Test
182 182
     public void testGetUrlPluginWithoutFile() throws MalformedURLException {
183 183
         final URLBuilder urlBuilder
184
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
184
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
185 185
         Assert.assertNull(urlBuilder.getUrl("plugin://pluginFile"));
186 186
     }
187 187
 
188 188
     @Test
189 189
     public void testGetUrlTheme() throws MalformedURLException {
190 190
         final URLBuilder urlBuilder
191
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
191
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
192 192
         Assert.assertEquals(new URL("jar:file:/themes/themeFile.zip!/testFile"), urlBuilder.getUrl("theme://themeFile:testFile"));
193 193
     }
194 194
 
195 195
     @Test
196 196
     public void testGetUrlThemeWithoutFile() throws MalformedURLException {
197 197
         final URLBuilder urlBuilder
198
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
198
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
199 199
         Assert.assertNull(urlBuilder.getUrl("theme://themeFile"));
200 200
     }
201 201
 
202 202
     @Test
203 203
     public void testGetUrlHTTP() throws MalformedURLException {
204 204
         final URLBuilder urlBuilder
205
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
205
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
206 206
         Assert.assertEquals(new URL("http://testDomain"), urlBuilder.getUrl("http://testDomain"));
207 207
     }
208 208
 
209 209
     @Test
210 210
     public void testGetUrlHTTPInvalid() throws MalformedURLException {
211 211
         final URLBuilder urlBuilder
212
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
212
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
213 213
         Assert.assertNull(urlBuilder.getUrl("http://[testDomain"));
214 214
     }
215 215
 
216 216
     @Test
217 217
     public void testGetUrlFileWithPrefix() throws MalformedURLException {
218 218
         final URLBuilder urlBuilder
219
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
219
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
220 220
         Assert.assertEquals(new URL("file://testFile"), urlBuilder.getUrl("file://testFile"));
221 221
     }
222 222
 
223 223
     @Test
224 224
     public void testGetUrlFileWithoutPrefix() throws MalformedURLException {
225 225
         final URLBuilder urlBuilder
226
-                = new URLBuilder(pluginManagerProvider, themeManagerProvider, eventBus);
226
+                = new URLBuilder(pluginManagerProvider, themeManagerProvider);
227 227
         Assert.assertEquals(new URL("file://testFile"), urlBuilder.getUrl("testFile"));
228 228
     }
229 229
 }

Loading…
Откажи
Сачувај