Преглед изворни кода

Use User in Invite.

pull/258/head
Chris Smith пре 9 година
родитељ
комит
7661d5e45c

+ 5
- 6
src/com/dmdirc/Invite.java Прегледај датотеку

@@ -23,6 +23,7 @@
23 23
 package com.dmdirc;
24 24
 
25 25
 import com.dmdirc.interfaces.Connection;
26
+import com.dmdirc.interfaces.User;
26 27
 
27 28
 import java.util.Date;
28 29
 
@@ -38,7 +39,7 @@ public class Invite {
38 39
     /** The time this invite was created. */
39 40
     private final long timestamp;
40 41
     /** The source of this invite. */
41
-    private final String source;
42
+    private final User source;
42 43
 
43 44
     /**
44 45
      * Creates a new instance of Invite.
@@ -47,7 +48,7 @@ public class Invite {
47 48
      * @param channel    The channel that this invite is for
48 49
      * @param source     The source of this invite
49 50
      */
50
-    public Invite(final Connection connection, final String channel, final String source) {
51
+    public Invite(final Connection connection, final String channel, final User source) {
51 52
         this.connection = connection;
52 53
         this.channel = channel;
53 54
         this.source = source;
@@ -66,11 +67,9 @@ public class Invite {
66 67
      * Retrieves the source of this invite.
67 68
      *
68 69
      * @return This invite's source
69
-     *
70
-     * @see Server#parseHostmask(String)
71 70
      */
72
-    public String[] getSource() {
73
-        return connection.parseHostmask(source);
71
+    public User getSource() {
72
+        return source;
74 73
     }
75 74
 
76 75
     /**

+ 1
- 1
src/com/dmdirc/ServerEventHandler.java Прегледај датотеку

@@ -532,7 +532,7 @@ public class ServerEventHandler extends EventHandler implements
532 532
         checkParser(parser);
533 533
 
534 534
         final ClientInfo client = owner.getParser().get().getClient(userHost);
535
-        owner.addInvite(new Invite(owner, channel, userHost));
535
+        owner.addInvite(new Invite(owner, channel, owner.getUser(userHost).orElse(null)));
536 536
         final ServerInviteReceivedEvent event = new ServerInviteReceivedEvent(owner,
537 537
                 userFactory.getUser(client.getNickname(), owner.getConnection().get(),
538 538
                         Optional.ofNullable(client.getUsername()),

+ 14
- 12
test/com/dmdirc/InviteTest.java Прегледај датотеку

@@ -22,28 +22,33 @@
22 22
 
23 23
 package com.dmdirc;
24 24
 
25
+import com.dmdirc.interfaces.User;
26
+
25 27
 import java.util.Date;
26 28
 
27 29
 import org.junit.Before;
28 30
 import org.junit.Test;
31
+import org.junit.runner.RunWith;
32
+import org.mockito.Mock;
33
+import org.mockito.runners.MockitoJUnitRunner;
29 34
 
30
-import static org.junit.Assert.*;
31
-import static org.mockito.Mockito.*;
35
+import static org.junit.Assert.assertEquals;
36
+import static org.junit.Assert.assertTrue;
37
+import static org.mockito.Mockito.verify;
32 38
 
39
+@RunWith(MockitoJUnitRunner.class)
33 40
 public class InviteTest {
34 41
 
42
+    @Mock
35 43
     private Server server;
44
+    @Mock
45
+    private User user;
36 46
     private Invite invite;
37 47
     private long ts;
38 48
 
39 49
     @Before
40 50
     public void setUp() {
41
-        server = mock(Server.class);
42
-
43
-        when(server.parseHostmask("nick!ident@host"))
44
-                .thenReturn(new String[] {"nick", "ident", "host"});
45
-
46
-        invite = new Invite(server, "#channel", "nick!ident@host");
51
+        invite = new Invite(server, "#channel", user);
47 52
         ts = new Date().getTime();
48 53
     }
49 54
 
@@ -60,10 +65,7 @@ public class InviteTest {
60 65
 
61 66
     @Test
62 67
     public void testGetSource() {
63
-        assertEquals(3, invite.getSource().length);
64
-        assertEquals("nick", invite.getSource()[0]);
65
-        assertEquals("ident", invite.getSource()[1]);
66
-        assertEquals("host", invite.getSource()[2]);
68
+        assertEquals(user, invite.getSource());
67 69
     }
68 70
 
69 71
     @Test

+ 7
- 5
test/com/dmdirc/ServerTest.java Прегледај датотеку

@@ -25,14 +25,15 @@ package com.dmdirc;
25 25
 import com.dmdirc.commandparser.CommandType;
26 26
 import com.dmdirc.commandparser.parsers.CommandParser;
27 27
 import com.dmdirc.config.profiles.Profile;
28
+import com.dmdirc.interfaces.User;
28 29
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
29 30
 import com.dmdirc.interfaces.config.ConfigProvider;
30 31
 import com.dmdirc.interfaces.config.ConfigProviderMigrator;
31 32
 import com.dmdirc.interfaces.config.IdentityFactory;
32 33
 import com.dmdirc.ui.WindowManager;
33
-import com.dmdirc.ui.messages.BackBufferFactory;
34 34
 import com.dmdirc.ui.input.TabCompleter;
35 35
 import com.dmdirc.ui.input.TabCompleterFactory;
36
+import com.dmdirc.ui.messages.BackBufferFactory;
36 37
 import com.dmdirc.ui.messages.sink.MessageSinkManager;
37 38
 import com.dmdirc.util.URLBuilder;
38 39
 
@@ -73,6 +74,7 @@ public class ServerTest {
73 74
     @Mock private MessageEncoderFactory messageEncoderFactory;
74 75
     @Mock private BackBufferFactory backBufferFactory;
75 76
     @Mock private UserFactory userFactory;
77
+    @Mock private User user;
76 78
 
77 79
     private Server server;
78 80
 
@@ -126,16 +128,16 @@ public class ServerTest {
126 128
 
127 129
     @Test
128 130
     public void testDuplicateInviteRemoval() {
129
-        server.addInvite(new Invite(server, "#chan1", "a!b@c"));
130
-        server.addInvite(new Invite(server, "#chan1", "d!e@f"));
131
+        server.addInvite(new Invite(server, "#chan1", user));
132
+        server.addInvite(new Invite(server, "#chan1", user));
131 133
 
132 134
         assertEquals(1, server.getInvites().size());
133 135
     }
134 136
 
135 137
     @Test
136 138
     public void testRemoveInvites() {
137
-        server.addInvite(new Invite(server, "#chan1", "a!b@c"));
138
-        server.addInvite(new Invite(server, "#chan2", "d!e@f"));
139
+        server.addInvite(new Invite(server, "#chan1", user));
140
+        server.addInvite(new Invite(server, "#chan2", user));
139 141
 
140 142
         server.removeInvites("#chan1");
141 143
         assertEquals(1, server.getInvites().size());

Loading…
Откажи
Сачувај