Bläddra i källkod

fix some unit tests, fix some other things i cant remember

tags/0.6.3m1rc1
Gregory Holmes 15 år sedan
förälder
incheckning
6dbacd1161

+ 8
- 8
src/com/dmdirc/addons/ui_swing/dialogs/profiles/ProfileDetailPanel.java Visa fil

22
 
22
 
23
 package com.dmdirc.addons.ui_swing.dialogs.profiles;
23
 package com.dmdirc.addons.ui_swing.dialogs.profiles;
24
 
24
 
25
+import com.dmdirc.addons.ui_swing.MainFrame;
25
 import com.dmdirc.config.prefs.validator.FileNameValidator;
26
 import com.dmdirc.config.prefs.validator.FileNameValidator;
26
 import com.dmdirc.config.prefs.validator.IdentValidator;
27
 import com.dmdirc.config.prefs.validator.IdentValidator;
27
 import com.dmdirc.config.prefs.validator.NicknameValidator;
28
 import com.dmdirc.config.prefs.validator.NicknameValidator;
31
 import com.dmdirc.addons.ui_swing.components.validating.ValidatingJTextField;
32
 import com.dmdirc.addons.ui_swing.components.validating.ValidatingJTextField;
32
 
33
 
33
 import java.awt.Dialog.ModalityType;
34
 import java.awt.Dialog.ModalityType;
34
-import java.awt.Window;
35
 import java.awt.event.ActionEvent;
35
 import java.awt.event.ActionEvent;
36
 import java.awt.event.ActionListener;
36
 import java.awt.event.ActionListener;
37
 import java.util.ArrayList;
37
 import java.util.ArrayList;
79
     private JButton delButton;
79
     private JButton delButton;
80
     /** Edit button. */
80
     /** Edit button. */
81
     private JButton editButton;
81
     private JButton editButton;
82
-    /** Parent window. */
83
-    private Window parentWindow;
82
+    /** Main frame. */
83
+    private MainFrame mainFrame;
84
 
84
 
85
     /**
85
     /**
86
      * Creates a new profile detail panel.
86
      * Creates a new profile detail panel.
87
      * 
87
      * 
88
      * @param model The list model to use to validate names
88
      * @param model The list model to use to validate names
89
-     * @param parentWindow Parent window
89
+     * @param mainFrame Main frame
90
      */
90
      */
91
     public ProfileDetailPanel(final ProfileListModel model,
91
     public ProfileDetailPanel(final ProfileListModel model,
92
-            final Window parentWindow) {
92
+            final MainFrame mainFrame) {
93
         super();
93
         super();
94
-        this.parentWindow = parentWindow;
94
+        this.mainFrame = mainFrame;
95
 
95
 
96
         this.model = model;
96
         this.model = model;
97
 
97
 
230
     @Override
230
     @Override
231
     public void actionPerformed(final ActionEvent e) {
231
     public void actionPerformed(final ActionEvent e) {
232
         if (e.getSource() == addButton) {
232
         if (e.getSource() == addButton) {
233
-            new StandardInputDialog(ProfileManagerDialog.getProfileManagerDialog(parentWindow),
233
+            new StandardInputDialog(ProfileManagerDialog.getProfileManagerDialog(mainFrame),
234
                     ModalityType.DOCUMENT_MODAL, "New Nickname",
234
                     ModalityType.DOCUMENT_MODAL, "New Nickname",
235
                     "Please enter the new nickname", new NicknameValidator()) {
235
                     "Please enter the new nickname", new NicknameValidator()) {
236
 
236
 
256
             }.display();
256
             }.display();
257
         } else if (e.getSource() == editButton) {
257
         } else if (e.getSource() == editButton) {
258
             final StandardInputDialog dialog = new StandardInputDialog(
258
             final StandardInputDialog dialog = new StandardInputDialog(
259
-                    ProfileManagerDialog.getProfileManagerDialog(parentWindow),
259
+                    ProfileManagerDialog.getProfileManagerDialog(mainFrame),
260
                     ModalityType.DOCUMENT_MODAL, "Edit Nickname",
260
                     ModalityType.DOCUMENT_MODAL, "Edit Nickname",
261
                     "Please enter the new nickname", new NicknameValidator()) {
261
                     "Please enter the new nickname", new NicknameValidator()) {
262
 
262
 

+ 16
- 16
src/com/dmdirc/addons/ui_swing/dialogs/profiles/ProfileManagerDialog.java Visa fil

22
 
22
 
23
 package com.dmdirc.addons.ui_swing.dialogs.profiles;
23
 package com.dmdirc.addons.ui_swing.dialogs.profiles;
24
 
24
 
25
+import com.dmdirc.addons.ui_swing.MainFrame;
25
 import com.dmdirc.config.Identity;
26
 import com.dmdirc.config.Identity;
26
 import com.dmdirc.config.IdentityManager;
27
 import com.dmdirc.config.IdentityManager;
27
 import com.dmdirc.addons.ui_swing.components.ListScroller;
28
 import com.dmdirc.addons.ui_swing.components.ListScroller;
31
 import com.dmdirc.addons.ui_swing.dialogs.NewServerDialog;
32
 import com.dmdirc.addons.ui_swing.dialogs.NewServerDialog;
32
 
33
 
33
 import java.awt.Dialog.ModalityType;
34
 import java.awt.Dialog.ModalityType;
34
-import java.awt.Window;
35
 import java.awt.event.ActionEvent;
35
 import java.awt.event.ActionEvent;
36
 import java.awt.event.ActionListener;
36
 import java.awt.event.ActionListener;
37
 import java.util.ArrayList;
37
 import java.util.ArrayList;
77
     private int selectedIndex;
77
     private int selectedIndex;
78
     /** Deleted profiles. */
78
     /** Deleted profiles. */
79
     private final List<Profile> deletedProfiles;
79
     private final List<Profile> deletedProfiles;
80
-    /** Parent window. */
81
-    private Window parentWindow;
80
+    /** main frame. */
81
+    private MainFrame mainFrame;
82
 
82
 
83
     /** 
83
     /** 
84
      * Creates a new instance of ProfileEditorDialog. 
84
      * Creates a new instance of ProfileEditorDialog. 
85
      * 
85
      * 
86
-     * @param parentWindow Parent window
86
+     * @param parentWindow main frame
87
      */
87
      */
88
-    private ProfileManagerDialog(final Window parentWindow) {
89
-        super(parentWindow, ModalityType.MODELESS);
90
-        this.parentWindow = parentWindow;
88
+    private ProfileManagerDialog(final MainFrame mainFrame) {
89
+        super(mainFrame, ModalityType.MODELESS);
90
+        this.mainFrame = mainFrame;
91
         deletedProfiles = new ArrayList<Profile>();
91
         deletedProfiles = new ArrayList<Profile>();
92
 
92
 
93
         initComponents();
93
         initComponents();
106
     /** 
106
     /** 
107
      * Creates the dialog if one doesn't exist, and displays it. 
107
      * Creates the dialog if one doesn't exist, and displays it. 
108
      * 
108
      * 
109
-     * @param parentWindow Parent window
109
+     * @param mainFrame Main frame
110
      */
110
      */
111
-    public static void showProfileManagerDialog(final Window parentWindow) {
112
-        me = getProfileManagerDialog(parentWindow);
111
+    public static void showProfileManagerDialog(final MainFrame mainFrame) {
112
+        me = getProfileManagerDialog(mainFrame);
113
 
113
 
114
         me.pack();
114
         me.pack();
115
-        me.setLocationRelativeTo(parentWindow);
115
+        me.setLocationRelativeTo(mainFrame);
116
         me.setVisible(true);
116
         me.setVisible(true);
117
         me.requestFocusInWindow();
117
         me.requestFocusInWindow();
118
     }
118
     }
120
     /**
120
     /**
121
      * Returns the current instance of the ProfileManagerDialog.
121
      * Returns the current instance of the ProfileManagerDialog.
122
      * 
122
      * 
123
-     * @param parentWindow Parent window
123
+     * @param mainFrame Main frame
124
      *
124
      *
125
      * @return The current ProfileManagerDialog instance
125
      * @return The current ProfileManagerDialog instance
126
      */
126
      */
127
-    public static ProfileManagerDialog getProfileManagerDialog(final Window parentWindow) {
127
+    public static ProfileManagerDialog getProfileManagerDialog(final MainFrame mainFrame) {
128
         synchronized (ProfileManagerDialog.class) {
128
         synchronized (ProfileManagerDialog.class) {
129
             if (me == null) {
129
             if (me == null) {
130
-                me = new ProfileManagerDialog(parentWindow);
130
+                me = new ProfileManagerDialog(mainFrame);
131
             }
131
             }
132
         }
132
         }
133
 
133
 
144
 
144
 
145
         model = new ProfileListModel();
145
         model = new ProfileListModel();
146
         profileList = new JList(model);
146
         profileList = new JList(model);
147
-        details = new ProfileDetailPanel(model, parentWindow);
147
+        details = new ProfileDetailPanel(model, mainFrame);
148
         addButton = new JButton("Add");
148
         addButton = new JButton("Add");
149
         deleteButton = new JButton("Delete");
149
         deleteButton = new JButton("Delete");
150
         infoLabel =
150
         infoLabel =
217
             dispose();
217
             dispose();
218
         }
218
         }
219
         if (NewServerDialog.isNewServerDialogShowing()) {
219
         if (NewServerDialog.isNewServerDialogShowing()) {
220
-            NewServerDialog.getNewServerDialog(parentWindow).populateProfiles();
220
+            NewServerDialog.getNewServerDialog(mainFrame).populateProfiles();
221
         }
221
         }
222
     }
222
     }
223
 
223
 

+ 2
- 1
src/com/dmdirc/addons/ui_swing/wizard/firstrun/SwingFirstRunWizard.java Visa fil

26
 import com.dmdirc.actions.ActionManager;
26
 import com.dmdirc.actions.ActionManager;
27
 import com.dmdirc.actions.CoreActionType;
27
 import com.dmdirc.actions.CoreActionType;
28
 import com.dmdirc.actions.interfaces.ActionType;
28
 import com.dmdirc.actions.interfaces.ActionType;
29
+import com.dmdirc.addons.ui_swing.MainFrame;
29
 import com.dmdirc.config.IdentityManager;
30
 import com.dmdirc.config.IdentityManager;
30
 import com.dmdirc.interfaces.ActionListener;
31
 import com.dmdirc.interfaces.ActionListener;
31
 import com.dmdirc.logger.ErrorLevel;
32
 import com.dmdirc.logger.ErrorLevel;
103
                 @Override
104
                 @Override
104
                 public void processEvent(final ActionType type,
105
                 public void processEvent(final ActionType type,
105
                         final StringBuffer format, final Object... arguments) {
106
                         final StringBuffer format, final Object... arguments) {
106
-                    ProfileManagerDialog.showProfileManagerDialog(wizardDialog);
107
+                    ProfileManagerDialog.showProfileManagerDialog((MainFrame) Main.getUI().getMainWindow());
107
                 }
108
                 }
108
             }, CoreActionType.CLIENT_OPENED);
109
             }, CoreActionType.CLIENT_OPENED);
109
             
110
             

+ 1
- 1
test/com/dmdirc/addons/ui_swing/MainFrameTest.java Visa fil

63
     @Before
63
     @Before
64
     public void setUp() {
64
     public void setUp() {
65
         if (window == null) {
65
         if (window == null) {
66
-            window = new FrameFixture(SwingController.getMainFrame());
66
+            window = new FrameFixture((MainFrame) Main.getUI().getMainWindow());
67
             window.show();
67
             window.show();
68
         }
68
         }
69
     }
69
     }

+ 4
- 2
test/com/dmdirc/addons/ui_swing/components/frames/InputTextFrameTest.java Visa fil

25
 import com.dmdirc.addons.ui_swing.components.*;
25
 import com.dmdirc.addons.ui_swing.components.*;
26
 import com.dmdirc.addons.ui_swing.components.frames.InputTextFrame;
26
 import com.dmdirc.addons.ui_swing.components.frames.InputTextFrame;
27
 import com.dmdirc.Main;
27
 import com.dmdirc.Main;
28
+import com.dmdirc.addons.ui_swing.MainFrame;
28
 import com.dmdirc.commandparser.parsers.GlobalCommandParser;
29
 import com.dmdirc.commandparser.parsers.GlobalCommandParser;
29
 import com.dmdirc.config.ConfigManager;
30
 import com.dmdirc.config.ConfigManager;
30
 import com.dmdirc.config.IdentityManager;
31
 import com.dmdirc.config.IdentityManager;
147
     protected void setupWindow(final ConfigManager configManager) {
148
     protected void setupWindow(final ConfigManager configManager) {
148
         UIUtilities.initUISettings();
149
         UIUtilities.initUISettings();
149
 
150
 
150
-        mainframe = new FrameFixture(SwingController.getMainFrame());
151
+        mainframe = new FrameFixture((MainFrame) Main.getUI().getMainWindow());
151
         mainframe.robot.settings().eventMode(EventMode.AWT);
152
         mainframe.robot.settings().eventMode(EventMode.AWT);
152
 
153
 
153
         final CustomInputFrame titf = new CustomInputFrame(owner,
154
         final CustomInputFrame titf = new CustomInputFrame(owner,
154
-                GlobalCommandParser.getGlobalCommandParser());
155
+                GlobalCommandParser.getGlobalCommandParser(), 
156
+                (SwingController) Main.getUI());
155
 
157
 
156
         titf.setTitle("testing123");
158
         titf.setTitle("testing123");
157
 
159
 

+ 1
- 0
test/com/dmdirc/harness/TestCommandParser.java Visa fil

30
 import com.dmdirc.ui.interfaces.InputWindow;
30
 import com.dmdirc.ui.interfaces.InputWindow;
31
 
31
 
32
 public class TestCommandParser extends CommandParser {
32
 public class TestCommandParser extends CommandParser {
33
+    private static final long serialVersionUID = 7073002401375438532L;
33
 
34
 
34
     public String nonCommandLine;
35
     public String nonCommandLine;
35
 
36
 

+ 1
- 0
test/com/dmdirc/harness/TestConfigManagerMap.java Visa fil

27
 import java.util.Map;
27
 import java.util.Map;
28
 
28
 
29
 public class TestConfigManagerMap extends ConfigManager {
29
 public class TestConfigManagerMap extends ConfigManager {
30
+    private static final long serialVersionUID = 3604727894041756961L;
30
 
31
 
31
     public final Map<String, String> settings =
32
     public final Map<String, String> settings =
32
             new HashMap<String, String>();
33
             new HashMap<String, String>();

+ 1
- 0
test/com/dmdirc/harness/TestConfigManagerOptionToggle.java Visa fil

25
 import com.dmdirc.config.ConfigManager;
25
 import com.dmdirc.config.ConfigManager;
26
 
26
 
27
 public class TestConfigManagerOptionToggle extends ConfigManager {
27
 public class TestConfigManagerOptionToggle extends ConfigManager {
28
+    private static final long serialVersionUID = 8078917248288638755L;
28
 
29
 
29
     public TestConfigManagerOptionToggle() {
30
     public TestConfigManagerOptionToggle() {
30
         super(null, null, null);
31
         super(null, null, null);

Laddar…
Avbryt
Spara