fixes external prefs categories not receiving save events, fixed some padding issues with the category panel, fixes issue 2134

src/com/dmdirc/addons/ui_swing/dialogs/prefs/CategoryPanel.java

@@ -101,7 +101,7 @@ public class CategoryPanel extends JPanel {
      */
     public CategoryPanel(final Window parent,
             final PreferencesCategory category) {
-        super(new MigLayout("fillx, wrap"));
+        super(new MigLayout("fillx, wrap, ins 0"));
         this.parent = parent;
 
         loading = new JPanel(new MigLayout("fillx"));

src/com/dmdirc/addons/ui_swing/dialogs/prefs/SwingPreferencesDialog.java

@@ -150,9 +150,9 @@ public final class SwingPreferencesDialog extends StandardDialog implements
         getOkButton().addActionListener(this);
         getCancelButton().addActionListener(this);
 
-        setLayout(new MigLayout("fillx, wmax 650, hmin 600, hmax 600, pack"));
+        setLayout(new MigLayout("fillx, wmax 650, hmin 600, hmax 600, pack, debug"));
         add(tabList, "w 150!, growy, spany 3");
-        add(mainPanel, "wrap, w 480!, pushy");
+        add(mainPanel, "wrap, w 480!, pushy, growy");
         add(getLeftButton(), "span, split, right");
         add(getRightButton(), "right");
     }
@@ -242,7 +242,7 @@ public final class SwingPreferencesDialog extends StandardDialog implements
         final DefaultListModel model = (DefaultListModel) tabList.getModel();
         int indexToSelect = 1;
         int size = model.getSize();
-        for (int i = 0; i <= size; i++) {
+        for (int i = 0; i < size; i++) {
             final PreferencesCategory category =
                     (PreferencesCategory) model.get(i);
             if (oldCategoryPath.equals(category.getPath())) {

src/com/dmdirc/config/prefs/PreferencesManager.java

@@ -114,6 +114,8 @@ public class PreferencesManager {
      * Dismisses all the settings in this manager.
      */
     public void dismiss() {
+        fireSaveListeners();
+        
         for (PreferencesCategory category : categories) {
             category.dismiss();
         }