Change some .isEmpty()s

src/com/dmdirc/Channel.java

@@ -299,7 +299,7 @@ public final class Channel extends MessageTarget
     private void updateTitle() {
         String temp = Styliser.stipControlCodes(channelInfo.getName());
 
-        if (!channelInfo.getTopic().isEmpty()) {
+        if (channelInfo.getTopic().length() > 0) {
             temp = temp + " - " + Styliser.stipControlCodes(channelInfo.getTopic());
         }
 

src/com/dmdirc/ChannelEventHandler.java

@@ -143,7 +143,7 @@ public final class ChannelEventHandler extends EventHandler implements
 
         owner.doNotification("channel"
                 + (isMyself(cChannelClient) ? "Self" : "") + "Part"
-                + (sReason.isEmpty() ? "" : "Reason"), CoreActionType.CHANNEL_PART,
+                + (sReason.length() == 0 ? "" : "Reason"), CoreActionType.CHANNEL_PART,
                 cChannelClient, sReason);
         owner.removeClient(cChannelClient);
     }
@@ -155,7 +155,7 @@ public final class ChannelEventHandler extends EventHandler implements
             final String sReason, final String sKickedByHost) {
         checkParser(tParser);
 
-        owner.doNotification("channelKick" + (sReason.isEmpty() ? "" : "Reason"),
+        owner.doNotification("channelKick" + (sReason.length() == 0 ? "" : "Reason"),
                 CoreActionType.CHANNEL_KICK, cKickedByClient, cKickedClient, sReason);
         owner.removeClient(cKickedClient);
     }
@@ -166,7 +166,7 @@ public final class ChannelEventHandler extends EventHandler implements
             final ChannelClientInfo cChannelClient, final String sReason) {
         checkParser(tParser);
 
-        owner.doNotification("channelQuit" + (sReason.isEmpty() ? "" : "Reason"),
+        owner.doNotification("channelQuit" + (sReason.length() == 0 ? "" : "Reason"),
                 CoreActionType.CHANNEL_QUIT, cChannelClient, sReason);
         owner.removeClient(cChannelClient);
     }
@@ -202,7 +202,7 @@ public final class ChannelEventHandler extends EventHandler implements
             final String sModes) {
         checkParser(tParser);
 
-        if (sHost.isEmpty()) {
+        if (sHost.length() == 0) {
             owner.doNotification(sModes.length() <= 1 ? "channelNoModes"
                     : "channelModeDiscovered", CoreActionType.CHANNEL_MODESDISCOVERED,
                     sModes.length() <= 1 ? "" : sModes);

src/com/dmdirc/Query.java

@@ -296,7 +296,7 @@ public final class Query extends MessageTarget implements
     public void onQuit(final IRCParser tParser, final ClientInfo cClient,
             final String sReason) {
         if (cClient.getNickname().equals(ClientInfo.parseHost(host))) {
-            final StringBuffer format = new StringBuffer(sReason.isEmpty()
+            final StringBuffer format = new StringBuffer(sReason.length() == 0
                 ? "queryQuit" : "queryQuitReason");
 
             ActionManager.processEvent(CoreActionType.QUERY_QUIT, format, this, sReason);

src/com/dmdirc/Server.java

@@ -792,7 +792,7 @@ public final class Server extends WritableFrameContainer implements Serializable
         if (parser == null) {
             throw new IllegalStateException("getNetwork called when "
                     + "parser is null (state: " + getState() + ")");
-        } else if (parser.getNetworkName().isEmpty()) {
+        } else if (parser.getNetworkName().length() == 0) {
             return getNetworkFromServerName(parser.getServerName());
         } else {
             return parser.getNetworkName();
@@ -1100,7 +1100,7 @@ public final class Server extends WritableFrameContainer implements Serializable
             }
         }
 
-        if (offset < alts.size() && !alts.get(offset).isEmpty()) {
+        if (offset < alts.size() && alts.get(offset).length() > 0) {
             newNick = alts.get(offset);
         }
 

src/com/dmdirc/WritableFrameContainer.java

@@ -93,7 +93,7 @@ public abstract class WritableFrameContainer extends FrameContainer {
         int lines = 0;
         
         for (String splitLine : splitLines) {
-            if (splitLine.isEmpty() || getMaxLineLength() <= 0) {
+            if (splitLine.length() == 0 || getMaxLineLength() <= 0) {
                 lines++;
             } else {
                 lines += (int) Math.ceil(splitLine.length() / (double) getMaxLineLength());

src/com/dmdirc/util/CipherUtils.java

@@ -234,7 +234,7 @@ public class CipherUtils {
                         "passwordHash");
             }
 
-            while ((password == null || password.isEmpty()) && tries < AUTH_TRIES) {
+            while ((password == null || password.length() == 0) && tries < AUTH_TRIES) {
                 password = getPassword(prompt);
                 if (passwordHash == null) {
                     passwordHash = hash(password);

src/com/dmdirc/util/ConfigFile.java

@@ -112,12 +112,12 @@ public class ConfigFile extends TextFile {
         for (String line : getLines()) {
             String tline = line;
             
-            while (!tline.isEmpty() && (tline.charAt(0) == '\t' || 
+            while (tline.length() > 0 && (tline.charAt(0) == '\t' || 
                     tline.charAt(0) == ' ')) {
                 tline = tline.substring(1);
             }
 
-            if (tline.indexOf('#') == 0 || tline.isEmpty()) {
+            if (tline.indexOf('#') == 0 || tline.length() == 0) {
                 continue;
             } else if (
                     (tline.endsWith(":") && !tline.endsWith("\\:"))

src/com/dmdirc/util/IrcAddress.java

@@ -128,7 +128,7 @@ public class IrcAddress implements Serializable {
         for (String channel : channels.substring(1).split(",")) {
             if (!channel.equalsIgnoreCase("needpass") && 
                     !channel.equalsIgnoreCase("needkey") &&
-                    !channel.equalsIgnoreCase("isnick") && !channel.isEmpty()) {
+                    !channel.equalsIgnoreCase("isnick") && channel.length() > 0) {
                 this.channels.add(channel);
             }
         }

src/com/dmdirc/util/URLHandler.java

@@ -131,7 +131,7 @@ public class URLHandler {
 
         final String command = config.getOption("protocol", uri.getScheme(), "");
 
-        if (command.isEmpty()) {
+        if (command.length() == 0) {
             Main.getUI().showURLDialog(uri);
             return;
         }
@@ -200,7 +200,7 @@ public class URLHandler {
             port = String.valueOf(url.getPort());
         }
 
-        if (userInfo != null && !userInfo.isEmpty()) {
+        if (userInfo != null && userInfo.length() > 0) {
             if (userInfo.indexOf(':') == -1) {
                 username = userInfo;
             } else {