Browse Source

Fix test deprecations.

pull/718/head
Chris Smith 7 years ago
parent
commit
23300340c1
30 changed files with 77 additions and 105 deletions
  1. 3
    7
      src/test/java/com/dmdirc/ServerManagerTest.java
  2. 1
    3
      src/test/java/com/dmdirc/commandparser/aliases/AliasLoaderTest.java
  3. 2
    2
      src/test/java/com/dmdirc/commandparser/aliases/AliasManagerTest.java
  4. 1
    1
      src/test/java/com/dmdirc/commandparser/commands/channel/BanTest.java
  5. 1
    1
      src/test/java/com/dmdirc/commandparser/commands/channel/KickReasonTest.java
  6. 2
    4
      src/test/java/com/dmdirc/commandparser/commands/channel/SetNickColourTest.java
  7. 1
    1
      src/test/java/com/dmdirc/commandparser/commands/chat/MeTest.java
  8. 1
    1
      src/test/java/com/dmdirc/commandparser/commands/global/AliasCommandTest.java
  9. 1
    1
      src/test/java/com/dmdirc/commandparser/commands/global/IfpluginTest.java
  10. 3
    7
      src/test/java/com/dmdirc/commandparser/commands/global/NewServerTest.java
  11. 3
    3
      src/test/java/com/dmdirc/commandparser/commands/server/ChangeServerTest.java
  12. 3
    3
      src/test/java/com/dmdirc/config/ConfigBinderImplTest.java
  13. 1
    1
      src/test/java/com/dmdirc/config/ConfigFileBackedConfigProviderTest.java
  14. 1
    1
      src/test/java/com/dmdirc/config/prefs/PreferencesDialogModelTest.java
  15. 1
    1
      src/test/java/com/dmdirc/config/prefs/PreferencesManagerTest.java
  16. 1
    1
      src/test/java/com/dmdirc/config/profiles/ProfileManagerTest.java
  17. 7
    11
      src/test/java/com/dmdirc/logger/SentryErrorReporterTest.java
  18. 3
    3
      src/test/java/com/dmdirc/logger/SentryLoggingErrorManagerTest.java
  19. 12
    11
      src/test/java/com/dmdirc/ui/WindowManagerTest.java
  20. 2
    2
      src/test/java/com/dmdirc/ui/core/aliases/CoreAliasDialogModelTest.java
  21. 1
    1
      src/test/java/com/dmdirc/ui/core/autocommands/CoreGlobalAutoCommandsDialogModelTest.java
  22. 0
    4
      src/test/java/com/dmdirc/ui/core/feedback/CoreFeedbackDialogModelTest.java
  23. 5
    11
      src/test/java/com/dmdirc/ui/core/feedback/FeedbackSenderTest.java
  24. 1
    1
      src/test/java/com/dmdirc/ui/core/newserver/CoreNewServerDialogModelTest.java
  25. 10
    13
      src/test/java/com/dmdirc/ui/core/profiles/CoreProfilesDialogModelTest.java
  26. 4
    4
      src/test/java/com/dmdirc/ui/messages/FormatterTest.java
  27. 1
    1
      src/test/java/com/dmdirc/ui/messages/HighlightManagerTest.java
  28. 1
    1
      src/test/java/com/dmdirc/updater/checking/NightlyCheckerTest.java
  29. 2
    2
      src/test/java/com/dmdirc/updater/installing/LegacyInstallationStrategyTest.java
  30. 2
    2
      src/test/java/com/dmdirc/util/URLBuilderTest.java

+ 3
- 7
src/test/java/com/dmdirc/ServerManagerTest.java View File

27
 import com.dmdirc.interfaces.EventBus;
27
 import com.dmdirc.interfaces.EventBus;
28
 import com.dmdirc.interfaces.GroupChatManager;
28
 import com.dmdirc.interfaces.GroupChatManager;
29
 import com.dmdirc.interfaces.WindowModel;
29
 import com.dmdirc.interfaces.WindowModel;
30
-import com.dmdirc.interfaces.config.AggregateConfigProvider;
31
 import com.dmdirc.interfaces.config.ConfigProviderMigrator;
30
 import com.dmdirc.interfaces.config.ConfigProviderMigrator;
32
 import com.dmdirc.interfaces.config.IdentityFactory;
31
 import com.dmdirc.interfaces.config.IdentityFactory;
33
 import com.dmdirc.parser.common.ChannelJoinRequest;
32
 import com.dmdirc.parser.common.ChannelJoinRequest;
34
 import com.dmdirc.ui.WindowManager;
33
 import com.dmdirc.ui.WindowManager;
35
-
36
 import java.net.URI;
34
 import java.net.URI;
37
-import java.util.Collections;
38
 import java.util.Optional;
35
 import java.util.Optional;
39
 import java.util.concurrent.ScheduledExecutorService;
36
 import java.util.concurrent.ScheduledExecutorService;
40
-
41
 import org.junit.Before;
37
 import org.junit.Before;
42
 import org.junit.Test;
38
 import org.junit.Test;
43
 import org.junit.runner.RunWith;
39
 import org.junit.runner.RunWith;
47
 import org.mockito.runners.MockitoJUnitRunner;
43
 import org.mockito.runners.MockitoJUnitRunner;
48
 
44
 
49
 import static org.junit.Assert.assertEquals;
45
 import static org.junit.Assert.assertEquals;
50
-import static org.mockito.Matchers.any;
51
-import static org.mockito.Matchers.anyString;
52
-import static org.mockito.Matchers.eq;
46
+import static org.mockito.ArgumentMatchers.any;
47
+import static org.mockito.ArgumentMatchers.anyString;
48
+import static org.mockito.ArgumentMatchers.eq;
53
 import static org.mockito.Mockito.mock;
49
 import static org.mockito.Mockito.mock;
54
 import static org.mockito.Mockito.verify;
50
 import static org.mockito.Mockito.verify;
55
 import static org.mockito.Mockito.when;
51
 import static org.mockito.Mockito.when;

+ 1
- 3
src/test/java/com/dmdirc/commandparser/aliases/AliasLoaderTest.java View File

23
 package com.dmdirc.commandparser.aliases;
23
 package com.dmdirc.commandparser.aliases;
24
 
24
 
25
 import com.google.common.collect.Sets;
25
 import com.google.common.collect.Sets;
26
-
27
 import java.util.Set;
26
 import java.util.Set;
28
-
29
 import org.junit.Before;
27
 import org.junit.Before;
30
 import org.junit.Test;
28
 import org.junit.Test;
31
 import org.junit.runner.RunWith;
29
 import org.junit.runner.RunWith;
32
 import org.mockito.Mock;
30
 import org.mockito.Mock;
33
 import org.mockito.runners.MockitoJUnitRunner;
31
 import org.mockito.runners.MockitoJUnitRunner;
34
 
32
 
35
-import static org.mockito.Matchers.anySetOf;
33
+import static org.mockito.ArgumentMatchers.anySetOf;
36
 import static org.mockito.Mockito.never;
34
 import static org.mockito.Mockito.never;
37
 import static org.mockito.Mockito.verify;
35
 import static org.mockito.Mockito.verify;
38
 import static org.mockito.Mockito.when;
36
 import static org.mockito.Mockito.when;

+ 2
- 2
src/test/java/com/dmdirc/commandparser/aliases/AliasManagerTest.java View File

36
 
36
 
37
 import static org.junit.Assert.assertEquals;
37
 import static org.junit.Assert.assertEquals;
38
 import static org.junit.Assert.assertTrue;
38
 import static org.junit.Assert.assertTrue;
39
-import static org.mockito.Matchers.any;
40
-import static org.mockito.Matchers.eq;
39
+import static org.mockito.ArgumentMatchers.any;
40
+import static org.mockito.ArgumentMatchers.eq;
41
 import static org.mockito.Mockito.verify;
41
 import static org.mockito.Mockito.verify;
42
 
42
 
43
 @RunWith(MockitoJUnitRunner.class)
43
 @RunWith(MockitoJUnitRunner.class)

+ 1
- 1
src/test/java/com/dmdirc/commandparser/commands/channel/BanTest.java View File

41
 import org.mockito.Mock;
41
 import org.mockito.Mock;
42
 import org.mockito.runners.MockitoJUnitRunner;
42
 import org.mockito.runners.MockitoJUnitRunner;
43
 
43
 
44
-import static org.mockito.Matchers.isA;
44
+import static org.mockito.ArgumentMatchers.isA;
45
 import static org.mockito.Mockito.verify;
45
 import static org.mockito.Mockito.verify;
46
 import static org.mockito.Mockito.when;
46
 import static org.mockito.Mockito.when;
47
 
47
 

+ 1
- 1
src/test/java/com/dmdirc/commandparser/commands/channel/KickReasonTest.java View File

44
 import org.mockito.runners.MockitoJUnitRunner;
44
 import org.mockito.runners.MockitoJUnitRunner;
45
 
45
 
46
 import static org.junit.Assert.assertTrue;
46
 import static org.junit.Assert.assertTrue;
47
-import static org.mockito.Matchers.isA;
47
+import static org.mockito.ArgumentMatchers.isA;
48
 import static org.mockito.Mockito.verify;
48
 import static org.mockito.Mockito.verify;
49
 import static org.mockito.Mockito.when;
49
 import static org.mockito.Mockito.when;
50
 
50
 

+ 2
- 4
src/test/java/com/dmdirc/commandparser/commands/channel/SetNickColourTest.java View File

35
 import com.dmdirc.ui.messages.ColourManager;
35
 import com.dmdirc.ui.messages.ColourManager;
36
 import com.dmdirc.ui.messages.ColourManagerFactory;
36
 import com.dmdirc.ui.messages.ColourManagerFactory;
37
 import com.dmdirc.util.colours.Colour;
37
 import com.dmdirc.util.colours.Colour;
38
-
39
 import java.util.Optional;
38
 import java.util.Optional;
40
-
41
 import org.junit.Before;
39
 import org.junit.Before;
42
 import org.junit.Test;
40
 import org.junit.Test;
43
 import org.junit.runner.RunWith;
41
 import org.junit.runner.RunWith;
47
 import org.mockito.runners.MockitoJUnitRunner;
45
 import org.mockito.runners.MockitoJUnitRunner;
48
 
46
 
49
 import static org.junit.Assert.assertEquals;
47
 import static org.junit.Assert.assertEquals;
50
-import static org.mockito.Matchers.any;
51
-import static org.mockito.Matchers.isA;
48
+import static org.mockito.ArgumentMatchers.any;
49
+import static org.mockito.ArgumentMatchers.isA;
52
 import static org.mockito.Mockito.eq;
50
 import static org.mockito.Mockito.eq;
53
 import static org.mockito.Mockito.never;
51
 import static org.mockito.Mockito.never;
54
 import static org.mockito.Mockito.verify;
52
 import static org.mockito.Mockito.verify;

+ 1
- 1
src/test/java/com/dmdirc/commandparser/commands/chat/MeTest.java View File

35
 import org.mockito.Mock;
35
 import org.mockito.Mock;
36
 import org.mockito.runners.MockitoJUnitRunner;
36
 import org.mockito.runners.MockitoJUnitRunner;
37
 
37
 
38
-import static org.mockito.Matchers.isA;
38
+import static org.mockito.ArgumentMatchers.isA;
39
 import static org.mockito.Mockito.verify;
39
 import static org.mockito.Mockito.verify;
40
 import static org.mockito.Mockito.when;
40
 import static org.mockito.Mockito.when;
41
 
41
 

+ 1
- 1
src/test/java/com/dmdirc/commandparser/commands/global/AliasCommandTest.java View File

37
 import org.mockito.Mock;
37
 import org.mockito.Mock;
38
 import org.mockito.runners.MockitoJUnitRunner;
38
 import org.mockito.runners.MockitoJUnitRunner;
39
 
39
 
40
-import static org.mockito.Matchers.isA;
40
+import static org.mockito.ArgumentMatchers.isA;
41
 import static org.mockito.Mockito.verify;
41
 import static org.mockito.Mockito.verify;
42
 import static org.mockito.Mockito.when;
42
 import static org.mockito.Mockito.when;
43
 
43
 

+ 1
- 1
src/test/java/com/dmdirc/commandparser/commands/global/IfpluginTest.java View File

40
 import org.mockito.Mock;
40
 import org.mockito.Mock;
41
 import org.mockito.runners.MockitoJUnitRunner;
41
 import org.mockito.runners.MockitoJUnitRunner;
42
 
42
 
43
-import static org.mockito.Matchers.isA;
43
+import static org.mockito.ArgumentMatchers.isA;
44
 import static org.mockito.Mockito.verify;
44
 import static org.mockito.Mockito.verify;
45
 import static org.mockito.Mockito.when;
45
 import static org.mockito.Mockito.when;
46
 
46
 

+ 3
- 7
src/test/java/com/dmdirc/commandparser/commands/global/NewServerTest.java View File

23
 
23
 
24
 import com.dmdirc.commandparser.CommandArguments;
24
 import com.dmdirc.commandparser.CommandArguments;
25
 import com.dmdirc.commandparser.commands.context.CommandContext;
25
 import com.dmdirc.commandparser.commands.context.CommandContext;
26
-import com.dmdirc.config.profiles.Profile;
27
 import com.dmdirc.config.profiles.ProfileManager;
26
 import com.dmdirc.config.profiles.ProfileManager;
28
 import com.dmdirc.events.CommandErrorEvent;
27
 import com.dmdirc.events.CommandErrorEvent;
29
 import com.dmdirc.interfaces.CommandController;
28
 import com.dmdirc.interfaces.CommandController;
33
 import com.dmdirc.interfaces.WindowModel;
32
 import com.dmdirc.interfaces.WindowModel;
34
 import com.dmdirc.plugins.ServiceManager;
33
 import com.dmdirc.plugins.ServiceManager;
35
 import com.dmdirc.util.URIParser;
34
 import com.dmdirc.util.URIParser;
36
-
37
 import java.net.URI;
35
 import java.net.URI;
38
 import java.net.URISyntaxException;
36
 import java.net.URISyntaxException;
39
-import java.util.Collections;
40
-
41
 import org.junit.Before;
37
 import org.junit.Before;
42
 import org.junit.Test;
38
 import org.junit.Test;
43
 import org.junit.runner.RunWith;
39
 import org.junit.runner.RunWith;
44
 import org.mockito.Mock;
40
 import org.mockito.Mock;
45
 import org.mockito.runners.MockitoJUnitRunner;
41
 import org.mockito.runners.MockitoJUnitRunner;
46
 
42
 
43
+import static org.mockito.ArgumentMatchers.any;
44
+import static org.mockito.ArgumentMatchers.eq;
45
+import static org.mockito.ArgumentMatchers.isA;
47
 import static org.mockito.ArgumentMatchers.isNull;
46
 import static org.mockito.ArgumentMatchers.isNull;
48
-import static org.mockito.Matchers.any;
49
-import static org.mockito.Matchers.eq;
50
-import static org.mockito.Matchers.isA;
51
 import static org.mockito.Mockito.verify;
47
 import static org.mockito.Mockito.verify;
52
 import static org.mockito.Mockito.when;
48
 import static org.mockito.Mockito.when;
53
 
49
 

+ 3
- 3
src/test/java/com/dmdirc/commandparser/commands/server/ChangeServerTest.java View File

41
 import org.mockito.Mock;
41
 import org.mockito.Mock;
42
 import org.mockito.runners.MockitoJUnitRunner;
42
 import org.mockito.runners.MockitoJUnitRunner;
43
 
43
 
44
-import static org.mockito.Matchers.eq;
45
-import static org.mockito.Matchers.isA;
46
-import static org.mockito.Matchers.same;
44
+import static org.mockito.ArgumentMatchers.eq;
45
+import static org.mockito.ArgumentMatchers.isA;
46
+import static org.mockito.ArgumentMatchers.same;
47
 import static org.mockito.Mockito.verify;
47
 import static org.mockito.Mockito.verify;
48
 import static org.mockito.Mockito.when;
48
 import static org.mockito.Mockito.when;
49
 
49
 

+ 3
- 3
src/test/java/com/dmdirc/config/ConfigBinderImplTest.java View File

31
 import org.mockito.runners.MockitoJUnitRunner;
31
 import org.mockito.runners.MockitoJUnitRunner;
32
 
32
 
33
 import static org.junit.Assert.assertEquals;
33
 import static org.junit.Assert.assertEquals;
34
-import static org.mockito.Matchers.any;
35
-import static org.mockito.Matchers.anyBoolean;
36
-import static org.mockito.Matchers.eq;
34
+import static org.mockito.ArgumentMatchers.any;
35
+import static org.mockito.ArgumentMatchers.anyBoolean;
36
+import static org.mockito.ArgumentMatchers.eq;
37
 import static org.mockito.Mockito.when;
37
 import static org.mockito.Mockito.when;
38
 
38
 
39
 @RunWith(MockitoJUnitRunner.class)
39
 @RunWith(MockitoJUnitRunner.class)

+ 1
- 1
src/test/java/com/dmdirc/config/ConfigFileBackedConfigProviderTest.java View File

46
 import static org.junit.Assert.assertFalse;
46
 import static org.junit.Assert.assertFalse;
47
 import static org.junit.Assert.assertNull;
47
 import static org.junit.Assert.assertNull;
48
 import static org.junit.Assert.assertTrue;
48
 import static org.junit.Assert.assertTrue;
49
-import static org.mockito.Matchers.anyString;
49
+import static org.mockito.ArgumentMatchers.anyString;
50
 import static org.mockito.Mockito.never;
50
 import static org.mockito.Mockito.never;
51
 import static org.mockito.Mockito.verify;
51
 import static org.mockito.Mockito.verify;
52
 
52
 

+ 1
- 1
src/test/java/com/dmdirc/config/prefs/PreferencesDialogModelTest.java View File

42
 import static org.junit.Assert.assertNotNull;
42
 import static org.junit.Assert.assertNotNull;
43
 import static org.junit.Assert.assertNull;
43
 import static org.junit.Assert.assertNull;
44
 import static org.junit.Assert.assertTrue;
44
 import static org.junit.Assert.assertTrue;
45
-import static org.mockito.Matchers.isA;
45
+import static org.mockito.ArgumentMatchers.isA;
46
 import static org.mockito.Mockito.mock;
46
 import static org.mockito.Mockito.mock;
47
 import static org.mockito.Mockito.verify;
47
 import static org.mockito.Mockito.verify;
48
 import static org.mockito.Mockito.when;
48
 import static org.mockito.Mockito.when;

+ 1
- 1
src/test/java/com/dmdirc/config/prefs/PreferencesManagerTest.java View File

32
 import org.mockito.Mock;
32
 import org.mockito.Mock;
33
 import org.mockito.runners.MockitoJUnitRunner;
33
 import org.mockito.runners.MockitoJUnitRunner;
34
 
34
 
35
-import static org.mockito.Matchers.isA;
35
+import static org.mockito.ArgumentMatchers.isA;
36
 import static org.mockito.Mockito.verify;
36
 import static org.mockito.Mockito.verify;
37
 
37
 
38
 @RunWith(MockitoJUnitRunner.class)
38
 @RunWith(MockitoJUnitRunner.class)

+ 1
- 1
src/test/java/com/dmdirc/config/profiles/ProfileManagerTest.java View File

40
 import static junit.framework.TestCase.assertEquals;
40
 import static junit.framework.TestCase.assertEquals;
41
 import static junit.framework.TestCase.assertFalse;
41
 import static junit.framework.TestCase.assertFalse;
42
 import static junit.framework.TestCase.assertTrue;
42
 import static junit.framework.TestCase.assertTrue;
43
-import static org.mockito.Matchers.any;
43
+import static org.mockito.ArgumentMatchers.any;
44
 import static org.mockito.Mockito.reset;
44
 import static org.mockito.Mockito.reset;
45
 import static org.mockito.Mockito.verify;
45
 import static org.mockito.Mockito.verify;
46
 import static org.mockito.Mockito.when;
46
 import static org.mockito.Mockito.when;

+ 7
- 11
src/test/java/com/dmdirc/logger/SentryErrorReporterTest.java View File

23
 package com.dmdirc.logger;
23
 package com.dmdirc.logger;
24
 
24
 
25
 import com.dmdirc.util.ClientInfo;
25
 import com.dmdirc.util.ClientInfo;
26
-
26
+import com.getsentry.raven.Raven;
27
+import com.getsentry.raven.RavenFactory;
28
+import com.getsentry.raven.event.Event;
29
+import com.getsentry.raven.event.interfaces.ExceptionInterface;
30
+import com.getsentry.raven.event.interfaces.SentryInterface;
27
 import java.time.LocalDateTime;
31
 import java.time.LocalDateTime;
28
 import java.time.ZoneOffset;
32
 import java.time.ZoneOffset;
29
 import java.util.Optional;
33
 import java.util.Optional;
30
-
31
 import org.junit.Before;
34
 import org.junit.Before;
32
 import org.junit.BeforeClass;
35
 import org.junit.BeforeClass;
33
 import org.junit.Test;
36
 import org.junit.Test;
34
 import org.junit.runner.RunWith;
37
 import org.junit.runner.RunWith;
35
 import org.mockito.ArgumentCaptor;
38
 import org.mockito.ArgumentCaptor;
36
 import org.mockito.Captor;
39
 import org.mockito.Captor;
37
-import org.mockito.Matchers;
38
 import org.mockito.Mock;
40
 import org.mockito.Mock;
39
 import org.mockito.runners.MockitoJUnitRunner;
41
 import org.mockito.runners.MockitoJUnitRunner;
40
 
42
 
41
-import com.getsentry.raven.Raven;
42
-import com.getsentry.raven.RavenFactory;
43
-import com.getsentry.raven.dsn.Dsn;
44
-import com.getsentry.raven.event.Event;
45
-import com.getsentry.raven.event.interfaces.ExceptionInterface;
46
-import com.getsentry.raven.event.interfaces.SentryInterface;
47
-
48
 import static org.junit.Assert.assertEquals;
43
 import static org.junit.Assert.assertEquals;
49
 import static org.junit.Assert.assertNotNull;
44
 import static org.junit.Assert.assertNotNull;
50
 import static org.junit.Assert.assertTrue;
45
 import static org.junit.Assert.assertTrue;
46
+import static org.mockito.ArgumentMatchers.any;
51
 import static org.mockito.Mockito.mock;
47
 import static org.mockito.Mockito.mock;
52
 import static org.mockito.Mockito.verify;
48
 import static org.mockito.Mockito.verify;
53
 import static org.mockito.Mockito.when;
49
 import static org.mockito.Mockito.when;
71
 
67
 
72
     @Before
68
     @Before
73
     public void setUp() {
69
     public void setUp() {
74
-        when(ravenFactory.createRavenInstance(Matchers.<Dsn>anyObject())).thenReturn(raven);
70
+        when(ravenFactory.createRavenInstance(any())).thenReturn(raven);
75
         throwable = Optional.of(new IllegalArgumentException());
71
         throwable = Optional.of(new IllegalArgumentException());
76
         sentryErrorReporter = new SentryErrorReporter(clientInfo);
72
         sentryErrorReporter = new SentryErrorReporter(clientInfo);
77
     }
73
     }

+ 3
- 3
src/test/java/com/dmdirc/logger/SentryLoggingErrorManagerTest.java View File

39
 import org.mockito.runners.MockitoJUnitRunner;
39
 import org.mockito.runners.MockitoJUnitRunner;
40
 
40
 
41
 import static org.mockito.ArgumentMatchers.isNull;
41
 import static org.mockito.ArgumentMatchers.isNull;
42
-import static org.mockito.Matchers.any;
43
-import static org.mockito.Matchers.anyString;
44
-import static org.mockito.Matchers.eq;
42
+import static org.mockito.ArgumentMatchers.any;
43
+import static org.mockito.ArgumentMatchers.anyString;
44
+import static org.mockito.ArgumentMatchers.eq;
45
 import static org.mockito.Mockito.never;
45
 import static org.mockito.Mockito.never;
46
 import static org.mockito.Mockito.verify;
46
 import static org.mockito.Mockito.verify;
47
 import static org.mockito.Mockito.when;
47
 import static org.mockito.Mockito.when;

+ 12
- 11
src/test/java/com/dmdirc/ui/WindowManagerTest.java View File

43
 import static org.junit.Assert.assertNull;
43
 import static org.junit.Assert.assertNull;
44
 import static org.junit.Assert.assertSame;
44
 import static org.junit.Assert.assertSame;
45
 import static org.junit.Assert.assertTrue;
45
 import static org.junit.Assert.assertTrue;
46
-import static org.mockito.Matchers.anyBoolean;
47
-import static org.mockito.Matchers.anyObject;
48
-import static org.mockito.Matchers.eq;
49
-import static org.mockito.Matchers.same;
46
+import static org.mockito.ArgumentMatchers.any;
47
+import static org.mockito.ArgumentMatchers.anyBoolean;
48
+import static org.mockito.ArgumentMatchers.anyObject;
49
+import static org.mockito.ArgumentMatchers.eq;
50
+import static org.mockito.ArgumentMatchers.same;
50
 import static org.mockito.Mockito.mock;
51
 import static org.mockito.Mockito.mock;
51
 import static org.mockito.Mockito.never;
52
 import static org.mockito.Mockito.never;
52
 import static org.mockito.Mockito.verify;
53
 import static org.mockito.Mockito.verify;
133
 
134
 
134
         manager.removeWindow(child);
135
         manager.removeWindow(child);
135
 
136
 
136
-        verify(frameListener, never()).addWindow(anyObject(), anyBoolean());
137
-        verify(frameListener, never()).addWindow(anyObject(), anyObject(), anyBoolean());
138
-        verify(frameListener, never()).delWindow(anyObject());
137
+        verify(frameListener, never()).addWindow(any(), anyBoolean());
138
+        verify(frameListener, never()).addWindow(any(), any(), anyBoolean());
139
+        verify(frameListener, never()).delWindow(any());
139
         verify(frameListener).delWindow(same(container), same(child));
140
         verify(frameListener).delWindow(same(container), same(child));
140
     }
141
     }
141
 
142
 
146
         manager.removeListener(frameListener);
147
         manager.removeListener(frameListener);
147
         manager.addWindow(container, child);
148
         manager.addWindow(container, child);
148
 
149
 
149
-        verify(frameListener, never()).addWindow(anyObject(), anyBoolean());
150
-        verify(frameListener, never()).addWindow(anyObject(), anyObject(), anyBoolean());
151
-        verify(frameListener, never()).delWindow(anyObject());
152
-        verify(frameListener, never()).delWindow(anyObject(), anyObject());
150
+        verify(frameListener, never()).addWindow(any(), anyBoolean());
151
+        verify(frameListener, never()).addWindow(any(), any(), anyBoolean());
152
+        verify(frameListener, never()).delWindow(any());
153
+        verify(frameListener, never()).delWindow(any(), any());
153
     }
154
     }
154
 
155
 
155
     @Test
156
     @Test

+ 2
- 2
src/test/java/com/dmdirc/ui/core/aliases/CoreAliasDialogModelTest.java View File

44
 import static org.junit.Assert.assertEquals;
44
 import static org.junit.Assert.assertEquals;
45
 import static org.junit.Assert.assertFalse;
45
 import static org.junit.Assert.assertFalse;
46
 import static org.junit.Assert.assertTrue;
46
 import static org.junit.Assert.assertTrue;
47
-import static org.mockito.Matchers.anyInt;
48
-import static org.mockito.Matchers.anyString;
47
+import static org.mockito.ArgumentMatchers.anyInt;
48
+import static org.mockito.ArgumentMatchers.anyString;
49
 import static org.mockito.Mockito.never;
49
 import static org.mockito.Mockito.never;
50
 import static org.mockito.Mockito.verify;
50
 import static org.mockito.Mockito.verify;
51
 import static org.mockito.Mockito.when;
51
 import static org.mockito.Mockito.when;

+ 1
- 1
src/test/java/com/dmdirc/ui/core/autocommands/CoreGlobalAutoCommandsDialogModelTest.java View File

38
 import static org.junit.Assert.assertFalse;
38
 import static org.junit.Assert.assertFalse;
39
 import static org.junit.Assert.assertNotNull;
39
 import static org.junit.Assert.assertNotNull;
40
 import static org.junit.Assert.assertTrue;
40
 import static org.junit.Assert.assertTrue;
41
-import static org.mockito.Matchers.eq;
41
+import static org.mockito.ArgumentMatchers.eq;
42
 import static org.mockito.Mockito.verify;
42
 import static org.mockito.Mockito.verify;
43
 import static org.mockito.Mockito.when;
43
 import static org.mockito.Mockito.when;
44
 
44
 

+ 0
- 4
src/test/java/com/dmdirc/ui/core/feedback/CoreFeedbackDialogModelTest.java View File

23
 package com.dmdirc.ui.core.feedback;
23
 package com.dmdirc.ui.core.feedback;
24
 
24
 
25
 import com.dmdirc.interfaces.ui.FeedbackDialogModelListener;
25
 import com.dmdirc.interfaces.ui.FeedbackDialogModelListener;
26
-
27
 import java.util.Optional;
26
 import java.util.Optional;
28
-
29
 import org.junit.Before;
27
 import org.junit.Before;
30
 import org.junit.Test;
28
 import org.junit.Test;
31
 import org.junit.runner.RunWith;
29
 import org.junit.runner.RunWith;
35
 import static org.junit.Assert.assertEquals;
33
 import static org.junit.Assert.assertEquals;
36
 import static org.junit.Assert.assertFalse;
34
 import static org.junit.Assert.assertFalse;
37
 import static org.junit.Assert.assertTrue;
35
 import static org.junit.Assert.assertTrue;
38
-import static org.mockito.Matchers.anyString;
39
 import static org.mockito.Mockito.verify;
36
 import static org.mockito.Mockito.verify;
40
-import static org.mockito.Mockito.when;
41
 
37
 
42
 @RunWith(MockitoJUnitRunner.class)
38
 @RunWith(MockitoJUnitRunner.class)
43
 public class CoreFeedbackDialogModelTest {
39
 public class CoreFeedbackDialogModelTest {

+ 5
- 11
src/test/java/com/dmdirc/ui/core/feedback/FeedbackSenderTest.java View File

26
 import com.dmdirc.interfaces.EventBus;
26
 import com.dmdirc.interfaces.EventBus;
27
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
27
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
28
 import com.dmdirc.util.io.Downloader;
28
 import com.dmdirc.util.io.Downloader;
29
-
30
 import com.google.common.collect.ImmutableMap;
29
 import com.google.common.collect.ImmutableMap;
31
 import com.google.common.collect.Lists;
30
 import com.google.common.collect.Lists;
32
 import com.google.common.collect.Maps;
31
 import com.google.common.collect.Maps;
33
-
34
 import java.io.IOException;
32
 import java.io.IOException;
35
 import java.util.Map;
33
 import java.util.Map;
36
-
37
 import org.junit.Before;
34
 import org.junit.Before;
38
 import org.junit.Test;
35
 import org.junit.Test;
39
 import org.junit.runner.RunWith;
36
 import org.junit.runner.RunWith;
43
 import org.mockito.runners.MockitoJUnitRunner;
40
 import org.mockito.runners.MockitoJUnitRunner;
44
 
41
 
45
 import static junit.framework.TestCase.assertEquals;
42
 import static junit.framework.TestCase.assertEquals;
46
-import static org.mockito.Matchers.anyMapOf;
47
-import static org.mockito.Matchers.anyString;
43
+import static org.mockito.ArgumentMatchers.anyMap;
44
+import static org.mockito.ArgumentMatchers.anyString;
48
 import static org.mockito.Mockito.verify;
45
 import static org.mockito.Mockito.verify;
49
 import static org.mockito.Mockito.when;
46
 import static org.mockito.Mockito.when;
50
 
47
 
70
     @Before
67
     @Before
71
     public void setUp() throws Exception {
68
     public void setUp() throws Exception {
72
         feedbackSenderFactory = new FeedbackSenderFactory(config, downloader, eventBus);
69
         feedbackSenderFactory = new FeedbackSenderFactory(config, downloader, eventBus);
73
-        when(downloader.getPage(anyString(), anyMapOf(String.class, String.class)))
74
-                .thenReturn(Lists.newArrayList("Success."));
70
+        when(downloader.getPage(anyString(), anyMap())).thenReturn(Lists.newArrayList("Success."));
75
         expectedInfo = Maps.newHashMap(ImmutableMap.<String, String>builder()
71
         expectedInfo = Maps.newHashMap(ImmutableMap.<String, String>builder()
76
                 .put("name", NAME).put("email", EMAIL)
72
                 .put("name", NAME).put("email", EMAIL)
77
                 .put("feedback", FEEDBACK)
73
                 .put("feedback", FEEDBACK)
159
 
155
 
160
     @Test
156
     @Test
161
     public void testRun_WithFail() throws Exception {
157
     public void testRun_WithFail() throws Exception {
162
-        when(downloader.getPage(anyString(), anyMapOf(String.class, String.class)))
163
-                .thenReturn(Lists.newArrayList());
158
+        when(downloader.getPage(anyString(), anyMap())).thenReturn(Lists.newArrayList());
164
         feedbackSender = feedbackSenderFactory.getFeedbackSender(NAME, EMAIL, FEEDBACK, VERSION,
159
         feedbackSender = feedbackSenderFactory.getFeedbackSender(NAME, EMAIL, FEEDBACK, VERSION,
165
                 SERVER_INFO, DMDIRC_INFO);
160
                 SERVER_INFO, DMDIRC_INFO);
166
         feedbackSender.run();
161
         feedbackSender.run();
172
 
167
 
173
     @Test
168
     @Test
174
     public void testRun_WithException() throws Exception {
169
     public void testRun_WithException() throws Exception {
175
-        when(downloader.getPage(anyString(), anyMapOf(String.class, String.class)))
176
-                .thenThrow(new IOException("Fail."));
170
+        when(downloader.getPage(anyString(), anyMap())).thenThrow(new IOException("Fail."));
177
         feedbackSender = feedbackSenderFactory.getFeedbackSender(NAME, EMAIL, FEEDBACK, VERSION,
171
         feedbackSender = feedbackSenderFactory.getFeedbackSender(NAME, EMAIL, FEEDBACK, VERSION,
178
                 SERVER_INFO, DMDIRC_INFO);
172
                 SERVER_INFO, DMDIRC_INFO);
179
         feedbackSender.run();
173
         feedbackSender.run();

+ 1
- 1
src/test/java/com/dmdirc/ui/core/newserver/CoreNewServerDialogModelTest.java View File

47
 import static org.junit.Assert.assertEquals;
47
 import static org.junit.Assert.assertEquals;
48
 import static org.junit.Assert.assertFalse;
48
 import static org.junit.Assert.assertFalse;
49
 import static org.junit.Assert.assertTrue;
49
 import static org.junit.Assert.assertTrue;
50
-import static org.mockito.Matchers.any;
50
+import static org.mockito.ArgumentMatchers.any;
51
 import static org.mockito.Mockito.never;
51
 import static org.mockito.Mockito.never;
52
 import static org.mockito.Mockito.verify;
52
 import static org.mockito.Mockito.verify;
53
 import static org.mockito.Mockito.when;
53
 import static org.mockito.Mockito.when;

+ 10
- 13
src/test/java/com/dmdirc/ui/core/profiles/CoreProfilesDialogModelTest.java View File

42
 import static org.junit.Assert.assertEquals;
42
 import static org.junit.Assert.assertEquals;
43
 import static org.junit.Assert.assertFalse;
43
 import static org.junit.Assert.assertFalse;
44
 import static org.junit.Assert.assertTrue;
44
 import static org.junit.Assert.assertTrue;
45
-import static org.mockito.Matchers.any;
45
+import static org.mockito.ArgumentMatchers.any;
46
 import static org.mockito.Mockito.never;
46
 import static org.mockito.Mockito.never;
47
 import static org.mockito.Mockito.times;
47
 import static org.mockito.Mockito.times;
48
 import static org.mockito.Mockito.verify;
48
 import static org.mockito.Mockito.verify;
56
     private MutableProfile mutableProfile1;
56
     private MutableProfile mutableProfile1;
57
     private MutableProfile mutableProfile2;
57
     private MutableProfile mutableProfile2;
58
     private MutableProfile mutableProfile3;
58
     private MutableProfile mutableProfile3;
59
-    private MutableProfile mutableProfile4;
60
     private List<MutableProfile> mutableProfiles;
59
     private List<MutableProfile> mutableProfiles;
61
     private CoreProfilesDialogModel instance;
60
     private CoreProfilesDialogModel instance;
62
 
61
 
71
         mutableProfile1 = new MutableProfile(profile1);
70
         mutableProfile1 = new MutableProfile(profile1);
72
         mutableProfile2 = new MutableProfile(profile2);
71
         mutableProfile2 = new MutableProfile(profile2);
73
         mutableProfile3 = new MutableProfile(profile3);
72
         mutableProfile3 = new MutableProfile(profile3);
74
-        mutableProfile4 = new MutableProfile(profile4);
75
         mutableProfiles = Lists.newArrayList(mutableProfile1, mutableProfile2, mutableProfile3);
73
         mutableProfiles = Lists.newArrayList(mutableProfile1, mutableProfile2, mutableProfile3);
76
         Collections.sort(mutableProfiles, comparing(MutableProfile::getName));
74
         Collections.sort(mutableProfiles, comparing(MutableProfile::getName));
77
         when(profileManager.getProfiles()).thenReturn(profiles);
75
         when(profileManager.getProfiles()).thenReturn(profiles);
196
         instance.setSelectedProfile(instance.getProfile("profile1"));
194
         instance.setSelectedProfile(instance.getProfile("profile1"));
197
         assertEquals("testSetSelectedProfileSelectedNickname", Optional.<String>empty(),
195
         assertEquals("testSetSelectedProfileSelectedNickname", Optional.<String>empty(),
198
                 instance.getSelectedProfileSelectedNickname());
196
                 instance.getSelectedProfileSelectedNickname());
199
-        instance.setSelectedProfileSelectedNickname(Optional.ofNullable("nickname12"));
197
+        instance.setSelectedProfileSelectedNickname(Optional.of("nickname12"));
200
         verify(listener).selectedNicknameChanged(Optional.of("nickname12"));
198
         verify(listener).selectedNicknameChanged(Optional.of("nickname12"));
201
-        assertEquals("testSetSelectedProfileSelectedNickname", Optional.ofNullable("nickname12"),
199
+        assertEquals("testSetSelectedProfileSelectedNickname", Optional.of("nickname12"),
202
                 instance.getSelectedProfileSelectedNickname());
200
                 instance.getSelectedProfileSelectedNickname());
203
     }
201
     }
204
 
202
 
206
     public void testSetSelectedProfileDetails() {
204
     public void testSetSelectedProfileDetails() {
207
         instance.setSelectedProfile(instance.getProfile("profile2"));
205
         instance.setSelectedProfile(instance.getProfile("profile2"));
208
         verify(listener).profileSelectionChanged(Optional.of(mutableProfile2));
206
         verify(listener).profileSelectionChanged(Optional.of(mutableProfile2));
209
-        instance.setSelectedProfileName(Optional.ofNullable("testName"));
210
-        instance.setSelectedProfileIdent(Optional.ofNullable("testIdent"));
211
-        instance.setSelectedProfileRealname(Optional.ofNullable("testRealname"));
212
-        instance.setSelectedProfileNicknames(Optional.ofNullable((List<String>) Lists.
213
-                newArrayList("testNickname")));
207
+        instance.setSelectedProfileName(Optional.of("testName"));
208
+        instance.setSelectedProfileIdent(Optional.of("testIdent"));
209
+        instance.setSelectedProfileRealname(Optional.of("testRealname"));
210
+        instance.setSelectedProfileNicknames(Optional.of(Lists.newArrayList("testNickname")));
214
         assertEquals("testGetSelectedProfileDetails", "testName",
211
         assertEquals("testGetSelectedProfileDetails", "testName",
215
                 instance.getSelectedProfileName().get());
212
                 instance.getSelectedProfileName().get());
216
         assertEquals("testGetSelectedProfileDetails", "testIdent",
213
         assertEquals("testGetSelectedProfileDetails", "testIdent",
251
     @Test
248
     @Test
252
     public void testEditSelectedProfileSelectedNickname() {
249
     public void testEditSelectedProfileSelectedNickname() {
253
         instance.setSelectedProfile(instance.getProfile("profile1"));
250
         instance.setSelectedProfile(instance.getProfile("profile1"));
254
-        instance.setSelectedProfileSelectedNickname(Optional.ofNullable("nickname12"));
251
+        instance.setSelectedProfileSelectedNickname(Optional.of("nickname12"));
255
         assertEquals("testSetSelectedProfileSelectedNickname",
252
         assertEquals("testSetSelectedProfileSelectedNickname",
256
-                Optional.ofNullable("nickname12"),
253
+                Optional.of("nickname12"),
257
                 instance.getSelectedProfileSelectedNickname());
254
                 instance.getSelectedProfileSelectedNickname());
258
         instance.editSelectedProfileNickname("nickname12", "nickname4");
255
         instance.editSelectedProfileNickname("nickname12", "nickname4");
259
         verify(listener).selectedProfileNicknameEdited("nickname12", "nickname4");
256
         verify(listener).selectedProfileNicknameEdited("nickname12", "nickname4");
275
         final MutableProfile profile4 = instance.getProfile("profile4").get();
272
         final MutableProfile profile4 = instance.getProfile("profile4").get();
276
         verify(listener).profileAdded(profile4);
273
         verify(listener).profileAdded(profile4);
277
         instance.removeListener(listener);
274
         instance.removeListener(listener);
278
-        instance.setSelectedProfile(Optional.ofNullable(profile4));
275
+        instance.setSelectedProfile(Optional.of(profile4));
279
         verify(listener, never()).profileRemoved(profile4);
276
         verify(listener, never()).profileRemoved(profile4);
280
     }
277
     }
281
 
278
 

+ 4
- 4
src/test/java/com/dmdirc/ui/messages/FormatterTest.java View File

22
 package com.dmdirc.ui.messages;
22
 package com.dmdirc.ui.messages;
23
 
23
 
24
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
24
 import com.dmdirc.interfaces.config.AggregateConfigProvider;
25
-
26
 import org.junit.Before;
25
 import org.junit.Before;
27
 import org.junit.Test;
26
 import org.junit.Test;
28
 import org.junit.runner.RunWith;
27
 import org.junit.runner.RunWith;
31
 import org.mockito.runners.MockitoJUnitRunner;
30
 import org.mockito.runners.MockitoJUnitRunner;
32
 import org.mockito.stubbing.Answer;
31
 import org.mockito.stubbing.Answer;
33
 
32
 
34
-import static org.junit.Assert.*;
35
-import static org.mockito.Matchers.any;
36
-import static org.mockito.Matchers.startsWith;
33
+import static org.junit.Assert.assertEquals;
34
+import static org.junit.Assert.assertTrue;
35
+import static org.mockito.ArgumentMatchers.any;
36
+import static org.mockito.ArgumentMatchers.startsWith;
37
 import static org.mockito.Mockito.when;
37
 import static org.mockito.Mockito.when;
38
 
38
 
39
 @RunWith(MockitoJUnitRunner.class)
39
 @RunWith(MockitoJUnitRunner.class)

+ 1
- 1
src/test/java/com/dmdirc/ui/messages/HighlightManagerTest.java View File

47
 import org.mockito.runners.MockitoJUnitRunner;
47
 import org.mockito.runners.MockitoJUnitRunner;
48
 
48
 
49
 import static org.junit.Assert.assertEquals;
49
 import static org.junit.Assert.assertEquals;
50
-import static org.mockito.Matchers.any;
50
+import static org.mockito.ArgumentMatchers.any;
51
 import static org.mockito.Mockito.never;
51
 import static org.mockito.Mockito.never;
52
 import static org.mockito.Mockito.only;
52
 import static org.mockito.Mockito.only;
53
 import static org.mockito.Mockito.verify;
53
 import static org.mockito.Mockito.verify;

+ 1
- 1
src/test/java/com/dmdirc/updater/checking/NightlyCheckerTest.java View File

45
 
45
 
46
 import static org.junit.Assert.assertEquals;
46
 import static org.junit.Assert.assertEquals;
47
 import static org.junit.Assert.assertTrue;
47
 import static org.junit.Assert.assertTrue;
48
-import static org.mockito.Matchers.anyString;
48
+import static org.mockito.ArgumentMatchers.anyString;
49
 import static org.mockito.Mockito.when;
49
 import static org.mockito.Mockito.when;
50
 
50
 
51
 @RunWith(MockitoJUnitRunner.class)
51
 @RunWith(MockitoJUnitRunner.class)

+ 2
- 2
src/test/java/com/dmdirc/updater/installing/LegacyInstallationStrategyTest.java View File

30
 
30
 
31
 import org.junit.Before;
31
 import org.junit.Before;
32
 import org.junit.Test;
32
 import org.junit.Test;
33
-import org.mockito.Matchers;
34
 
33
 
34
+import static org.mockito.ArgumentMatchers.any;
35
 import static org.mockito.Mockito.mock;
35
 import static org.mockito.Mockito.mock;
36
 import static org.mockito.Mockito.verify;
36
 import static org.mockito.Mockito.verify;
37
 import static org.mockito.Mockito.when;
37
 import static org.mockito.Mockito.when;
85
         when(file.toString()).thenReturn("path");
85
         when(file.toString()).thenReturn("path");
86
         when(file.toAbsolutePath()).thenReturn(absoluteFile);
86
         when(file.toAbsolutePath()).thenReturn(absoluteFile);
87
         when(absoluteFile.toString()).thenReturn("/my/path");
87
         when(absoluteFile.toString()).thenReturn("/my/path");
88
-        when(component.doInstall(Matchers.<Path>anyObject())).thenThrow(new IOException());
88
+        when(component.doInstall(any())).thenThrow(new IOException());
89
         strategy.addUpdateInstallationListener(listener);
89
         strategy.addUpdateInstallationListener(listener);
90
         strategy.installImpl(component, result);
90
         strategy.installImpl(component, result);
91
         verify(listener).installFailed(component);
91
         verify(listener).installFailed(component);

+ 2
- 2
src/test/java/com/dmdirc/util/URLBuilderTest.java View File

39
 import org.junit.Rule;
39
 import org.junit.Rule;
40
 import org.junit.Test;
40
 import org.junit.Test;
41
 import org.junit.runner.RunWith;
41
 import org.junit.runner.RunWith;
42
-import org.mockito.Matchers;
43
 import org.mockito.Mock;
42
 import org.mockito.Mock;
44
 import org.mockito.runners.MockitoJUnitRunner;
43
 import org.mockito.runners.MockitoJUnitRunner;
45
 
44
 
45
+import static org.mockito.ArgumentMatchers.anyString;
46
 import static org.mockito.Mockito.when;
46
 import static org.mockito.Mockito.when;
47
 
47
 
48
 @RunWith(MockitoJUnitRunner.class)
48
 @RunWith(MockitoJUnitRunner.class)
62
     public void setup() throws MalformedURLException {
62
     public void setup() throws MalformedURLException {
63
         when(pluginManagerProvider.get()).thenReturn(pluginManager);
63
         when(pluginManagerProvider.get()).thenReturn(pluginManager);
64
         when(themeManagerProvider.get()).thenReturn(themeManager);
64
         when(themeManagerProvider.get()).thenReturn(themeManager);
65
-        when(pluginManager.getPluginInfoByName(Matchers.anyString())).thenReturn(pluginInfo);
65
+        when(pluginManager.getPluginInfoByName(anyString())).thenReturn(pluginInfo);
66
         when(themeManager.getDirectory()).thenReturn("/themes/");
66
         when(themeManager.getDirectory()).thenReturn("/themes/");
67
         when(pluginInfo.getMetaData()).thenReturn(pluginMetaData);
67
         when(pluginInfo.getMetaData()).thenReturn(pluginMetaData);
68
         when(pluginMetaData.getPluginPath()).thenReturn(jimFsRule.getPath("file://testPlugin"));
68
         when(pluginMetaData.getPluginPath()).thenReturn(jimFsRule.getPath("file://testPlugin"));

Loading…
Cancel
Save