浏览代码

Get rid of TestConfigListener in favour of mocking them when needed

tags/0.6.3m1rc1
Chris Smith 15 年前
父节点
当前提交
0e29292263

+ 9
- 8
test/com/dmdirc/config/ConfigManagerTest.java 查看文件

21
  */
21
  */
22
 package com.dmdirc.config;
22
 package com.dmdirc.config;
23
 
23
 
24
-import com.dmdirc.harness.TestConfigListener;
25
 import com.dmdirc.interfaces.ConfigChangeListener;
24
 import com.dmdirc.interfaces.ConfigChangeListener;
25
+
26
 import org.junit.Test;
26
 import org.junit.Test;
27
 import static org.junit.Assert.*;
27
 import static org.junit.Assert.*;
28
+import static org.mockito.Mockito.*;
28
 
29
 
29
 public class ConfigManagerTest {
30
 public class ConfigManagerTest {
30
     
31
     
44
     
45
     
45
     @Test
46
     @Test
46
     public void testDomainListener() {
47
     public void testDomainListener() {
47
-        final TestConfigListener listener = new TestConfigListener();
48
+        final ConfigChangeListener listener = mock(ConfigChangeListener.class);
48
         final ConfigManager cm = new ConfigManager("", "", "");
49
         final ConfigManager cm = new ConfigManager("", "", "");
49
         cm.addChangeListener("unit-test", listener);
50
         cm.addChangeListener("unit-test", listener);
50
         
51
         
51
         cm.configChanged("foo", "bar");
52
         cm.configChanged("foo", "bar");
52
-        assertEquals(0, listener.count);
53
+        verify(listener, never()).configChanged(anyString(), anyString());
53
         
54
         
54
         cm.configChanged("unit-test", "bar");
55
         cm.configChanged("unit-test", "bar");
55
-        assertEquals(1, listener.count);
56
+        verify(listener).configChanged("unit-test", "bar");
56
     }
57
     }
57
     
58
     
58
     @Test
59
     @Test
59
     public void testDomainKeyListener() {
60
     public void testDomainKeyListener() {
60
-        final TestConfigListener listener = new TestConfigListener();
61
+        final ConfigChangeListener listener = mock(ConfigChangeListener.class);
61
         final ConfigManager cm = new ConfigManager("", "", "");
62
         final ConfigManager cm = new ConfigManager("", "", "");
62
         cm.addChangeListener("unit-test", "foo", listener);
63
         cm.addChangeListener("unit-test", "foo", listener);
63
         
64
         
64
         cm.configChanged("foo", "bar");
65
         cm.configChanged("foo", "bar");
65
-        assertEquals(0, listener.count);
66
+        verify(listener, never()).configChanged(anyString(), anyString());
66
         
67
         
67
         cm.configChanged("unit-test", "bar");
68
         cm.configChanged("unit-test", "bar");
68
-        assertEquals(0, listener.count);
69
+        verify(listener, never()).configChanged(anyString(), anyString());
69
         
70
         
70
         cm.configChanged("unit-test", "foo");
71
         cm.configChanged("unit-test", "foo");
71
-        assertEquals(1, listener.count);        
72
+        verify(listener).configChanged("unit-test", "foo");
72
     }    
73
     }    
73
     
74
     
74
 }
75
 }

+ 11
- 11
test/com/dmdirc/config/IdentityTest.java 查看文件

22
 
22
 
23
 package com.dmdirc.config;
23
 package com.dmdirc.config;
24
 
24
 
25
-import com.dmdirc.harness.TestConfigListener;
25
+import com.dmdirc.interfaces.ConfigChangeListener;
26
 
26
 
27
 import java.io.IOException;
27
 import java.io.IOException;
28
 import java.util.Map;
28
 import java.util.Map;
31
 import org.junit.Before;
31
 import org.junit.Before;
32
 import org.junit.Test;
32
 import org.junit.Test;
33
 import static org.junit.Assert.*;
33
 import static org.junit.Assert.*;
34
+import static org.mockito.Mockito.*;
34
 
35
 
35
 public class IdentityTest {
36
 public class IdentityTest {
36
     
37
     
180
     
181
     
181
     @Test
182
     @Test
182
     public void testSetListener() {
183
     public void testSetListener() {
183
-        final TestConfigListener listener = new TestConfigListener();
184
+        final ConfigChangeListener listener = mock(ConfigChangeListener.class);
184
         myIdent.addListener(listener);
185
         myIdent.addListener(listener);
185
-        assertEquals(0, listener.count);
186
+
187
+        verify(listener, never()).configChanged(anyString(), anyString());
186
         
188
         
187
         myIdent.setOption("unit", "test", "meep");        
189
         myIdent.setOption("unit", "test", "meep");        
188
 
190
 
189
-        assertEquals(1, listener.count);
190
-        assertEquals("unit", listener.domain);
191
-        assertEquals("test", listener.key);
191
+        verify(listener).configChanged("unit", "test");
192
     }    
192
     }    
193
     
193
     
194
     @Test
194
     @Test
195
     public void testUnsetListener() {
195
     public void testUnsetListener() {
196
-        final TestConfigListener listener = new TestConfigListener();
196
+        final ConfigChangeListener listener = mock(ConfigChangeListener.class);
197
         myIdent.setOption("unit", "test", "meep");
197
         myIdent.setOption("unit", "test", "meep");
198
         myIdent.addListener(listener);
198
         myIdent.addListener(listener);
199
+
200
+        verify(listener, never()).configChanged(anyString(), anyString());
199
         
201
         
200
-        assertEquals(0, listener.count);
201
         myIdent.unsetOption("unit", "test");
202
         myIdent.unsetOption("unit", "test");
202
-        assertEquals(1, listener.count);
203
-        assertEquals("unit", listener.domain);
204
-        assertEquals("test", listener.key);
203
+
204
+        verify(listener).configChanged("unit", "test");
205
     }
205
     }
206
     
206
     
207
 }
207
 }

+ 0
- 37
test/com/dmdirc/harness/TestConfigListener.java 查看文件

1
-/*
2
- * Copyright (c) 2006-2009 Chris Smith, Shane Mc Cormack, Gregory Holmes
3
- *
4
- * Permission is hereby granted, free of charge, to any person obtaining a copy
5
- * of this software and associated documentation files (the "Software"), to deal
6
- * in the Software without restriction, including without limitation the rights
7
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
8
- * copies of the Software, and to permit persons to whom the Software is
9
- * furnished to do so, subject to the following conditions:
10
- *
11
- * The above copyright notice and this permission notice shall be included in
12
- * all copies or substantial portions of the Software.
13
- *
14
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
15
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
16
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
17
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
18
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
19
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
20
- * SOFTWARE.
21
- */
22
-
23
-package com.dmdirc.harness;
24
-
25
-import com.dmdirc.interfaces.ConfigChangeListener;
26
-
27
-public class TestConfigListener implements ConfigChangeListener {
28
-
29
-    public int count = 0;
30
-    public String domain, key;
31
-
32
-    public void configChanged(String domain, String key) {
33
-        count++;
34
-        this.domain = domain;
35
-        this.key = key;
36
-    }
37
-}

正在加载...
取消
保存