Handle weights properly

code/ContextHome/src/uk/co/md87/android/contexthome/ContextHome.java

@@ -42,8 +42,6 @@ public class ContextHome extends Activity {
     private LinearLayout layout;
     private final Module[] modules = new Module[]{
         new SmsModule(), new SmsModule(), new SmsModule(), new SmsModule(),
-        new SmsModule(), new SmsModule(), new SmsModule(), new SmsModule(),
-        new SmsModule(), new SmsModule(),
     };
 
     /** Called when the activity is first created. */
@@ -52,7 +50,6 @@ public class ContextHome extends Activity {
         super.onCreate(icicle);
         
         layout = new LinearLayout(this);
-        MODULE_PARAMS.weight = (float) 1 / 10;
         layout.setOrientation(LinearLayout.VERTICAL);
         setContentView(layout);
 
@@ -62,8 +59,11 @@ public class ContextHome extends Activity {
     private void initLayout() {
         layout.removeAllViews();
 
+        int i = 0;
         for (Module module : modules) {
-            layout.addView(module.getView(this, 1), MODULE_PARAMS);
+            final LayoutParams params = new LayoutParams(MODULE_PARAMS);
+            params.weight = (float) ++i / 10;
+            layout.addView(module.getView(this, i), params);
         }
     }
 

code/ContextHome/src/uk/co/md87/android/contexthome/modules/SmsModule.java

@@ -43,16 +43,19 @@ public class SmsModule implements Module {
     @Override
     public View getView(final Context context, final int weight) {
         final LinearLayout layout = new LinearLayout(context);
-        final TextView text = new TextView(context);
+        layout.setOrientation(LinearLayout.VERTICAL);
 
         final Cursor cursor = context.getContentResolver().query(INBOX_URI,
                 new String[] { "_id", "date", "body" }, null, null, "date DESC");
-        if (cursor.moveToFirst()) {
+        boolean success = cursor.moveToFirst();
+        for (int i = 0; i < weight && success; i++) {
+            final TextView text = new TextView(context);
             text.setText(cursor.getString(cursor.getColumnIndex("body")));
+            layout.addView(text);
+            success = cursor.moveToNext();
         }
         cursor.close();
         
-        layout.addView(text);
 
         return layout;
     }